From: Aryeh Gregor <simetrical@users.mediawiki.org>
Date: Sun, 21 Feb 2010 01:44:25 +0000 (+0000)
Subject: Fix comment, remove unused global
X-Git-Tag: 1.31.0-rc.0~37681
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/recherche.php?a=commitdiff_plain;h=23bc48ea350c63b7ffc5896ea8bb7e3561b64cd0;p=lhc%2Fweb%2Fwiklou.git

Fix comment, remove unused global
---

diff --git a/includes/Html.php b/includes/Html.php
index ed06411df1..4e37f10ef4 100644
--- a/includes/Html.php
+++ b/includes/Html.php
@@ -137,7 +137,7 @@ class Html {
 	 * tag (and the self-closing / in XML mode for empty elements).
 	 */
 	public static function openElement( $element, $attribs = array() ) {
-		global $wgHtml5, $wgWellFormedXml;
+		global $wgHtml5;
 		$attribs = (array)$attribs;
 		# This is not required in HTML5, but let's do it anyway, for
 		# consistency and better compression.
@@ -376,8 +376,9 @@ class Html {
 					"\t" => '&#9;'
 				);
 				if ( $wgWellFormedXml ) {
-					# '<' must be escaped in attributes for XML for some
-					# reason, per spec: http://www.w3.org/TR/xml/#NT-AttValue
+					# This is allowed per spec: <http://www.w3.org/TR/xml/#NT-AttValue>
+					# But reportedly it breaks some XML tools?  FIXME: is this
+					# really true?
 					$map['<'] = '&lt;';
 				}
 				$ret .= " $key=$quote" . strtr( $value, $map ) . $quote;