From: Matthew Flaschen <mflaschen@wikimedia.org>
Date: Fri, 31 Jul 2015 01:27:07 +0000 (-0400)
Subject: array_shift returns null on empty array, not false
X-Git-Tag: 1.31.0-rc.0~10569^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/recherche.php?a=commitdiff_plain;h=16c81325edd2a0ed3f3c387079a12f70ab2b6619;p=lhc%2Fweb%2Fwiklou.git

array_shift returns null on empty array, not false

Change-Id: I690f9dd0de11ff60f9cba9f401c6e456e7ba8bd6
---

diff --git a/includes/objectcache/RedisBagOStuff.php b/includes/objectcache/RedisBagOStuff.php
index 7e506f0d7a..11dd660e0d 100644
--- a/includes/objectcache/RedisBagOStuff.php
+++ b/includes/objectcache/RedisBagOStuff.php
@@ -372,7 +372,7 @@ class RedisBagOStuff extends BagOStuff {
 			}
 		}
 
-		while ( ( $tag = array_shift( $candidates ) ) !== false ) {
+		while ( ( $tag = array_shift( $candidates ) ) !== null ) {
 			$server = $this->serverTagMap[$tag];
 			$conn = $this->redisPool->getConnection( $server );
 			if ( !$conn ) {