Log what job types were never inserted

I am seeing a constant stream of

	Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted. in
	/srv/mediawiki/php-1.26wmf6/includes/jobqueue/JobQueueGroup.php on line 419

In the production logfiles.  Log what type of jobs these are so we can figure out
how to fix them.

Change-Id: I7beca910d8c4b20aa20bdec4883e399fd94fbcfd

diff --git a/includes/jobqueue/JobQueueGroup.php b/includes/jobqueue/JobQueueGroup.php
index 3d2393e..5bd1cc9 100644 (file)
--- a/includes/jobqueue/JobQueueGroup.php
+++ b/includes/jobqueue/JobQueueGroup.php
@@ -416,7 +416,8 @@ class JobQueueGroup {
        function __destruct() {
                $n = count( $this->bufferedJobs );
                if ( $n > 0 ) {
-                       trigger_error( __METHOD__ . ": $n buffered job(s) never inserted." );
+                       $type = implode( ', ', array_unique( array_map( 'get_class', $this->bufferedJobs ) ) );
+                       trigger_error( __METHOD__ . ": $n buffered job(s) of type(s) $type never inserted." );
                }
        }
 }