From da82918a8e5f50f04988a2a3643b16904a9b2820 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Sun, 10 Feb 2008 09:59:19 +0000 Subject: [PATCH] * fix Strict Standards: Declaration of SpecialMostlinkedtemplates::preprocessResults() should be compatible with that of QueryPage::preprocessResults() in SpecialMostlinkedtemplates.php * remove EOL whitespace --- includes/SpecialMostlinkedtemplates.php | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/includes/SpecialMostlinkedtemplates.php b/includes/SpecialMostlinkedtemplates.php index e7e7afcceb..e68b0909a6 100644 --- a/includes/SpecialMostlinkedtemplates.php +++ b/includes/SpecialMostlinkedtemplates.php @@ -17,7 +17,7 @@ class SpecialMostlinkedtemplates extends QueryPage { public function getName() { return 'Mostlinkedtemplates'; } - + /** * Is this report expensive, i.e should it be cached? * @@ -26,7 +26,7 @@ class SpecialMostlinkedtemplates extends QueryPage { public function isExpensive() { return true; } - + /** * Is there a feed available? * @@ -44,7 +44,7 @@ class SpecialMostlinkedtemplates extends QueryPage { public function sortDescending() { return true; } - + /** * Generate SQL for the report * @@ -60,16 +60,16 @@ class SpecialMostlinkedtemplates extends QueryPage { COUNT(*) AS value FROM {$templatelinks} WHERE tl_namespace = " . NS_TEMPLATE . " - GROUP BY 1, 2, 3"; + GROUP BY 1, 2, 3"; } - + /** * Pre-cache page existence to speed up link generation * * @param Database $dbr Database connection * @param int $res Result pointer */ - public function preprocessResults( $dbr, $res ) { + public function preprocessResults( &$dbr, &$res ) { $batch = new LinkBatch(); while( $row = $dbr->fetchObject( $res ) ) { $title = Title::makeTitleSafe( $row->namespace, $row->title ); @@ -79,7 +79,7 @@ class SpecialMostlinkedtemplates extends QueryPage { if( $dbr->numRows( $res ) > 0 ) $dbr->dataSeek( $res, 0 ); } - + /** * Format a result row * @@ -99,7 +99,7 @@ class SpecialMostlinkedtemplates extends QueryPage { return "Invalid title in result set; {$tsafe}"; } } - + /** * Make a "what links here" link for a given title * @@ -115,7 +115,6 @@ class SpecialMostlinkedtemplates extends QueryPage { $wgLang->formatNum( $result->value ) ); return $skin->makeKnownLinkObj( $wlh, $label, 'target=' . $title->getPrefixedUrl() ); } - } /** @@ -128,4 +127,3 @@ function wfSpecialMostlinkedtemplates( $par = false ) { $mlt = new SpecialMostlinkedtemplates(); $mlt->doQuery( $offset, $limit ); } - -- 2.20.1