From d5b7177cf5698b11862274bbe573105ddd29577b Mon Sep 17 00:00:00 2001
From: Greg Sabino Mullane <greg@users.mediawiki.org>
Date: Fri, 4 Jul 2008 15:57:44 +0000
Subject: [PATCH] Properly handle the 'IGNORE' option passed to the insert
 funtion: rather than just turning off errors, do some savepoint trickery so
 we end at the same state as when we started, to emulate MySQL's
 INSERT...IGNORE. Bug 14708.

---
 RELEASE-NOTES                    |  1 +
 includes/db/DatabasePostgres.php | 23 ++++++++++++++++++++---
 2 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index b578d154c2..c5d7544ee6 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -412,6 +412,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   generates a log entry.
 * (bug 14088) Excessively long block expiry times are rejected as invalid,
   keeps the log page from being distorted.
+* (bug 14708) Emulate INSERT...IGNORE with standard SQL for Postgres backend.
 
 === API changes in 1.13 ===
 
diff --git a/includes/db/DatabasePostgres.php b/includes/db/DatabasePostgres.php
index a0d3d6962e..14714c6b0b 100644
--- a/includes/db/DatabasePostgres.php
+++ b/includes/db/DatabasePostgres.php
@@ -747,10 +747,16 @@ class DatabasePostgres extends Database {
 			$keys = array_keys( $args );
 		}
 
-		$ignore = in_array( 'IGNORE', $options ) ? 1 : 0;
-		if ( $ignore )
+		$ignore = in_array( 'IGNORE', $options ) ? 'mw' : '';
+		if ( $ignore ) {
+			$didbegin = 0;
+			if (! $this->mTrxLevel) {
+				$this->begin();
+				$didbegin = 1;
+			}
+			pg_query($this->mConn, "SAVEPOINT $ignore");
 			$olde = error_reporting( 0 );
-
+		}
 		$sql = "INSERT INTO $table (" . implode( ',', $keys ) . ') VALUES ';
 
 		if ( $multi ) {
@@ -785,6 +791,17 @@ class DatabasePostgres extends Database {
 
 		if ( $ignore ) {
 			$olde = error_reporting( $olde );
+			$bar = pg_last_error();
+			if ($bar !== FALSE) {
+				pg_query( $this->mConn, "ROLLBACK TO $ignore" );
+			}
+			else {
+				pg_query( $this->mConn, "RELEASE $ignore" );
+			}
+			if ($didbegin) {
+				$this->commit();
+			}
+			## IGNORE always returns true
 			return true;
 		}
 
-- 
2.20.1