From 45399a3b25f20140be319654bc8ca1b70e82c25a Mon Sep 17 00:00:00 2001 From: Aryeh Gregor Date: Mon, 14 Jan 2008 18:12:43 +0000 Subject: [PATCH] (bug 12614) Prevent logging of null change on Userrights . . . for real this time. --- RELEASE-NOTES | 2 +- includes/SpecialUserrights.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 0ee5e9cb63..a41b3c2bd4 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -301,7 +301,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * (bug 12489) Special:Userrights listed in restricted section again * (bug 12553) Fixed invalid XHTML in edit conflict screen * (bug 12505) Fixed section=0 with action=raw -* Do not log user rights change that didn't change anything +* (bug 12614) Do not log user rights change that didn't change anything * (bug 12584) Don't reset cl_timestamp when auto-updating sort key on move * (bug 12588) Fix selection in namespace selector on Special:Newpages * Use only default options when generating RSS and Atom syndication links. diff --git a/includes/SpecialUserrights.php b/includes/SpecialUserrights.php index 4b0a50a6b6..50899787e8 100644 --- a/includes/SpecialUserrights.php +++ b/includes/SpecialUserrights.php @@ -136,7 +136,7 @@ class UserrightsPage extends SpecialPage { wfRunHooks( 'UserRights', array( &$user, $addgroup, $removegroup ) ); } - if( $addgroup or $removegroup ) { + if( $newGroups != $oldGroups ) { $log = new LogPage( 'rights' ); global $wgRequest; -- 2.20.1