From: Tim Starling <tstarling@wikimedia.org>
Date: Tue, 23 Oct 2012 05:00:37 +0000 (+1100)
Subject: Fix SpecialPage::isRestricted()
X-Git-Tag: 1.31.0-rc.0~21907
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/?a=commitdiff_plain;h=ff76889d86b9fae3f1cd869af449927470bbb131;p=lhc%2Fweb%2Fwiklou.git

Fix SpecialPage::isRestricted()

Fix SpecialPage::isRestricted(), broken by I41edb091 (22dd67e) which
inverted the group permission check. Seems to only affect
Special:SpecialPages. Bug 41294.

Change-Id: I8685eaeb4a688cc8e205afdb1639c08e4a2bd3da
---

diff --git a/includes/SpecialPage.php b/includes/SpecialPage.php
index a72c1af566..9442869774 100644
--- a/includes/SpecialPage.php
+++ b/includes/SpecialPage.php
@@ -522,7 +522,7 @@ class SpecialPage {
 	 */
 	public function isRestricted() {
 		// DWIM: If all anons can do something, then it is not restricted
-		return $this->mRestriction != '' && User::groupHasPermission( '*', $this->mRestriction );
+		return $this->mRestriction != '' && !User::groupHasPermission( '*', $this->mRestriction );
 	}
 
 	/**