From: Kunal Mehta <legoktm@member.fsf.org>
Date: Mon, 11 Jun 2018 23:51:42 +0000 (-0700)
Subject: Turn ApiPrefixUniquenessTest into a structure test
X-Git-Tag: 1.34.0-rc.0~4384^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/?a=commitdiff_plain;h=72b4099727469532e56403fabd3d16e71f67e90b;p=lhc%2Fweb%2Fwiklou.git

Turn ApiPrefixUniquenessTest into a structure test

This way it gets run during extension test runs as well.

Temporarily add a hack allowing 'wbeu' duplicates until T196962 is fixed.

Change-Id: Ic89a22a2ff4525585de9e290a1d47d22cfaaac5e
---

diff --git a/tests/phpunit/includes/api/PrefixUniquenessTest.php b/tests/phpunit/includes/api/PrefixUniquenessTest.php
deleted file mode 100644
index d125a7d531..0000000000
--- a/tests/phpunit/includes/api/PrefixUniquenessTest.php
+++ /dev/null
@@ -1,30 +0,0 @@
-<?php
-
-/**
- * Checks that all API query modules, core and extensions, have unique prefixes.
- *
- * @group API
- */
-class PrefixUniquenessTest extends MediaWikiTestCase {
-
-	public function testPrefixes() {
-		$main = new ApiMain( new FauxRequest() );
-		$query = new ApiQuery( $main, 'foo', 'bar' );
-		$moduleManager = $query->getModuleManager();
-
-		$modules = $moduleManager->getNames();
-		$prefixes = [];
-
-		foreach ( $modules as $name ) {
-			$module = $moduleManager->getModule( $name );
-			$class = get_class( $module );
-
-			$prefix = $module->getModulePrefix();
-			if ( $prefix !== '' && isset( $prefixes[$prefix] ) ) {
-				$this->fail( "Module prefix '{$prefix}' is shared between {$class} and {$prefixes[$prefix]}" );
-			}
-			$prefixes[$module->getModulePrefix()] = $class;
-		}
-		$this->assertTrue( true ); // dummy call to make this test non-incomplete
-	}
-}
diff --git a/tests/phpunit/structure/ApiPrefixUniquenessTest.php b/tests/phpunit/structure/ApiPrefixUniquenessTest.php
new file mode 100644
index 0000000000..0920a64a5d
--- /dev/null
+++ b/tests/phpunit/structure/ApiPrefixUniquenessTest.php
@@ -0,0 +1,31 @@
+<?php
+
+/**
+ * Checks that all API query modules, core and extensions, have unique prefixes.
+ *
+ * @group API
+ * @coversNothing
+ */
+class ApiPrefixUniquenessTest extends MediaWikiTestCase {
+
+	public function testPrefixes() {
+		$main = new ApiMain( new FauxRequest() );
+		$query = new ApiQuery( $main, 'foo' );
+		$moduleManager = $query->getModuleManager();
+
+		$modules = $moduleManager->getNames();
+		$prefixes = [];
+
+		foreach ( $modules as $name ) {
+			$module = $moduleManager->getModule( $name );
+			$class = get_class( $module );
+
+			$prefix = $module->getModulePrefix();
+			if ( $prefix !== '' && isset( $prefixes[$prefix] ) /* HACK: T196962 */ && $prefix !== 'wbeu' ) {
+				$this->fail( "Module prefix '{$prefix}' is shared between {$class} and {$prefixes[$prefix]}" );
+			}
+			$prefixes[$module->getModulePrefix()] = $class;
+		}
+		$this->assertTrue( true ); // dummy call to make this test non-incomplete
+	}
+}