From: Timo Tijhof <krinklemail@gmail.com>
Date: Fri, 6 Mar 2015 01:06:00 +0000 (+0100)
Subject: mediawiki.test: Prevent "Error: expected" from going to the real console
X-Git-Tag: 1.31.0-rc.0~12170
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/?a=commitdiff_plain;h=264d80147bde63356325c74a1cca487a5a11b207;p=lhc%2Fweb%2Fwiklou.git

mediawiki.test: Prevent "Error: expected" from going to the real console

Keeps the build logs cleaner and less confusing.

Change-Id: Ibbbf5dd367cab798885df34b9dd73f84229d3c5e
---

diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
index 8a7470c674..4a5705a108 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
@@ -692,7 +692,11 @@
 		} );
 	} );
 
-	QUnit.test( 'mw.loader erroneous indirect dependency', 3, function ( assert ) {
+	QUnit.test( 'mw.loader erroneous indirect dependency', 5, function ( assert ) {
+		// Keep "Error: expected" out of build log
+		var log = this.sandbox.stub( window.console || {}, 'log' ),
+			error = this.sandbox.stub( window.console || {}, 'error' );
+
 		mw.loader.register( [
 			['test.module1', '0'],
 			['test.module2', '0', ['test.module1']],
@@ -704,6 +708,9 @@
 		assert.strictEqual( mw.loader.getState( 'test.module1' ), 'error', 'Expected "error" state for test.module1' );
 		assert.strictEqual( mw.loader.getState( 'test.module2' ), 'error', 'Expected "error" state for test.module2' );
 		assert.strictEqual( mw.loader.getState( 'test.module3' ), 'error', 'Expected "error" state for test.module3' );
+
+		assert.strictEqual( log.callCount, 1 );
+		assert.strictEqual( error.callCount, 1 );
 	} );
 
 	QUnit.test( 'mw.loader out-of-order implementation', 9, function ( assert ) {