From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Mon, 16 Feb 2009 18:06:04 +0000 (+0000)
Subject: Add gripe about FIFO and random row selection
X-Git-Tag: 1.31.0-rc.0~42869
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/?a=commitdiff_plain;h=2626ac372d3aa6aa5875e9244c834a581879b8c2;p=lhc%2Fweb%2Fwiklou.git

Add gripe about FIFO and random row selection
---

diff --git a/includes/JobQueue.php b/includes/JobQueue.php
index afa757d752..a753958fe7 100644
--- a/includes/JobQueue.php
+++ b/includes/JobQueue.php
@@ -126,6 +126,7 @@ abstract class Job {
 		if ( !$affected ) {
 			// Failed, someone else beat us to it
 			// Try getting a random row
+			// FIXME: FIFO???
 			$row = $dbw->selectRow( 'job', array( 'MIN(job_id) as minjob',
 				'MAX(job_id) as maxjob' ), '1=1', __METHOD__ );
 			if ( $row === false || is_null( $row->minjob ) || is_null( $row->maxjob ) ) {