From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Fri, 9 May 2014 18:04:35 +0000 (+0200)
Subject: ChangesListSpecialPage: Use Html instead of Xml in makeLegend()
X-Git-Tag: 1.31.0-rc.0~15822^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/operations/?a=commitdiff_plain;h=1aef68ca8c0192c7cadb3a185cc46e3f0f468b8d;p=lhc%2Fweb%2Fwiklou.git

ChangesListSpecialPage: Use Html instead of Xml in makeLegend()

We're generating HTML here, not XML.

Also changed a silly variable name.

Change-Id: I3295fd6a515d7172d4c233d4698e7b50df1a722c
---

diff --git a/includes/specialpage/ChangesListSpecialPage.php b/includes/specialpage/ChangesListSpecialPage.php
index fe70ba55bb..f7c95d1024 100644
--- a/includes/specialpage/ChangesListSpecialPage.php
+++ b/includes/specialpage/ChangesListSpecialPage.php
@@ -405,42 +405,42 @@ abstract class ChangesListSpecialPage extends SpecialPage {
 		global $wgRecentChangesFlags;
 		$user = $context->getUser();
 		# The legend showing what the letters and stuff mean
-		$legend = Xml::openElement( 'dl' ) . "\n";
+		$legend = Html::openElement( 'dl' ) . "\n";
 		# Iterates through them and gets the messages for both letter and tooltip
 		$legendItems = $wgRecentChangesFlags;
 		if ( !( $user->useRCPatrol() || $user->useNPPatrol() ) ) {
 			unset( $legendItems['unpatrolled'] );
 		}
-		foreach ( $legendItems as $key => $legendInfo ) { # generate items of the legend
-			$label = $legendInfo['title'];
-			$letter = $legendInfo['letter'];
-			$cssClass = isset( $legendInfo['class'] ) ? $legendInfo['class'] : $key;
+		foreach ( $legendItems as $key => $item ) { # generate items of the legend
+			$label = $item['title'];
+			$letter = $item['letter'];
+			$cssClass = isset( $item['class'] ) ? $item['class'] : $key;
 
-			$legend .= Xml::element( 'dt',
+			$legend .= Html::element( 'dt',
 				array( 'class' => $cssClass ), $context->msg( $letter )->text()
 			) . "\n";
 			if ( $key === 'newpage' ) {
-				$legend .= Xml::openElement( 'dd' );
+				$legend .= Html::openElement( 'dd' );
 				$legend .= $context->msg( $label )->escaped();
 				$legend .= ' ' . $context->msg( 'recentchanges-legend-newpage' )->parse();
-				$legend .= Xml::closeElement( 'dd' ) . "\n";
+				$legend .= Html::closeElement( 'dd' ) . "\n";
 			} else {
-				$legend .= Xml::element( 'dd', array(),
+				$legend .= Html::element( 'dd', array(),
 					$context->msg( $label )->text()
 				) . "\n";
 			}
 		}
 		# (+-123)
-		$legend .= Xml::tags( 'dt',
+		$legend .= Html::rawElement( 'dt',
 			array( 'class' => 'mw-plusminus-pos' ),
 			$context->msg( 'recentchanges-legend-plusminus' )->parse()
 		) . "\n";
-		$legend .= Xml::element(
+		$legend .= Html::element(
 			'dd',
 			array( 'class' => 'mw-changeslist-legend-plusminus' ),
 			$context->msg( 'recentchanges-label-plusminus' )->text()
 		) . "\n";
-		$legend .= Xml::closeElement( 'dl' ) . "\n";
+		$legend .= Html::closeElement( 'dl' ) . "\n";
 
 		# Collapsibility
 		$legend =