Merge "Added FIXME to default Database replace() implementation"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Sat, 18 Jul 2015 19:37:56 +0000 (19:37 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sat, 18 Jul 2015 19:37:56 +0000 (19:37 +0000)
includes/db/Database.php

index 2f1155d..04b3edd 100644 (file)
@@ -2873,6 +2873,7 @@ abstract class DatabaseBase implements IDatabase {
                        $rows = array( $rows );
                }
 
+               // @FXIME: this is not atomic, but a trx would break affectedRows()
                foreach ( $rows as $row ) {
                        # Delete rows which collide
                        if ( $uniqueIndexes ) {