Make $url parameter to Parser::getExternalLinkAttribs() required
authorKunal Mehta <legoktm@member.fsf.org>
Wed, 1 Jun 2016 04:25:18 +0000 (21:25 -0700)
committerKunal Mehta <legoktm@member.fsf.org>
Wed, 1 Jun 2016 04:25:18 +0000 (21:25 -0700)
All callers in Gerrit pass $url in.

Change-Id: I36246f6510db414dcc7023f8779796c060c3eba5

includes/parser/Parser.php

index 17098f7..66298b0 100644 (file)
@@ -1882,11 +1882,11 @@ class Parser {
         * (depending on configuration, namespace, and the URL's domain) and/or a
         * target attribute (depending on configuration).
         *
-        * @param string|bool $url Optional URL, to extract the domain from for rel =>
+        * @param string $url URL to extract the domain from for rel =>
         *   nofollow if appropriate
         * @return array Associative array of HTML attributes
         */
-       public function getExternalLinkAttribs( $url = false ) {
+       public function getExternalLinkAttribs( $url ) {
                $attribs = [];
                $rel = self::getExternalLinkRel( $url, $this->mTitle );