From 188f9548b811dde62d7050badb31e9be6459e2f6 Mon Sep 17 00:00:00 2001
From: Krinkle <krinkle@users.mediawiki.org>
Date: Sun, 8 Jan 2012 22:32:11 +0000
Subject: [PATCH] [HistoryAction] Clean up * Don't build $s as well as
 $this->buttons for re-use later in getEndBody(), simply use it in both cases.
 * Adding a css class for compareselectedversions button just like there is
 for the revisiondelete button

---
 includes/actions/HistoryAction.php | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/includes/actions/HistoryAction.php b/includes/actions/HistoryAction.php
index aa1ec45c70..21985721ab 100644
--- a/includes/actions/HistoryAction.php
+++ b/includes/actions/HistoryAction.php
@@ -409,20 +409,20 @@ class HistoryPager extends ReverseChronologicalPager {
 		$s .= Html::hidden( 'title', $this->getTitle()->getPrefixedDbKey() ) . "\n";
 		$s .= Html::hidden( 'action', 'historysubmit' ) . "\n";
 
-		$s .= '<div>' . $this->submitButton( $this->msg( 'compareselectedversions' )->text(),
-			array( 'class' => 'historysubmit' ) ) . "\n";
-
+		// Button container stored in $this->buttons for re-use in getEndBody()
 		$this->buttons = '<div>';
 		$this->buttons .= $this->submitButton( $this->msg( 'compareselectedversions' )->text(),
-			array( 'class' => 'historysubmit' )
+			array( 'class' => 'historysubmit mw-history-compareselectedversions-button' )
 				+ Linker::tooltipAndAccesskeyAttribs( 'compareselectedversions' )
 		) . "\n";
 
 		if ( $this->getUser()->isAllowed( 'deleterevision' ) ) {
-			$s .= $this->getRevisionButton( 'revisiondelete', 'showhideselectedversions' );
+			$this->buttons .= $this->getRevisionButton( 'revisiondelete', 'showhideselectedversions' );
 		}
 		$this->buttons .= '</div>';
-		$s .= '</div><ul id="pagehistory">' . "\n";
+
+		$s .= $this->buttons;
+		$s .= '<ul id="pagehistory">' . "\n";
 		return $s;
 	}
 
@@ -438,7 +438,6 @@ class HistoryPager extends ReverseChronologicalPager {
 			),
 			$this->msg( $msg )->text()
 		) . "\n";
-		$this->buttons .= $element;
 		return $element;
 	}
 
-- 
2.20.1