Demon [Thu, 22 Mar 2012 12:23:14 +0000 (12:23 +0000)]
Merge changes I40a10821,I9c0af860
* changes:
Code reformatting
Refactoring dumpTextPass's error handling
Christian Aistleitner [Thu, 22 Mar 2012 11:11:42 +0000 (12:11 +0100)]
Code reformatting
Change-Id: I40a108216045aad9496bbbf723de2f42b084d009
Hashar [Thu, 22 Mar 2012 11:01:00 +0000 (11:01 +0000)]
Merge "Added per-backend profiling calls."
Christian Aistleitner [Thu, 22 Mar 2012 09:10:31 +0000 (10:10 +0100)]
Refactoring dumpTextPass's error handling
Change-Id: I9c0af860ca97489222b3cec071ed721ce72ad9e5
Demon [Thu, 22 Mar 2012 09:25:51 +0000 (09:25 +0000)]
Merge "Bug 35162 - Change in Database api break extension MSSQLBackCompat"
Aaron Schulz [Thu, 22 Mar 2012 00:23:42 +0000 (00:23 +0000)]
Merge "Fix newline in the message per CR Change method visibility to private"
Aaron Schulz [Thu, 22 Mar 2012 00:20:21 +0000 (00:20 +0000)]
Merge "Trim trailing whitespace"
saper [Wed, 21 Mar 2012 23:57:16 +0000 (00:57 +0100)]
Fix newline in the message per CR
Change method visibility to private
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113888#c32433
Change-Id: I8ea562cb5346de6823b3c0f0259d438bbefa8bac
Aaron Schulz [Wed, 21 Mar 2012 23:54:22 +0000 (16:54 -0700)]
Added per-backend profiling calls.
Change-Id: I380d06838649ab77f905cb6fed46b8068dbdcb9f
Amir E. Aharoni [Wed, 21 Mar 2012 23:07:06 +0000 (01:07 +0200)]
A little fix in whitespace and comment spelling.
Change-Id: I23887de1a5ee454037b6346c767e302f2e6f02f7
Sam Reed [Sun, 11 Mar 2012 23:40:33 +0000 (23:40 +0000)]
Bug 35162 - Change in Database api break extension MSSQLBackCompat
$canonicalDBTypes is probably superfluous information, but doesn't harm as a shortcut
Ping r108051
(imported from SVN)
Change-Id: I09ecf56d984405506f654919a822a939e5a9b1ee
Sam Reed [Sat, 17 Mar 2012 22:52:54 +0000 (22:52 +0000)]
Trim trailing whitespace
Add/improve documentation
Explicitly define a few variables
Change-Id: If0017770a0a47f8f6be178b5bde8ae6691f74b6a
Demon [Wed, 21 Mar 2012 21:09:36 +0000 (17:09 -0400)]
Adding .gitreview -- first official commit to mediawiki core in git \o/
Change-Id: Ica46ab303c89679ea8575f75f51830f36bf972d3
Tim Starling [Wed, 21 Mar 2012 10:27:34 +0000 (10:27 +0000)]
* Removed the $method parameters from MWCryptRand. Apparently Dantman didn't know about our awesome debug traceback functions like wfGetAllCallers(). The weird optional-middle-parameter calling convention thankfully disappears as a consequence.
* Reduced the amount of debug log noise slightly, removing a few redundant messages.
Santhosh Thottingal [Wed, 21 Mar 2012 05:49:03 +0000 (05:49 +0000)]
Fix Bug 13896: Rendering of devanagari numbers in automatic '#' number lists
Add -moz-devanagari as list type for mr and hi language ordered lists.
Roan Kattouw [Wed, 21 Mar 2012 00:16:50 +0000 (00:16 +0000)]
Revert r107309, r113601, r113704, r113742, r113792, r113838, r113859, r113893, r113894, r113952, r114047, r114252, r114256, r114257. This reverts the remaining 'new' revisions in core.
All of these revisions are tagged with 'gerritmigration' and will be resubmitted into Gerrit after the Gerrit switchover. See also http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059124.html
Roan Kattouw [Tue, 20 Mar 2012 23:03:59 +0000 (23:03 +0000)]
Revert r114067, r114071, r114075, r114079, r114081, r114082, r114084, r114086, r114088, r114089, r114101, r114118, r114137, r114147, r114164, r114172, r114175, r114180, r114208, r114209, r114215, r114219, r114226, r114321, r114322.
This reverts the SpecialCachedPage and formatDuration sagas, with some collateral damage here and there. All of these revisions are tagged with 'gerritmigration' and will be resubmitted into Gerrit after the Gerrit switchover. See also http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059124.html
Daniel Friesen [Tue, 20 Mar 2012 22:58:34 +0000 (22:58 +0000)]
Security paranoia, reject requests to router.php that aren't from the cli-server sapi.
Jeroen De Dauw [Tue, 20 Mar 2012 22:48:28 +0000 (22:48 +0000)]
added some tests using the intervals param
Jeroen De Dauw [Tue, 20 Mar 2012 22:47:50 +0000 (22:47 +0000)]
handle cases where an empty array is provided by using this as default, also correctly handle cases where the smallest unit is not the second and the result is 0 smallestunit
Alexandre Emsenhuber [Tue, 20 Mar 2012 21:34:50 +0000 (21:34 +0000)]
* Use local context to get messages
* Use Language::userTimeAndDate() instead of Language::timeanddate() to display the date with user preferences
* Set the form's action to $wgScript instead of direct link to the page since it makes a GET request (and the title would be displayed twice with pretty URLs since there's already a <input name="title" .../>
Sam Reed [Tue, 20 Mar 2012 14:21:27 +0000 (14:21 +0000)]
Followup r114270 (essentially reverts it), and r114233, use class member variables as they are already defined
Sam Reed [Tue, 20 Mar 2012 14:16:46 +0000 (14:16 +0000)]
Followup r114233, define the method static variables to be used
Christian Aistleitner [Tue, 20 Mar 2012 12:00:18 +0000 (12:00 +0000)]
Follow-up to r114256: Removing final assert
Christian Aistleitner [Tue, 20 Mar 2012 11:53:35 +0000 (11:53 +0000)]
Follow up to r114252: Removing asserts
Christian Aistleitner [Tue, 20 Mar 2012 11:11:53 +0000 (11:11 +0000)]
Refactoring dumpTextPass's error handling
Alexandre Emsenhuber [Tue, 20 Mar 2012 10:07:51 +0000 (10:07 +0000)]
* (bug 34735) Updated compressOld.php documentation to mention the different usages of -s and -n parameters depending on compression type
Based on patch by christian@quelltextlich.at - http://bug-attachment.wikimedia.org/attachment.cgi?id=10105
Tim Starling [Tue, 20 Mar 2012 06:19:02 +0000 (06:19 +0000)]
(bug 35316) On autocreate, use $this as the "doer" in the newuser log entry, since unlike User::addNewUserLogEntry(), there is no way the action could have been triggered by a different user. Usually $wgUser is set correctly, but there's no need to rely on it here.
Daniel Friesen [Tue, 20 Mar 2012 05:17:40 +0000 (05:17 +0000)]
Commit the cryptrand project worked on in git:
- MWCryptRand: A new api for generating cryptographic randomness for security tokens. Uses whatever cryptographic source is available and if not falls back to using random state and clock drift.
- wfRandomString - A simple non-cryptographic pesudo-random string generation function to replace wfGenerateToken which was written pretending to be secure when it's really not.
- Core updates to use MWCryptRand in various places:
-- user_token generation (to do this we stop generating user_token implicitly and only generate it when needed to avoid depleting the system's entropy pool by reading random data we'll never use)
-- email confirmation token generation
-- password salt generation
-- temporary password generation
-- Generation of the automatic watchlist token
-- login and create user tokens
-- session ids when php's entropy sources are not set
-- the installer when generating wgSecretKey and the upgrade key
Tim Starling [Tue, 20 Mar 2012 04:52:53 +0000 (04:52 +0000)]
Better bug reference for r114231.
Tim Starling [Tue, 20 Mar 2012 04:39:09 +0000 (04:39 +0000)]
Fixed a few "strip tag exposed" bugs.
* Introduced Parser::killMarkers() based on the concept from StringFunctions. Used it in cases where markerStripCallback() doesn't make sense semantically, namely grammar, padleft, padright and anchorencode. Used markerStripCallback() in other cases.
* Changed headline unstrip order as suggested by P.Copp on bug 18295
* In CPF::lc() and CPF::uc(), removed the is_callable(). This was a temporary testing hack committed by me in r30109, which allowed me to do differential testing against a copy of the parser from before that revision.
Aaron Schulz [Tue, 20 Mar 2012 00:57:18 +0000 (00:57 +0000)]
[FileRepo] Added long-since missing FOR UPDATE to LocalFile::lock(). This might help with the weird mismatched metadata for files with two uploads at the same time that I keep seeing in the DB.
Jeroen De Dauw [Tue, 20 Mar 2012 00:31:10 +0000 (00:31 +0000)]
added enabled field so you can disable the cache thing if you need to before its been initialized and fixed copypaste error
Tim Starling [Tue, 20 Mar 2012 00:28:30 +0000 (00:28 +0000)]
Fixed attempt to write to the wiki's upload directory during parser tests instead of /tmp, this is not allowed. I'm not sure what setupGlobals() is meant to do nowadays, that part is untested. It seems to be duplicated in ParserTest::__construct().
Jeroen De Dauw [Tue, 20 Mar 2012 00:04:36 +0000 (00:04 +0000)]
follow up to r114215, fix some fails and added CachedAction implementing the same stuff as SpecialCachedPage
Christian Aistleitner [Mon, 19 Mar 2012 23:36:48 +0000 (23:36 +0000)]
Follow up to r114126: Being more conservative for HipHop compiler
Jeroen De Dauw [Mon, 19 Mar 2012 23:33:25 +0000 (23:33 +0000)]
split general cache helper functionality to its own class, so we can also easily use it in stuff that does not derive from SpecialPage, such as Action
Jeroen De Dauw [Mon, 19 Mar 2012 22:49:00 +0000 (22:49 +0000)]
fix subpage linking
Jeroen De Dauw [Mon, 19 Mar 2012 22:37:05 +0000 (22:37 +0000)]
only init if not already done so
Sam Reed [Mon, 19 Mar 2012 21:40:39 +0000 (21:40 +0000)]
More occurrence typos
Raimond Spekking [Mon, 19 Mar 2012 21:21:48 +0000 (21:21 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Mon, 19 Mar 2012 20:52:59 +0000 (20:52 +0000)]
Make the first line of debug log more consitent between CLI and web call by putting the method and the URL directly on the first line
Jeroen De Dauw [Mon, 19 Mar 2012 20:51:36 +0000 (20:51 +0000)]
make more generic: do not assume we want to add html to the output. Also get rid of action=purge from key args
Jeroen De Dauw [Mon, 19 Mar 2012 20:05:11 +0000 (20:05 +0000)]
fix for r114164
Jeroen De Dauw [Mon, 19 Mar 2012 19:24:04 +0000 (19:24 +0000)]
update docs
Jeroen De Dauw [Mon, 19 Mar 2012 18:40:54 +0000 (18:40 +0000)]
some refactoring to allow for nicer usage in deriving classes
Aaron Schulz [Mon, 19 Mar 2012 18:28:47 +0000 (18:28 +0000)]
Reverted r113688, r113691 per CR and filed #61440 upstream.
Alexandre Emsenhuber [Mon, 19 Mar 2012 17:09:23 +0000 (17:09 +0000)]
* Use local context to get message
* Use $this->getTitle() instead of SpecialPage::getTitleFor( 'Preferences' )
Jeroen De Dauw [Mon, 19 Mar 2012 16:14:05 +0000 (16:14 +0000)]
Follow up to r114081; address krinkles comment
Sam Reed [Mon, 19 Mar 2012 15:25:22 +0000 (15:25 +0000)]
Fix switch fall through
Remove code for getting svn rev from SVN less than 1.4 - Ubuntu 8.04 LTS has 1.4.6 so should be pretty safe
Krinkle [Mon, 19 Mar 2012 14:34:27 +0000 (14:34 +0000)]
[Html::namespaceSelector clean up] fix broken html from r114131
Jeroen De Dauw [Mon, 19 Mar 2012 13:47:58 +0000 (13:47 +0000)]
Follow up to r114081;
Alexandre Emsenhuber [Mon, 19 Mar 2012 12:44:36 +0000 (12:44 +0000)]
Removed XmlTest::testNamespaceSelector(); it just breaks when $wgDevelopmentWarnings is set to true due to the fact that Xml::namespaceSelector() calls wfDeprecated().
Alexandre Emsenhuber [Mon, 19 Mar 2012 12:30:52 +0000 (12:30 +0000)]
Change calls from Xml::namespaceSelector() to Html::namespaceSelector() since the former now throws deprecation warnings...
Christian Aistleitner [Mon, 19 Mar 2012 11:14:43 +0000 (11:14 +0000)]
Sanitizing already existing use of PHP's assert
Krinkle [Mon, 19 Mar 2012 01:06:19 +0000 (01:06 +0000)]
follow-up r114116: move release-notes
Sam Reed [Sun, 18 Mar 2012 23:22:20 +0000 (23:22 +0000)]
Bug 35309 - formatDuration message missing/inconsistent
Patch by Dan Collins
Alexandre Emsenhuber [Sun, 18 Mar 2012 22:19:00 +0000 (22:19 +0000)]
* (bug 35303) Make proxy and DNS blacklist blocking work again
Krinkle [Sun, 18 Mar 2012 22:13:55 +0000 (22:13 +0000)]
[jquery.byteLimit] Set vars in return this.each loop
* Set vars in return this.each loop. This is the defacto standard plugin structure
but somehow it slipped through this one (it's a 2 line wrapper, easy to miss).
* Added unit test (which failed before this commit)
* Fixes:
-- (bug 35294) jquery.byteLimit shouldn't set element specific variables outside the "return this.each" loop.
Krinkle [Sun, 18 Mar 2012 21:40:46 +0000 (21:40 +0000)]
[jquery.byteLimit.test] clean up
* js conventions
* whitespace indention
Raimond Spekking [Sun, 18 Mar 2012 20:13:19 +0000 (20:13 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Sun, 18 Mar 2012 20:10:47 +0000 (20:10 +0000)]
Disable callgraphs for the time being
Per Yuvi, most people don't need them, and are a PITA on a slow connection
I'd be happy to re-enable them if we can get them on hyperlinks or subpages or some such
{{BeBold}}
Jeroen De Dauw [Sun, 18 Mar 2012 16:27:37 +0000 (16:27 +0000)]
follow up to r114081: qqq, and to r114082: match rename
Jeroen De Dauw [Sat, 17 Mar 2012 23:26:37 +0000 (23:26 +0000)]
follow up to r114084, add tests for stuff w/ multiple units
Sam Reed [Sat, 17 Mar 2012 22:52:54 +0000 (22:52 +0000)]
Trim trailing whitespace
Add/improve documentation
Explicitly define a few variables
Sam Reed [Sat, 17 Mar 2012 22:47:02 +0000 (22:47 +0000)]
Noralise a few of the magic numbers used in r114084
Sam Reed [Sat, 17 Mar 2012 22:39:38 +0000 (22:39 +0000)]
Unit tests for r114067
Sam Reed [Sat, 17 Mar 2012 22:26:26 +0000 (22:26 +0000)]
Followup r114067 rename to formatDuration to match other methods
Jeroen De Dauw [Sat, 17 Mar 2012 22:26:02 +0000 (22:26 +0000)]
adding special page with scaffolding for caching chunks of HTML
Sam Reed [Sat, 17 Mar 2012 22:14:44 +0000 (22:14 +0000)]
Followup r114067
Add centuries because the messages were already there but not used
Add decade and millennia for the luls/completeness
Jeroen De Dauw [Sat, 17 Mar 2012 21:47:17 +0000 (21:47 +0000)]
follow up to r114067, use correct language
Siebrand Mazeland [Sat, 17 Mar 2012 21:19:31 +0000 (21:19 +0000)]
Follow-up r113939: Add divs to addWikiText().
Jeroen De Dauw [Sat, 17 Mar 2012 21:13:01 +0000 (21:13 +0000)]
Follow up to r114067;
Jeroen De Dauw [Sat, 17 Mar 2012 20:58:46 +0000 (20:58 +0000)]
adding a duration function to language that converts seconds to text
Raimond Spekking [Sat, 17 Mar 2012 20:51:46 +0000 (20:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Thomas Gries [Sat, 17 Mar 2012 08:22:58 +0000 (08:22 +0000)]
follow up r113862 . changed public function name extensionTableExists to tableExists
Benny Situ [Sat, 17 Mar 2012 02:23:06 +0000 (02:23 +0000)]
fix for bug33214 - catch all exceptions in api execute and provides necessary parameters required by the custom printer
Raimond Spekking [Fri, 16 Mar 2012 20:39:04 +0000 (20:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Ryan Kaldari [Fri, 16 Mar 2012 14:44:46 +0000 (14:44 +0000)]
partial fix for bug 35057 - backporting a patch from jQuery 1.7.2pre
Siebrand Mazeland [Fri, 16 Mar 2012 04:38:00 +0000 (04:38 +0000)]
Remove incorrect "the" in 'filereadonlyerror'.
Make use of reasons more consistent in a few messages.
Sam Reed [Fri, 16 Mar 2012 02:02:41 +0000 (02:02 +0000)]
Make UsageException extend MWException
Tim Starling [Fri, 16 Mar 2012 00:29:26 +0000 (00:29 +0000)]
In the $clearState=true case, remove strip marker prefixes from the Parser::parse() input. It's only possible for strip markers to be present in this case if the caller manages to guess the output of Parser::getRandomString() in advance. Even if that is possible, it's not recommended as a robust calling procedure.
Also cleaned up some old commented-out code in this area.
Jeroen De Dauw [Thu, 15 Mar 2012 22:40:27 +0000 (22:40 +0000)]
docs++
Raimond Spekking [Thu, 15 Mar 2012 20:51:16 +0000 (20:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Thu, 15 Mar 2012 20:37:58 +0000 (20:37 +0000)]
[FileRepo] Tweaked transformErrorOutput() to allow more useful error output (like backend errors) for problems moving thumbnails into storage.
Aaron Schulz [Thu, 15 Mar 2012 17:50:55 +0000 (17:50 +0000)]
* r113886: use <div> instead of span to wrap element that has p tags.
* Also fixed an older instance of the same problem.
Sam Reed [Thu, 15 Mar 2012 17:14:28 +0000 (17:14 +0000)]
Move RELEASE-NOTES after merging r111647 into 1.19 in r113933
Max Semenik [Thu, 15 Mar 2012 15:38:11 +0000 (15:38 +0000)]
Follow-up r113922: tests
Max Semenik [Thu, 15 Mar 2012 15:21:46 +0000 (15:21 +0000)]
Bug 35051 - [Regression] If heading has a trailing space after == then its name is not preloaded into edit summary on section edit. Regression from r105380.
Krinkle [Thu, 15 Mar 2012 06:44:25 +0000 (06:44 +0000)]
[jquery.client] clean up
* Move translate() out of the if-block, no need to re-define
* `else` after return in `if`
* update js coding style
* remove bogus '=' in comment
* line-wrapping of long arrays
Krinkle [Thu, 15 Mar 2012 06:04:20 +0000 (06:04 +0000)]
[mediawiki.action.watch] clean up
* Fix implied global variable 'i' in mwUriGetAction()
* Indention nearly everything an extra level (svn di -x-uw)
* other minor js coding style
Krinkle [Thu, 15 Mar 2012 05:54:58 +0000 (05:54 +0000)]
[mediawiki.action.watch] Move re-used logic into local function
* Follows-up r112440, r107969, r107350
Aaron Schulz [Thu, 15 Mar 2012 04:34:22 +0000 (04:34 +0000)]
Fixed 'Illegal string offset 'LIMIT' in <b>C:\wamp\www\MediaWiki\includes\db\Database.php</b> on line <b>1462</b>'
Marcin Cieślak [Thu, 15 Mar 2012 02:00:16 +0000 (02:00 +0000)]
Followup-To: r113888 Remove extra wfDebug()
Marcin Cieślak [Thu, 15 Mar 2012 01:52:38 +0000 (01:52 +0000)]
Unbreak maintenance/deleteDefaultMessages.php for PostgreSQL
deleteDefaultMessages.php was failing during upgrade
from MediaWiki 1.7.3 with a databaser error.
A stub user:
$user = User::newFromName( 'MediaWiki default' );
has user ID 0, so that $user->isAnon() is true.
Unfortunately, ManualLogEntry::publish() from r96441
tries to insert $user->getName() ("MediaWiki default")
into rc_ip.
PostgreSQL won't allow this, because rc_ip is of
Postgres-specific CIDR type.
Traceback:
Checking existence of old default messages...
...deleting old default messages (this may take a long time!)...A database query syntax error has occurred.
The last attempted database query was:
"INSERT INTO "recentchanges" (rc_timestamp,rc_cur_time,rc_namespace,rc_title,rc_type,rc_minor,rc_user,rc_user_text,rc_comment,rc_this_oldid,rc_last_oldid,rc_bot,rc_moved_to_ns,rc_moved_to_title,rc_ip,rc_patrolled,rc_new,rc_old_len,rc_new_len,rc_deleted,rc_logid,rc_log_type,rc_log_action,rc_params,rc_id) VALUES ('2012-03-14 21:51:05 GMT','2012-03-14 21:51:05 GMT','8','1movedto2','3','0','0','MediaWiki default','No longer required','0','0',1,'0','','MediaWiki default','1','0',NULL,NULL,'0','1','delete','delete','a:0:{}','1')"
from within function "RecentChange::save".
MySQL returned error "1: ERROR: invalid input syntax for type cidr: "MediaWiki default"
LINE 1: ...ki default','No longer required','0','0',1,'0','','MediaWiki...
^"
Backtrace:
#0 /usr/home/saper/public_html/pg/w/includes/db/DatabasePostgres.php(332): DatabaseBase->reportQueryError('ERROR: invalid...', 1, 'INSERT INTO "re...', 'RecentChange::s...', '')
#1 /usr/home/saper/public_html/pg/w/includes/db/Database.php(904): DatabasePostgres->reportQueryError('ERROR: invalid...', 1, 'INSERT INTO "re...', 'RecentChange::s...', '')
#2 /usr/home/saper/public_html/pg/w/includes/db/DatabasePostgres.php(604): DatabaseBase->query('INSERT INTO "re...', 'RecentChange::s...', '')
#3 /usr/home/saper/public_html/pg/w/includes/RecentChange.php(199): DatabasePostgres->insert('recentchanges', Array, 'RecentChange::s...')
#4 /usr/home/saper/public_html/pg/w/includes/logging/LogEntry.php(479): RecentChange->save('pleasedontudp')
#5 /usr/home/saper/public_html/pg/w/includes/WikiPage.php(2042): ManualLogEntry->publish('1')
#6 /usr/home/saper/public_html/pg/w/includes/WikiPage.php(1937): WikiPage->doDeleteArticleReal('No longer requi...', false, 0, false, '', Object(User))
#7 /usr/home/saper/public_html/pg/w/maintenance/deleteDefaultMessages.php(73): WikiPage->doDeleteArticle('No longer requi...', false, 0, false, '', Object(User))
#8 /usr/home/saper/public_html/pg/w/maintenance/update.php(128): DeleteDefaultMessages->execute()
#9 /usr/home/saper/public_html/pg/w/maintenance/doMaintenance.php(105): UpdateMediaWiki->execute()
#10 /usr/home/saper/public_html/pg/w/maintenance/update.php(151): require_once('/usr/home/saper...')
#11 {main}
Aaron Schulz [Thu, 15 Mar 2012 01:42:34 +0000 (01:42 +0000)]
Add error css to errors like the other file operation pages and actions
Thomas Gries [Wed, 14 Mar 2012 21:53:30 +0000 (21:53 +0000)]
follow up r113836 typo correction in function header dropExtensionTable
Thomas Gries [Wed, 14 Mar 2012 21:41:37 +0000 (21:41 +0000)]
follow up r113836 added public function extensionTableExists.
Aaron Schulz [Wed, 14 Mar 2012 21:30:26 +0000 (21:30 +0000)]
[FileRepo]
* Added getReadOnlyReason() function to FileRepo to check read-only status. Added such checks to the File object functions that mutate files in storage. This should make read-only mode more tolerable (which is needed at least briefly when switching backends).
* Added lock()/unlock() calls to File restore() function.
* Use proper isOK() accessor for Status objects.
Roan Kattouw [Wed, 14 Mar 2012 21:10:28 +0000 (21:10 +0000)]
Fix encoding issue in r113197