Huji [Fri, 29 Aug 2008 18:40:53 +0000 (18:40 +0000)]
Localisation updates: Adding/updating Persian translations
Siebrand Mazeland [Fri, 29 Aug 2008 13:46:06 +0000 (13:46 +0000)]
Fix breakage of Live preview (patch by dantman himself)
Rotem Liss [Fri, 29 Aug 2008 13:40:47 +0000 (13:40 +0000)]
Fixing HTML escaping.
Rotem Liss [Fri, 29 Aug 2008 13:17:12 +0000 (13:17 +0000)]
* Fixing a wrong count of succeeding file undeletions when private files are undeleted: private files are not moved, and thus are not counted by storeBatch and should be added to the success count manually. This showed a bougs error when only private files were undeleted.
* Removing an outdated note in Special:Undelete: Restrictions on file revisions do not seem to be lost upon restoration.
Rotem Liss [Fri, 29 Aug 2008 12:28:26 +0000 (12:28 +0000)]
Respect file restrictions in the file history list. This is done by adding oi_deleted to the list of selected fields in OldLocalFile.
Rotem Liss [Fri, 29 Aug 2008 12:15:17 +0000 (12:15 +0000)]
+1 credit.
Rotem Liss [Fri, 29 Aug 2008 12:11:45 +0000 (12:11 +0000)]
Fixing comment.
Rotem Liss [Fri, 29 Aug 2008 12:01:54 +0000 (12:01 +0000)]
Adding some recent contributors to core translation to the list of translators. This should be completed by a list of BetaWiki translators.
Rotem Liss [Fri, 29 Aug 2008 11:55:55 +0000 (11:55 +0000)]
Fixing release notes item.
Rotem Liss [Fri, 29 Aug 2008 11:54:34 +0000 (11:54 +0000)]
Show thumbnails in the file history list. The dimensions are the same as in the default image gallery. Patch by User:Agbad, rewritten by me.
Meno25 [Fri, 29 Aug 2008 11:52:37 +0000 (11:52 +0000)]
Update file
Rotem Liss [Fri, 29 Aug 2008 10:25:24 +0000 (10:25 +0000)]
Fixing a fatal error on upload page:
Fatal error: Call to a member function isAllowed() on a non-object in /home/rotemliss/Server/wiki/source/trunk/phase3/includes/specials/SpecialUpload.php on line 125
The old code (introduced in r40190) used a $this->mUpload object, which does not exist on GET requests to Special:Upload. The new code uses direct User::isAllowed check in such cases.
Tim Starling [Fri, 29 Aug 2008 08:40:13 +0000 (08:40 +0000)]
* Generalised OutputPage::checkLastModified() to allow it to easily handle more than three types of modified timestamp. Added OutputPageCheckLastModified hook.
* Flattened out the structure of that function with early returns, to avoid ugly deep nesting.
Tim Starling [Fri, 29 Aug 2008 08:35:00 +0000 (08:35 +0000)]
* Fixed intermittent deadlock errors involving objectcache table queries. Use a separate database connection for the objectcache table to avoid long-lasting locks on that table.
Raimond Spekking [Fri, 29 Aug 2008 07:43:12 +0000 (07:43 +0000)]
Move information about watched pages and enotif into the fieldset too.
It looks much smarter now, especially on wikis with enotif enabled.
Aaron Schulz [Fri, 29 Aug 2008 05:19:05 +0000 (05:19 +0000)]
* Fix issue with "next" link going to the same place when date given (bug 15364)
* Remove some cruft in ContribsPager
Shinjiman [Fri, 29 Aug 2008 02:35:55 +0000 (02:35 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese
Aryeh Gregor [Thu, 28 Aug 2008 23:12:57 +0000 (23:12 +0000)]
(bug 15351) Fix fatal error for invalid section fragments in autocomments
. . . probably. Actually I can't reproduce the problem, so I can't be sure if this fixes it. But it should. I'm not at all sure if this is a real fix or more of a workaround. One code path (!$local) normalizes the fragment and rejects it as invalid, while the other code path ($local) sets the fragment unquestioningly and doesn't validate it. I don't know which behavior is correct.
Chad Horohoe [Thu, 28 Aug 2008 21:36:39 +0000 (21:36 +0000)]
Remove second declaration of EditPage::showPreview().
Bryan Tong Minh [Thu, 28 Aug 2008 21:34:43 +0000 (21:34 +0000)]
Properly check permissions.
Siebrand Mazeland [Thu, 28 Aug 2008 21:25:24 +0000 (21:25 +0000)]
Localisation updates for core messages from Betawiki (2008-08-28 23:03 CEST)
Chad Horohoe [Thu, 28 Aug 2008 21:24:10 +0000 (21:24 +0000)]
Bump $wgStyleVersion for r40184
Bryan Tong Minh [Thu, 28 Aug 2008 21:20:08 +0000 (21:20 +0000)]
Make UploadFromBase::getTitle more logical by returning either a title or null
Daniel Friesen [Thu, 28 Aug 2008 21:16:46 +0000 (21:16 +0000)]
Replace the <p><br /></p> inserted between the toolbar and the preview area with a ontop class. In shared.css we give this a bottom margin of 1em to add the space between the toolbar and preview.
As a bonus, because display: none; is now used when the preview area is not used, ajax/live previews actually get the spacing instead of it not showing up.
preview.js has also been tweaked to remove the display: none; when previewing.
Bryan Tong Minh [Thu, 28 Aug 2008 20:25:53 +0000 (20:25 +0000)]
wfReadOnly now checked in ApiMain::requestWriteMode
Roan Kattouw [Thu, 28 Aug 2008 20:20:52 +0000 (20:20 +0000)]
(bug 15358) Article::doEdit() ignores $user when inserting a new revision
Bryan Tong Minh [Thu, 28 Aug 2008 20:15:32 +0000 (20:15 +0000)]
Use static methods to check whether upload is enabled
Rotem Liss [Thu, 28 Aug 2008 18:18:24 +0000 (18:18 +0000)]
Localization update.
Meno25 [Thu, 28 Aug 2008 17:52:36 +0000 (17:52 +0000)]
Full update for file
Raimond Spekking [Thu, 28 Aug 2008 16:57:47 +0000 (16:57 +0000)]
fix typo, format section
Antoine Musso [Thu, 28 Aug 2008 16:31:54 +0000 (16:31 +0000)]
Implements #11884 : Now support Flash EXIF attribute
Roan Kattouw [Thu, 28 Aug 2008 16:27:18 +0000 (16:27 +0000)]
Credits for previous commit; patch was by Jeremy Baron
Roan Kattouw [Thu, 28 Aug 2008 16:26:27 +0000 (16:26 +0000)]
(bug 15348) prop=categories returns timestamps that aren't in ISO 8601 format
Antoine Musso [Thu, 28 Aug 2008 16:22:10 +0000 (16:22 +0000)]
wfDebugMem() to report memory usage
Roan Kattouw [Thu, 28 Aug 2008 14:19:01 +0000 (14:19 +0000)]
Improve FakeTitle implementation:
* Make FakeTitle a subclass of Title so functions with a type hint like Parser::parse() accept FakeTitles too
* Remove two static functions from the FakeTitle class
Greg Sabino Mullane [Thu, 28 Aug 2008 14:18:13 +0000 (14:18 +0000)]
Once we reset, no need to keep looping.
Rotem Liss [Thu, 28 Aug 2008 13:49:14 +0000 (13:49 +0000)]
Localization update.
Raimond Spekking [Thu, 28 Aug 2008 11:55:43 +0000 (11:55 +0000)]
Modernize the email user form to our actual standards:
* Add fieldset
* RTL compatability
* CSS classes/IDs
Meno25 [Thu, 28 Aug 2008 10:01:50 +0000 (10:01 +0000)]
Update files
Rotem Liss [Thu, 28 Aug 2008 09:40:07 +0000 (09:40 +0000)]
Localization update.
Rotem Liss [Thu, 28 Aug 2008 09:38:40 +0000 (09:38 +0000)]
Fixing 'recentchanges-legend' message text, now compatible to 'watchlist-options'.
Raimond Spekking [Thu, 28 Aug 2008 09:01:47 +0000 (09:01 +0000)]
Add colons to the form labels for consistency with all other forms.
Rotem Liss [Thu, 28 Aug 2008 08:48:34 +0000 (08:48 +0000)]
Localization update.
Alexandre Emsenhuber [Thu, 28 Aug 2008 08:08:31 +0000 (08:08 +0000)]
Replace arguments before replacing variables in {{int:...}} parser function, for compatibility with messages that require it
Raimond Spekking [Thu, 28 Aug 2008 07:14:33 +0000 (07:14 +0000)]
* (bug 15172) 'Go' button of Special:Recentchanges now on the same line as the last input element (like Special:Watchlist too)
Tim Starling [Thu, 28 Aug 2008 05:22:17 +0000 (05:22 +0000)]
* Fix bug 15344. Was caused by the overwrite of $entry, assigned by reference to the last link and then overwritten in later code.
* Split doVariants() out from replaceInternal(), big functions are prone to variable reuse bugs
Chad Horohoe [Thu, 28 Aug 2008 01:09:40 +0000 (01:09 +0000)]
Add some caching to the group counts.
Roan Kattouw [Thu, 28 Aug 2008 00:04:57 +0000 (00:04 +0000)]
(bug 13471) Added NUMBERINGROUP magic word. Patch by Soxred93
Alexandre Emsenhuber [Wed, 27 Aug 2008 22:23:04 +0000 (22:23 +0000)]
(bug 15342) "Invert" checkbox now works correctly when selecting main namespace in Special:Watchlist
Siebrand Mazeland [Wed, 27 Aug 2008 21:37:50 +0000 (21:37 +0000)]
Localisation updates for core messages from Betawiki (2008-08-27 23:24 CEST)
Roan Kattouw [Wed, 27 Aug 2008 21:15:42 +0000 (21:15 +0000)]
Revert part of r40107 (Revert r40042 because of regressions). The changes to UserMailer.php had nothing to do with that bug.
Brion Vibber [Wed, 27 Aug 2008 21:12:44 +0000 (21:12 +0000)]
Revert r40042 "* In Article::replaceSection(), actually return null when $section is bogus. Used this in my half-complete and now kind of abandoned attempt at rewriting EditPage.php"
This causes regression bug 15340 -- null-edits to a section destroy the rest of the page.
Aaron Schulz [Wed, 27 Aug 2008 20:44:43 +0000 (20:44 +0000)]
Set replace flag for headers
Roan Kattouw [Wed, 27 Aug 2008 20:28:12 +0000 (20:28 +0000)]
Make Special:Allpages/User:Foo actually work. Patch by Mormegil
Raimond Spekking [Wed, 27 Aug 2008 19:49:09 +0000 (19:49 +0000)]
Add an own message for the fieldset legend instead of duplicating the special page name
Huji [Wed, 27 Aug 2008 19:33:53 +0000 (19:33 +0000)]
Localisation updates: Using a better Persian translation for "hide"
Bryan Tong Minh [Wed, 27 Aug 2008 19:10:57 +0000 (19:10 +0000)]
Fixup the function declarations that we're overridden from UploadFromBase.
Antoine Musso [Wed, 27 Aug 2008 18:25:24 +0000 (18:25 +0000)]
Lets render BMP pictures to PNG.
Raimond Spekking [Wed, 27 Aug 2008 18:23:03 +0000 (18:23 +0000)]
Move the timestamp into the message of the current revision link to make the link consistent with the link to the previous version on the left side
Bryan Tong Minh [Wed, 27 Aug 2008 18:09:18 +0000 (18:09 +0000)]
* Remove a debug statement
* Return a status on unsaveTempFile
Bryan Tong Minh [Wed, 27 Aug 2008 17:38:33 +0000 (17:38 +0000)]
Splitting backend upload code from SpecialUpload.
* All common upload code resides in UploadFromBase. Then depending on the upload source, one of its derived classes is initiated by Special:Upload.
* SpecialUpload::ajaxGetExistsWarning now only returns warnings that are related to existence.
* Allow LocalFile::upload to attribute the upload to another user than $wgUser
This introduces breaking changes for upload extensions.
Roan Kattouw [Wed, 27 Aug 2008 16:48:30 +0000 (16:48 +0000)]
API:
* Add titlePartToKey() and keyPartToTitle() which use the substr() hack to preserve trailing spaces
* Migrate function calls where needed. ??continue parameters still use titleToKey() because they're generated using keyToTitle() and therefore can't contain trailing spaces
Roan Kattouw [Wed, 27 Aug 2008 16:40:29 +0000 (16:40 +0000)]
Fix fatal error caused by missing comma
Chad Horohoe [Wed, 27 Aug 2008 15:22:50 +0000 (15:22 +0000)]
Reverting my reversions of the fieldset on Special:Watchlist. I liked it, and apparently some other people did too (although some don't). Plus, it's been pointed out that semantically, a fieldset belongs around fields. Who knew? Could use some CSS tweaks maybe.
Chad Horohoe [Wed, 27 Aug 2008 15:07:30 +0000 (15:07 +0000)]
Can't add to a variable if it doesn't exist...
Daniel Friesen [Wed, 27 Aug 2008 14:47:41 +0000 (14:47 +0000)]
Fix a minor regression pointed out by aaron.
The spacer for between the preview area and the edit toolbar was being outputted even when not previewing.
Siebrand Mazeland [Wed, 27 Aug 2008 14:33:05 +0000 (14:33 +0000)]
Remove messages and rebuild all messages files per r40076.
Chad Horohoe [Wed, 27 Aug 2008 14:32:15 +0000 (14:32 +0000)]
Remove fieldset from Watchlist that apparently only I liked :)
Bryan Tong Minh [Wed, 27 Aug 2008 13:40:11 +0000 (13:40 +0000)]
Check on $wgEnableEmail && $wgEnableUserEmail
Bryan Tong Minh [Wed, 27 Aug 2008 13:36:39 +0000 (13:36 +0000)]
* Fixup validation methods in UserEmailForm a bit so that they don't return arrays when it's not necessary.
* Add email errors to the API's message map
Raimond Spekking [Wed, 27 Aug 2008 12:19:37 +0000 (12:19 +0000)]
Remove unused messages, function deleted with r39717.
Tim Starling [Wed, 27 Aug 2008 09:25:31 +0000 (09:25 +0000)]
Patch by Shlomi Fish to fix this test
Aaron Schulz [Wed, 27 Aug 2008 06:45:49 +0000 (06:45 +0000)]
Add $wgPhpCli var so shell outs know what exec name to use
Daniel Friesen [Wed, 27 Aug 2008 06:06:39 +0000 (06:06 +0000)]
Minor error... sorry bout that, forgot to remove the > when I redid the fix locally.
Daniel Friesen [Wed, 27 Aug 2008 05:56:34 +0000 (05:56 +0000)]
Recommit the EditPage changes:
Thanks for the heads up brion. $attribs was being overridden in EditPage::showTextbox rather than having individual things set which caused the tabindexes inputted to be ignored. Your test case is fixed.
I did a page diff, there are no more ui regressions. The only difference is the preview-toolbar <p><br /></p> has been moved from the inside of the preview to outside of it. There's no real difference in that.
Brion Vibber [Wed, 27 Aug 2008 00:19:13 +0000 (00:19 +0000)]
Revert r40027 "Recommit my changes to EditPage without the regressions:"
This caused at least a regression in tab order which causes all my edits to fail:
1) Click "edit"
2) Hit "tab" to tab into edit field
3) Type something
4) Hit "tab" to tab into the comment field
5) Hit "enter" to save
Hey wait a minute, where's my edit?
When I go back and do it over, I find that I get tabbed from the edit box to the *cancel link*, so hitting enter goes back to the view page, destroying my edit.
Not good. :(
Haven't checked for other regressions; please be *very* careful with this edit page work, as seemingly small breakages can really damage the user experience and make things really badly broken.
Maybe we need a fuller UI test suite...
Aaron Schulz [Tue, 26 Aug 2008 22:40:45 +0000 (22:40 +0000)]
add more info
Aaron Schulz [Tue, 26 Aug 2008 22:35:23 +0000 (22:35 +0000)]
log strange anomaly
Andrew Garrett [Tue, 26 Aug 2008 22:24:44 +0000 (22:24 +0000)]
Reset password throttles on login
Roan Kattouw [Tue, 26 Aug 2008 22:18:24 +0000 (22:18 +0000)]
API: Remove the throttle from ApiLogin because
* it's been obsoleted by a similar throttle in core
* it uses time(), which causes problems when you have multiple servers with a significant clock skew between them
Roan Kattouw [Tue, 26 Aug 2008 21:34:47 +0000 (21:34 +0000)]
API: Improvements to action=emailuser:
* Add two messages from ApiEmailUser to ApiBase::$messageMap
* Add email tokens to prop=info
Roan Kattouw [Tue, 26 Aug 2008 20:49:52 +0000 (20:49 +0000)]
API: Fixed bug that caused all action=edit requests to return with the nochange flag set on wikis where DB_MASTER != DB_SLAVE
Roan Kattouw [Tue, 26 Aug 2008 20:40:44 +0000 (20:40 +0000)]
API: Throwing a more specific error message when the client tries to create empty new sections, which isn't allowed. Unknown error: ``228'' isn't very user-friendly.
Brion Vibber [Tue, 26 Aug 2008 20:26:26 +0000 (20:26 +0000)]
-T
Raimond Spekking [Tue, 26 Aug 2008 20:23:53 +0000 (20:23 +0000)]
Fix for r40041. PHP strict notice. Thanks to Ialex
Rotem Liss [Tue, 26 Aug 2008 20:23:23 +0000 (20:23 +0000)]
Localization update.
Brion Vibber [Tue, 26 Aug 2008 20:17:58 +0000 (20:17 +0000)]
* (bug 15264) Underscores in Special:Search/Foo_bar parameters were taken
literally; now converting them to spaces per expectation.
Roan Kattouw [Tue, 26 Aug 2008 20:07:53 +0000 (20:07 +0000)]
* In Article::replaceSection(), actually return null when $section is bogus. Used this in my half-complete and now kind of abandoned attempt at rewriting EditPage.php
* In UserMailer::send(), allow the caller to override the Content-type header so people can send multipart messages if they really want to. Using this in an extension I'm developing
Raimond Spekking [Tue, 26 Aug 2008 20:06:57 +0000 (20:06 +0000)]
* Add tooltips to rollback and undo links
At least on de.wiki the users with the review right have the rollback right too. They are confused about the difference rollback/undo. Hope that helps a bit
Brion Vibber [Tue, 26 Aug 2008 18:51:27 +0000 (18:51 +0000)]
Quick hack to fix the broken hack noted in bug 15301
Use of:
$action_desc[0] = strtolower($action_desc[0]);
is horrible wrong for a few reasons:
1) The first-byte match fails for all non-ASCII characters -- use lcfirst()!
2) System strtolower() or lcfirst() may not work for UTF-8 or lang-specific issues properly; use $wgLang->lcfirst()
3) You shouldn't be forcing things to lowercase here anyway, you can't know it's correct gramattically.
This whole message output should be redone cleanly; either all the rights info messages should be designed to work in an inline list sentence, or they should be formatted as stand-alone text strings using a <ul> or something.
Daniel Friesen [Tue, 26 Aug 2008 15:45:32 +0000 (15:45 +0000)]
Recommit my changes to EditPage without the regressions:
* Content was double encoded by the call to htmlspecialchars and the use of Xml::textarea
* showFormBeforeText was returning instead of outputting (This caused saves to fail since there was no edittime)
* As a little extra no-one noticed, accidentally $encodedtext was left in showTextbox2 rather than $this->textbox2.
Alexandre Emsenhuber [Tue, 26 Aug 2008 15:31:52 +0000 (15:31 +0000)]
Fix path. Patch by rindolf on IRC.
Chad Horohoe [Tue, 26 Aug 2008 15:23:53 +0000 (15:23 +0000)]
Move @ingroup around so each of the classes are picked up by Doxygen.
Chad Horohoe [Tue, 26 Aug 2008 15:10:52 +0000 (15:10 +0000)]
Revert 40016, 40021, 40022. Breaks ability to save and has html entities problems.
Alexandre Emsenhuber [Tue, 26 Aug 2008 15:10:12 +0000 (15:10 +0000)]
Redo r39954, without regression this time. Sorry :(
Robert Leverington [Tue, 26 Aug 2008 14:58:50 +0000 (14:58 +0000)]
* Remove duplicated function in EditPage.
Daniel Friesen [Tue, 26 Aug 2008 14:38:25 +0000 (14:38 +0000)]
Whoops, this was probably supposed to be an elseif.
Tim Starling [Tue, 26 Aug 2008 14:37:15 +0000 (14:37 +0000)]
* Revert back to my parser pseudo-branch again. Note: if you feel like reverting this, reverting Parser.php alone to r40010 will work just fine.
* Merged replaceFreeExternalLinks() with doMagicLinks(). Makes a lot of sense, very similar operations, doesn't break any parser tests. Stops free links from interacting with other parser stages, the same way ISBN links don't.
* The pass order change fixes Brion's complaint in r39980. Early link expansion, triggered by having more than 1000 links in the page, was outputting URLs which were destroyed by RFEL. Added parser test.
* Fixed an unrelated bug in LinkHolderArray::replace(): if a link to a redirect appears in two separate RLH calls, the second and subsequent calls do not add the mw-redirect class. Caused by an unmigrated LinkCache fetch.
* Added a parser test for a pass interaction bug that the pass order change fixes.
* The fuzzer told me to tell you that free external links in non-caption image parameters, which are and have always been invisible, are now not registered either.
* Miscellaneous supporting updates to the test infrastructure.
Shinjiman [Tue, 26 Aug 2008 14:22:39 +0000 (14:22 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese
Raimond Spekking [Tue, 26 Aug 2008 14:21:10 +0000 (14:21 +0000)]
Make the elements of the watchlist fieldset identical to the elements of the recent changes fieldset.