Bartosz Dziewoński [Thu, 22 Sep 2016 21:14:23 +0000 (21:14 +0000)]
Merge "Correct error handling for exceptions in 'user' module"
jenkins-bot [Thu, 22 Sep 2016 21:05:56 +0000 (21:05 +0000)]
Merge "Remove old remapping hacks from Database::indexName()"
Bartosz Dziewoński [Sun, 18 Sep 2016 12:54:36 +0000 (14:54 +0200)]
Correct error handling for exceptions in 'user' module
Rearrange code so that the try...catch which is supposed to catch
exceptions when evalling code actually catches them. Evaluation of
'user' module was wrapped in `mw.loader.using( 'site' ).always( ... )`,
so it could be executed asynchronously, so try...catch never caught
exceptions from it; they bubbled up to all kinds of weird places and
broke things in confusing ways.
I think the same issue could occur for any module when waiting for
legacy modules to load ('wgResourceLoaderLegacyModules').
Bug: T145970
Change-Id: I91e7d0b4e50c786f7302e30a2b7ed43c3cd0da6c
Translation updater bot [Thu, 22 Sep 2016 20:56:08 +0000 (22:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3796071d3b7f94e65c50a0444fd345a8eeb84534
jenkins-bot [Thu, 22 Sep 2016 20:47:57 +0000 (20:47 +0000)]
Merge "Make Database::__clone() a bit more robust using handleSessionLoss()"
jenkins-bot [Thu, 22 Sep 2016 20:43:23 +0000 (20:43 +0000)]
Merge "Split up DBError classes into their own files"
Aaron Schulz [Wed, 21 Sep 2016 21:25:00 +0000 (14:25 -0700)]
Make Database::__clone() a bit more robust using handleSessionLoss()
Change-Id: I6c16abceea612a7b1167b9cca70a174fa6b77020
Aaron Schulz [Thu, 22 Sep 2016 19:12:01 +0000 (12:12 -0700)]
Split up DBError classes into their own files
Change-Id: I671f1a88f0192a5199cfc9c6d7fbde1bff5c4ac8
jenkins-bot [Thu, 22 Sep 2016 20:23:50 +0000 (20:23 +0000)]
Merge "Follow-up
764cd6a1: unbreak quiet buttons"
jenkins-bot [Thu, 22 Sep 2016 19:35:14 +0000 (19:35 +0000)]
Merge "Remove MediaWiki mentions from /rdbms error strings"
Aaron Schulz [Wed, 21 Sep 2016 19:50:34 +0000 (12:50 -0700)]
Remove MediaWiki mentions from /rdbms error strings
Change-Id: Ia330d8e465641d04e5d22a24490d792913f1ccb8
Roan Kattouw [Thu, 22 Sep 2016 19:01:11 +0000 (12:01 -0700)]
Follow-up
764cd6a1: unbreak quiet buttons
Quiet buttons are supposed to be initially gray,
not initially colored.
Bug: T146401
Change-Id: I8c3020591c82f7b2c1f7043892e73019886478af
Ramunas Geciauskas [Tue, 8 Mar 2016 16:04:27 +0000 (11:04 -0500)]
Add category name in ID property for extension row in Special:Version page
Extensions can belong to multiple different categories. When listing them in
the Special:Version page each entry is surrounded with HTML element with
ID property "mw-version-ext-{NAME}". This causes generation of duplicate
ID values, which is against W3C rules.
To preserve valid and compliant HTML while retaining ID values, change the
ID pattern to "mw-version-ext-{CATEGORY}-{NAME}".
Bug: T99025
Change-Id: Ifdde0704631f1ef41e4c83e7e8116003983e0808
Timo Tijhof [Thu, 22 Sep 2016 17:29:28 +0000 (18:29 +0100)]
tests: Fix invalid @covers value in StatusTest.php
Uusally, phpunit issues a warning and continues to generate the
report but in this case it caused an early exit with no output.
Follows-up
3706dcb5c.
> Trying to @cover not existing method Status::getErrorsOnlyStatus.
Also:
* Increase coverage by adding @covers where missing.
* Use setOK() internally.
* Add test for 'ok' setter.
Change-Id: If6db634079c857f02b2594be199e6910ec49a52a
jenkins-bot [Thu, 22 Sep 2016 07:17:39 +0000 (07:17 +0000)]
Merge "Remove screen layout references in passwordreset-email* messages"
jenkins-bot [Thu, 22 Sep 2016 05:36:32 +0000 (05:36 +0000)]
Merge "Use ConvertibleTimestamp::convert() in a few places"
Aaron Schulz [Thu, 22 Sep 2016 05:22:04 +0000 (22:22 -0700)]
Actually set errorLogger in Database
Change-Id: Icc2e49bcedf5172c1c1fdf8202acc6c1abdbac5b
Kunal Mehta [Thu, 22 Sep 2016 04:46:24 +0000 (21:46 -0700)]
Use ConvertibleTimestamp::convert() in a few places
Change-Id: I9da31cd96fa7afa5cfccbbc204fb446fdb1a3c65
Kunal Mehta [Thu, 22 Sep 2016 04:43:32 +0000 (21:43 -0700)]
Rename Convert*a*bleTimestamp to Convert*i*bleTimestamp
Per the dictionary.
Change-Id: I3dcef9fb020c8c6764ee073111ed8c032e4c5a63
jenkins-bot [Thu, 22 Sep 2016 04:34:16 +0000 (04:34 +0000)]
Merge "time: Implement ConvertableTimestamp::now()"
jenkins-bot [Thu, 22 Sep 2016 04:31:59 +0000 (04:31 +0000)]
Merge "Add deprecated comment to Article::doEdit()"
Kunal Mehta [Thu, 22 Sep 2016 03:28:42 +0000 (20:28 -0700)]
time: Implement ConvertableTimestamp::now()
Shortcut for ConvertableTimestamp::convert() for the current time.
Change-Id: I1c34c0a59bb57652c7a2e959836c8ba400a25f49
jenkins-bot [Thu, 22 Sep 2016 03:55:33 +0000 (03:55 +0000)]
Merge "time: Implement ConvertableTimestamp::convert()"
Timo Tijhof [Wed, 21 Sep 2016 00:19:00 +0000 (01:19 +0100)]
time: Implement ConvertableTimestamp::convert()
* This method is analogous to wfTimestamp(). Optimise for the common
idiom of just converting a timestamp without having the caller hold
on to any object.
* Make wfTimestamp() use this (it could already since it didn't
use any MWTimestamp methods). Use via MWTimestamp. While this is
the same as direct access, it allows future changes.
* Add tests covering this new method.
Change-Id: I7f9104f1701d92fe25d72c7943581c64e1d093fa
jenkins-bot [Thu, 22 Sep 2016 03:30:06 +0000 (03:30 +0000)]
Merge "Move IP class to libs/"
jenkins-bot [Thu, 22 Sep 2016 03:25:20 +0000 (03:25 +0000)]
Merge "Remove MimeMagic depedency from FSFile and move it to /libs"
jenkins-bot [Thu, 22 Sep 2016 03:19:27 +0000 (03:19 +0000)]
Merge "Move IP::isConfigured/TrustedProxy() to ProxyLookup service"
Kunal Mehta [Thu, 22 Sep 2016 03:18:08 +0000 (20:18 -0700)]
Move IP class to libs/
Also fix some misplaced parenthesis in IPTest.
Change-Id: I84d6120c49f733ec45e7e0005259871808b7568b
Aaron Schulz [Mon, 19 Sep 2016 02:05:48 +0000 (19:05 -0700)]
Remove MimeMagic depedency from FSFile and move it to /libs
Change-Id: Ieaae909b49c798b6e9bed65d15961cefbdaec49b
jenkins-bot [Thu, 22 Sep 2016 03:02:14 +0000 (03:02 +0000)]
Merge "Move SamplingStatsdClient into stats/ subdirectory"
Kunal Mehta [Thu, 22 Sep 2016 02:52:06 +0000 (19:52 -0700)]
Move IP::isConfigured/TrustedProxy() to ProxyLookup service
This creates a new ProxyLookup service to house the
IP::isConfiguredProxy() and IP::isTrustedProxy() functions. The main
purpose of this refactoring is to make the IP class entirely independent
from MediaWiki, so it can be split into a separate library.
Change-Id: I60434a5f3d99880352bc0f72349c33b7d029ae09
jenkins-bot [Thu, 22 Sep 2016 03:01:51 +0000 (03:01 +0000)]
Merge "refreshLinks: Use vslow group for DB_REPLICA connections"
jenkins-bot [Thu, 22 Sep 2016 02:07:14 +0000 (02:07 +0000)]
Merge "Migrate callers to new MWFileProps::getPropsFromPath() method"
jenkins-bot [Thu, 22 Sep 2016 00:40:45 +0000 (00:40 +0000)]
Merge "Dependency inject $wgTmpDirectory into FileBackend classes"
Aaron Schulz [Mon, 19 Sep 2016 01:39:59 +0000 (18:39 -0700)]
Migrate callers to new MWFileProps::getPropsFromPath() method
* FSFile should not be responsible for handling this much logic.
* Make more MediaHandler classes aware of the fact that an object
other than File might be passed in. Use the FSFile instead of a
useless empty stdClass object.
* Also added more fields to FSFile::placeholderProps to make it
more complete.
Change-Id: I9fe764b2a7261af507c6555e6a57273cf7d00d36
Aaron Schulz [Wed, 21 Sep 2016 16:38:34 +0000 (09:38 -0700)]
Use standard exceptions in ObjectCache and always handle CACHE_NONE/"hash"
* If cache CACHE_NONE or "hash" is not set yet or was unset,
return the proper new object anyway for sanity.
* Also fixed $params typo in newFromParams(). This should not
have any effect since SqlBagOStuff ignores the key in this case.
* Removed excess "use" statement.
Change-Id: I36108a865273b9c209145828e5e1216b545ef431
jenkins-bot [Wed, 21 Sep 2016 21:48:39 +0000 (21:48 +0000)]
Merge "Cleanup method visibilites in Database"
jenkins-bot [Wed, 21 Sep 2016 21:41:11 +0000 (21:41 +0000)]
Merge "Set more FakeDatabaseMysqlBase fields in __construct()"
L10n-bot [Wed, 21 Sep 2016 21:21:58 +0000 (21:21 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Wed, 21 Sep 2016 21:16:46 +0000 (23:16 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib08086b1ad6f1c9409464178b552525bb74e41e4
jenkins-bot [Wed, 21 Sep 2016 21:13:36 +0000 (21:13 +0000)]
Merge "Clean up lock name in lock messages in DatabaseMysqlBase"
jenkins-bot [Wed, 21 Sep 2016 21:12:00 +0000 (21:12 +0000)]
Merge "Fix IDEA warnings in CloneDatabase"
Aaron Schulz [Wed, 21 Sep 2016 21:06:12 +0000 (14:06 -0700)]
Set more FakeDatabaseMysqlBase fields in __construct()
Change-Id: I37a1e4aae186e19637817bd10be0d8fad06187d4
Alexander I. Mashin [Tue, 2 Aug 2016 13:08:05 +0000 (20:08 +0700)]
Fix to incorrect calls of header () breaking saving some pages and login
This is to fix incorrect calls of header () with null as its third parametre
in WebResponse::header ().
Under HHVM 3.14.3 this causes warnings in error.log and breaks saving page
and user login.
Bug: T140864
Change-Id: I98291e2746e92e22672de077bccfb36ae91d2c62
jenkins-bot [Wed, 21 Sep 2016 20:17:28 +0000 (20:17 +0000)]
Merge "Set more fields in fake DB subclasses to avoid errors"
jenkins-bot [Wed, 21 Sep 2016 20:13:28 +0000 (20:13 +0000)]
Merge "Set the DatabaseDomain in some tests classes for sanity"
Reedy [Wed, 21 Sep 2016 20:13:20 +0000 (21:13 +0100)]
Add deprecated comment to Article::doEdit()
Already there on WikiPage, but this brings it to the IDEs
attention rather than @see
Bug: T145736
Change-Id: Ic931f83d15638f2babce22edf14ee8626b8a0266
jenkins-bot [Wed, 21 Sep 2016 20:03:36 +0000 (20:03 +0000)]
Merge "Remove dangling $wgDBmysql5 usage from DatabaseMysqli"
Aaron Schulz [Wed, 21 Sep 2016 19:55:45 +0000 (12:55 -0700)]
Remove dangling $wgDBmysql5 usage from DatabaseMysqli
Change-Id: Iee21655e12eb3001496123ff8438adc1c39ecdf8
Aaron Schulz [Wed, 21 Sep 2016 19:52:17 +0000 (12:52 -0700)]
Remove old remapping hacks from Database::indexName()
Change-Id: Icab995aa6a442aab133da723363f794ef9128eb8
Aaron Schulz [Wed, 21 Sep 2016 19:25:08 +0000 (12:25 -0700)]
Cleanup method visibilites in Database
Also removed some unused cruft
Change-Id: I855d0e0d6571ea15c03d2a27bf55ad5e14cd15d4
jenkins-bot [Wed, 21 Sep 2016 19:14:19 +0000 (19:14 +0000)]
Merge "Check Database::mSessionTempTables in Database::tableExists()"
Aaron Schulz [Wed, 21 Sep 2016 17:44:15 +0000 (10:44 -0700)]
Check Database::mSessionTempTables in Database::tableExists()
Also make the temp table tracking catch plain "DROP TABLE"
in addition to the stricter "DROP TEMPORARY TABLE" clause.
Bug: T146300
Change-Id: Ia8306ec25e63adcdcf0dcc8f6a700dd01afdc948
Aaron Schulz [Wed, 21 Sep 2016 18:56:22 +0000 (11:56 -0700)]
Set more fields in fake DB subclasses to avoid errors
Change-Id: I6b24422e830a8f82ba24383b3425808cb2a28b15
jenkins-bot [Wed, 21 Sep 2016 18:54:32 +0000 (18:54 +0000)]
Merge "Database: Behave correctly when inserting booleans"
MarkTraceur [Wed, 21 Sep 2016 18:48:56 +0000 (18:48 +0000)]
Merge "mw.api.upload: Suppress default API call timeout"
jenkins-bot [Wed, 21 Sep 2016 18:41:06 +0000 (18:41 +0000)]
Merge "Make LBFactory::waitForReplication() use "domain" instead of "wiki""
Bartosz Dziewoński [Wed, 14 Sep 2016 17:43:24 +0000 (19:43 +0200)]
mw.api.upload: Suppress default API call timeout
mw.Api sets a default timeout of 30 seconds, meaning that if the
request takes more than that, it will be aborted. This is reasonable
in most cases, but file uploads can easily take longer than that.
Bug: T117545
Change-Id: I086108421d229c60f5e9d5c9edb70150d875dcb0
jenkins-bot [Wed, 21 Sep 2016 18:37:22 +0000 (18:37 +0000)]
Merge "Add sanity check to LoadBalancer::setDomainPrefix()"
Aaron Schulz [Wed, 21 Sep 2016 18:20:22 +0000 (11:20 -0700)]
Fix IDEA warnings in CloneDatabase
Change-Id: I45231237dd49dfdd8158a68d8f63d769b762f19c
Brad Jorsch [Wed, 21 Sep 2016 18:03:29 +0000 (14:03 -0400)]
Database: Behave correctly when inserting booleans
Pretty much everything seems to assume that PHP booleans should be
converted to 0/1: MySQL does this implicitly thanks to the lack of
strict mode by default, while PostgreSQL and Sqlite (and Mssql) do it
explicitly.
The addition of MySQL strict mode for unit tests in Ib2873913 exposed
the assumption in the case of MySQL by making some extension unit tests
fail. So let's make casting bool to int the default behavior of
Database::addQuotes().
This also cleans up the phpdoc for Database::addQuotes() to properly
reflect all the supported types that can be passed to it.
Change-Id: I13d0e402fa676bc27c345e8ac12f363ebc627f6a
jenkins-bot [Wed, 21 Sep 2016 17:24:33 +0000 (17:24 +0000)]
Merge "Remove .mw-help-field-hint and -data CSS classes from mw.legacy/shared"
Prateek Saxena [Tue, 5 Jul 2016 11:50:57 +0000 (17:20 +0530)]
Remove .mw-help-field-hint and -data CSS classes from mw.legacy/shared
No longer used anywhere.
Also removing the images used in these classes.
Bug: T89981
Change-Id: I665cfee4e10a50789ce2260983ff6f623bb4c9e2
Aaron Schulz [Wed, 21 Sep 2016 08:33:29 +0000 (01:33 -0700)]
Add sanity check to LoadBalancer::setDomainPrefix()
Fixed some errors that popped up in CI:
* Also cleanup $domain handling in reuseConnection().
* Fix empty string handling in openForeignConnection() where
the empty string check against $dbName failed since an empty
string $domain results in $dbName being null.
Change-Id: Ie78fefa1acb401fe4e8bdc96b75053692aa0a925
Brad Jorsch [Wed, 21 Sep 2016 15:43:15 +0000 (11:43 -0400)]
Add table prefix in new MySQL tableExists()
Bug: T146289
Change-Id: If73907f69471a6a91e1db7131a57439f950c5d8c
Purodha [Wed, 27 Jul 2016 12:58:44 +0000 (12:58 +0000)]
Remove screen layout references in passwordreset-email* messages
See https://www.mediawiki.org/wiki/Localisation#Avoid_references_to_visual_layout_and_positions
Bug: T141199
Change-Id: I3bdee543591000b1dac3387116236e5515ad3292
Aaron Schulz [Wed, 21 Sep 2016 10:00:48 +0000 (03:00 -0700)]
Set the DatabaseDomain in some tests classes for sanity
Change-Id: I6531dc6cf89fbe7e5656354bcd4a27369f573752
Aaron Schulz [Wed, 21 Sep 2016 08:38:45 +0000 (01:38 -0700)]
Make LBFactory::waitForReplication() use "domain" instead of "wiki"
Change-Id: Id7e55fddb96631b3938ee6ddcfcc3ce13ba942d4
Kunal Mehta [Wed, 21 Sep 2016 08:25:06 +0000 (01:25 -0700)]
Fix @return of LBFactorySimple::getExternalLB()
Change-Id: If5353af7c4ec3781597159c12481444159c463f3
jenkins-bot [Wed, 21 Sep 2016 08:21:38 +0000 (08:21 +0000)]
Merge "ChronologyProtector: Remove unused 'use MediaWiki\Logger\LoggerFactory'"
jenkins-bot [Wed, 21 Sep 2016 08:08:27 +0000 (08:08 +0000)]
Merge "Use getConnectionRef() in ExternalStoreDB to avoid connection leaks"
Kunal Mehta [Wed, 21 Sep 2016 08:02:09 +0000 (01:02 -0700)]
ChronologyProtector: Remove unused 'use MediaWiki\Logger\LoggerFactory'
Change-Id: I54a0d17605d3bc25c1d78a3a606e371fa74eaab0
Aaron Schulz [Wed, 21 Sep 2016 07:58:14 +0000 (00:58 -0700)]
Use getConnectionRef() in ExternalStoreDB to avoid connection leaks
Change-Id: I3df270241653841a4fb2f65e240aae9d2e0b650f
Kunal Mehta [Wed, 21 Sep 2016 07:47:55 +0000 (00:47 -0700)]
Move SamplingStatsdClient into stats/ subdirectory
Change-Id: Ib871aa5cd674d58da3d19bfbb5660539afc863b3
Aaron Schulz [Wed, 21 Sep 2016 07:34:23 +0000 (00:34 -0700)]
Add some missing reuseConnection() to LoadBalancer
Change-Id: I99099f909e7759c061d44ad4e1ed049e038a4d7d
Kunal Mehta [Wed, 21 Sep 2016 06:10:54 +0000 (23:10 -0700)]
MultiHttpClient: Don't use wfArrayToCgi()
http_build_query() should be functionally identical.
Change-Id: Ia7d909e97a89d66dbe5187e9a0423e2ecf8561e8
Kunal Mehta [Wed, 21 Sep 2016 06:00:54 +0000 (23:00 -0700)]
Avoid Wikimedia\Assert in HashBagOStuff
This is the only usage of wikimedia/assert in the planned objectcache
library, so it doesn't make much sense to have a dependency upon the
entire library just for one usage that is trivially replaced.
Change-Id: I8f967fb2b861852c7fc74f7d42e2cbab1df05bc4
jenkins-bot [Wed, 21 Sep 2016 04:45:04 +0000 (04:45 +0000)]
Merge "Fix importation of weird file names in importTextFiles.php"
This, that and the other [Fri, 12 Aug 2016 01:17:02 +0000 (11:17 +1000)]
Fix importation of weird file names in importTextFiles.php
When importing a file whose name contains a #, the script would call
e.g. Title::newFromText( '#foo' ), which succeeds (because titles
are allowed to contain fragments) but causes problems when trying
to create the revision.
Also avoid fatals on actual invalid titles.
Bug: T142675
Change-Id: I6b4c8fd8dd09db14c0704c74137e112b292c964a
Aaron Schulz [Wed, 21 Sep 2016 03:39:55 +0000 (20:39 -0700)]
Dependency inject $wgTmpDirectory into FileBackend classes
Change-Id: I219daffa67ff672bf5bd38921f4b1ca058d96b0f
jenkins-bot [Wed, 21 Sep 2016 03:57:31 +0000 (03:57 +0000)]
Merge "Move XMP* classes to includes/libs"
jenkins-bot [Wed, 21 Sep 2016 03:53:37 +0000 (03:53 +0000)]
Merge "XMPValidate: Use ConvertibleTimestamp instead of wfTimestamp()"
jenkins-bot [Wed, 21 Sep 2016 03:36:23 +0000 (03:36 +0000)]
Merge "mediawiki.requestIdleCallback: Avoid native window.requestIdleCallback"
Kunal Mehta [Wed, 21 Sep 2016 03:20:10 +0000 (20:20 -0700)]
Move XMP* classes to includes/libs
These no longer have any dependencies upon MediaWiki and can be split
out into a separate library.
Tests were updated for the new location and to no longer depend upon
MediaWikiTestCase.
Bug: T100922
Change-Id: I6ad507fa883d5934b807f9e31c507659d0730b52
Kunal Mehta [Wed, 21 Sep 2016 03:09:03 +0000 (20:09 -0700)]
XMPValidate: Use ConvertibleTimestamp instead of wfTimestamp()
This removes the last MediaWiki dependency in the XMP* classes, and they
can now be moved to libs/ (in a follow up patch).
Change-Id: Iee509fce0e44ec0697e1cdd4cd711846cf35e1e6
jenkins-bot [Wed, 21 Sep 2016 01:37:43 +0000 (01:37 +0000)]
Merge "Toolbox: Mark RecentChangesLinked link as nofollow"
jenkins-bot [Wed, 21 Sep 2016 01:22:21 +0000 (01:22 +0000)]
Merge "Improve lag/flag behavior and docs in LoadBalancer"
James D. Forrester [Wed, 21 Sep 2016 00:45:31 +0000 (17:45 -0700)]
Toolbox: Mark RecentChangesLinked link as nofollow
Bug: T146233
Change-Id: I2dd0b3a179dc0d1d7210d98748f45e75f953d2bf
Aaron Schulz [Wed, 21 Sep 2016 00:25:58 +0000 (17:25 -0700)]
Clean up lock name in lock messages in DatabaseMysqlBase
Change-Id: I9d3eb566f4e4f6d982cbc15df082cf2dd3f9614e
jenkins-bot [Wed, 21 Sep 2016 00:19:11 +0000 (00:19 +0000)]
Merge "Use Status::isOK() method in FileDeleteForm"
jenkins-bot [Wed, 21 Sep 2016 00:04:56 +0000 (00:04 +0000)]
Merge "jsduck: Remove custom @source tag"
Aaron Schulz [Tue, 20 Sep 2016 19:57:50 +0000 (12:57 -0700)]
Improve lag/flag behavior and docs in LoadBalancer
* Set DBO_DEFAULT if "flags" is not set. MediaWiki config bootstrapping
does this, but for outside users, it should still be the default too.
* Make "is static" do more than no-oping DatabaseMysqlBase::masterPosWait().
It now also treats servers with this flag as having 0 lag at all times.
This makes it far more useful, as the point of the flag is to mark DBs
that are archival clones of each other and may not even replicate.
* Add more ILoadBalancer usage documentation.
Change-Id: Ib0b44e42e9f4c57a292d6a6ea17beb454db464bc
jenkins-bot [Tue, 20 Sep 2016 23:51:30 +0000 (23:51 +0000)]
Merge "Mention the lock name in DatabaseMysqlBase lock() errors"
jenkins-bot [Tue, 20 Sep 2016 23:50:01 +0000 (23:50 +0000)]
Merge "Remove Database clone call from DatabaseTests.php"
Timo Tijhof [Tue, 20 Sep 2016 23:44:39 +0000 (00:44 +0100)]
jsduck: Remove custom @source tag
Only used in external.js to render a simple link. These methods
don't have a regular description and as such the link renders
effectively the same way in the same place without `@source`.
Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
Aaron Schulz [Tue, 20 Sep 2016 23:34:09 +0000 (16:34 -0700)]
Mention the lock name in DatabaseMysqlBase lock() errors
Also use warning() instead of debug()
Change-Id: I9f5b331072caf29985bfb4319786cc2c5cddf5dd
Timo Tijhof [Tue, 20 Sep 2016 23:01:16 +0000 (00:01 +0100)]
mediawiki.requestIdleCallback: Avoid native window.requestIdleCallback
Follows-up
482ad8d9fb.
This currently has bugs in Chrome that can cause it to not get called
for up to 30 seconds.
https://bugs.chromium.org/p/chromium/issues/detail?id=647870
Change-Id: I221cd6c2bcdbee89bc7401c071f2ab1865a738ed
Aaron Schulz [Tue, 20 Sep 2016 23:24:16 +0000 (16:24 -0700)]
Remove Database clone call from DatabaseTests.php
Change-Id: I60a22de9ccc7253abc9bbefe2a4f38675655ee4f
jenkins-bot [Tue, 20 Sep 2016 23:21:30 +0000 (23:21 +0000)]
Merge "FSFile and TempFSFile cleanups"
jenkins-bot [Tue, 20 Sep 2016 23:17:08 +0000 (23:17 +0000)]
Merge "Move some FileBackend related classes to /libs"