Raimond Spekking [Mon, 12 Dec 2011 07:33:46 +0000 (07:33 +0000)]
remove message keys from maintenance files too (r105855)
Amir E. Aharoni [Mon, 12 Dec 2011 06:40:40 +0000 (06:40 +0000)]
Replaced the core message 'sectionlink' with getArrow, which is cleaner and does the right thing in mixed RTL/LTR environment. Removed the message from the messages files, because it doesn't seem to be used elsewhere.
Amir E. Aharoni [Mon, 12 Dec 2011 06:31:13 +0000 (06:31 +0000)]
Fixes Bug 32403. Will only work on browsers that support dir="auto". Won't break in other browsers.
Brion Vibber [Mon, 12 Dec 2011 06:27:20 +0000 (06:27 +0000)]
* (bug 32958) SpecialAllMessages: input form doesn't show and remember filter option
Did this a little differently, but inspired by MrBlueSky's patch: https://bugzilla.wikimedia.org/attachment.cgi?id=9655
Rather than using the $this->custom values to check as in the patch, I moved $this->filter from the specialpage class (where it wasn't being used) to the pager class (where it was being used). Probably left over from a refactor.
Tim Starling [Mon, 12 Dec 2011 06:03:01 +0000 (06:03 +0000)]
Reverted r92364 (per-namespace permissions).
This is the wrong configuration format for such a feature, and the wrong interface. We already have certain per-namespace permissions in the Title class, and we didn't need to add extra formal parameters to a whole lot of User methods in order to get them. The feature should be implemented wholly in Title, and the concept of user rights should remain relatively simple and easy to understand, and independent of its many applications, i.e. a user either has a right or doesn't. Rights are just a tool for developing access policies; the complexity should be in the caller.
The revert was mostly done by hand, since there were a lot of conflicts. I tried to preserve the gist of conflicting changes in r102187 and r102873. The test changes are not simple reverts, rather I just edited out the per-namespace tests. I reverted the followups r92589 and r104310.
Tim Starling [Mon, 12 Dec 2011 02:10:00 +0000 (02:10 +0000)]
Revert r101091 per CR: the rule was removed intentionally in r98185.
Sam Reed [Mon, 12 Dec 2011 00:07:22 +0000 (00:07 +0000)]
Mark the test as broken again seeing as Jenkins isn't happy
Robin Pepermans [Mon, 12 Dec 2011 00:03:15 +0000 (00:03 +0000)]
Remove the (useless) configuration option $wgVectorShowVariantName. If set to false (which is default), it is not clear to users what the dropdown menu is about. Secondly, other skins display all variants as different tabs. Thirdly, Serbian and Chinese projects (most active projects relevant to this) have set it to true.
Sam Reed [Sun, 11 Dec 2011 23:29:06 +0000 (23:29 +0000)]
Revert r105834, WMF locally after fixing PHPUnit
Sam Reed [Sun, 11 Dec 2011 22:39:48 +0000 (22:39 +0000)]
Mark testPurgeMainPage broken after r105828 and r105833
PhpUnit is more than broken locally (and phpunit.de is down)
Sam Reed [Sun, 11 Dec 2011 21:49:05 +0000 (21:49 +0000)]
Attempt to fix tests broken by r105828
Test wanted in a specific order, now just look up wanted array key from title row
Untested as my phpunit tests seem to be b0rked locally :(
Robin Pepermans [Sun, 11 Dec 2011 21:13:18 +0000 (21:13 +0000)]
Slight correction to Veps autonym per Wikipedia article and https://meta.wikimedia.org/wiki/Requests_for_new_languages/Wikipedia_Veps_2 (and Google search confirms)
Sam Reed [Sun, 11 Dec 2011 21:07:39 +0000 (21:07 +0000)]
Make ApiQueryBase::addTitleInfo() add the pageid also
Sam Reed [Sun, 11 Dec 2011 20:57:57 +0000 (20:57 +0000)]
More documentation updates as I've been going around
Sam Reed [Sun, 11 Dec 2011 20:43:42 +0000 (20:43 +0000)]
* (bug 32495) API should allow purge by pageids.
ApiPageSet isn't really designed for non query usage, but a little hacking and it can be made to work in the ApiPageSet mould. Allows us to use titles, pageids and revids, without the work of validating them and such ourselves
Same caveat that you can't use a mix of them in one request - tough!
Sam Reed [Sun, 11 Dec 2011 20:41:23 +0000 (20:41 +0000)]
Followup r105823, make it protected
Raimond Spekking [Sun, 11 Dec 2011 20:35:30 +0000 (20:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Sun, 11 Dec 2011 20:34:36 +0000 (20:34 +0000)]
Trailing full stops
Sam Reed [Sun, 11 Dec 2011 20:32:37 +0000 (20:32 +0000)]
Adding a getDB function to ApiBase...
Not all subclasses will need/want it. It does however make it easier to pretend non ApiQuery derivatives actually are...
Daniel Friesen [Sun, 11 Dec 2011 19:49:16 +0000 (19:49 +0000)]
Follow up r105821, as usual, commit the files I forgot to `svn add`
Daniel Friesen [Sun, 11 Dec 2011 19:45:15 +0000 (19:45 +0000)]
Follow up r102210:
- Update maintenance/dev/ to install php inside ~/.mediawiki/php instead of ~/.mwphp
- Tweak README a bit
- Move the router.php into an includes along with two helper .sh files to cut out some of the repetition
Sam Reed [Sun, 11 Dec 2011 19:01:11 +0000 (19:01 +0000)]
* (bug 32414) Empty page get a empty bytes attribute in Export/Dump
Pushing the values through intval seems enough, null -> 0
reedy@fenari:/home/wikipedia/common$ mwscript eval.php dewiki
> $var = null;
> var_dump( intval( $var ) );
int(0)
> var_dump($var );
NULL
Sam Reed [Sun, 11 Dec 2011 18:51:44 +0000 (18:51 +0000)]
Fix use of undefined $file
Reduce code duplication in Dump7ZipOutput
Daniel Friesen [Sun, 11 Dec 2011 18:46:18 +0000 (18:46 +0000)]
Introduce a Language::getHtmlLang method which returns the Bcp47 formatted language code and update code around core to output lang tags using this method instead of getCode so that we properly output things like lang="en-CA" instead of lang="en-ca"
Sam Reed [Sun, 11 Dec 2011 18:39:31 +0000 (18:39 +0000)]
* (bug 32415) Empty page get no size attribute in API output
Daniel Friesen [Sun, 11 Dec 2011 18:25:23 +0000 (18:25 +0000)]
Update wfArrayToCGI and wfCgiToArray:
- 'foo' => '' now outputs "&foo=" instead of the key being omitted
- 'foo' => null and 'foo' => false now omit the key instead of outputting "&foo="
- Added a test to make sure that 'foo' => true outputs "&foo=1"
- Fixed a php notice caused when passing a =value-less bit like "&qwerty" to wfCgiToArray by treating it like php and extracting it as 'qwerty' => ''
- Updated tests
Max Semenik [Sun, 11 Dec 2011 16:56:37 +0000 (16:56 +0000)]
Added 1.18 schema to tests, comment
Sam Reed [Sun, 11 Dec 2011 16:37:20 +0000 (16:37 +0000)]
Fix double pasting from r105803
Sam Reed [Sun, 11 Dec 2011 16:35:50 +0000 (16:35 +0000)]
* (bug 31759) Undefined property notice in querypages API
Alexandre Emsenhuber [Sun, 11 Dec 2011 16:04:53 +0000 (16:04 +0000)]
Fix documentation of Title::userCan() and Title::quickUserCan() and added line breaks in Title::getUserPermissionsErrors()'s one
Sam Reed [Sun, 11 Dec 2011 15:31:17 +0000 (15:31 +0000)]
* (bug 32960) remove EmailAuthenticationTimestamp from database when a
email address is removed
In Preferences::trySetUserEmail no point trying to reset the users email if it's the same
Same for User::setEmail
After setting the email though, invalidate email auth tokens
Alexandre Emsenhuber [Sun, 11 Dec 2011 14:48:45 +0000 (14:48 +0000)]
Group related functions
Alexandre Emsenhuber [Sun, 11 Dec 2011 13:54:44 +0000 (13:54 +0000)]
Per Platonides, fix for r100445: make sure user's language is English so that it doesn't break test
Alexandre Emsenhuber [Sun, 11 Dec 2011 13:29:21 +0000 (13:29 +0000)]
Follow-up r105790: make tests work again
Derk-Jan Hartman [Sun, 11 Dec 2011 12:26:28 +0000 (12:26 +0000)]
Remove useless local var decl.
Alexandre Emsenhuber [Sun, 11 Dec 2011 11:30:11 +0000 (11:30 +0000)]
Moved view count from WikiPage to Title; avoids an extra DB query when showing the view count in SkinTemplate::outputPage() (since it's not the same WikiPage object)
Alexandre Emsenhuber [Sun, 11 Dec 2011 10:16:32 +0000 (10:16 +0000)]
Use ParserOptions::newFromContext() instead of 'new ParserOptions' to use the local context and not $wgUser or $wgLang
Siebrand Mazeland [Sun, 11 Dec 2011 10:11:56 +0000 (10:11 +0000)]
Remove no longer needed RELEASE-NOTES-1.18.
Alexandre Emsenhuber [Sun, 11 Dec 2011 09:44:02 +0000 (09:44 +0000)]
Use WikiPage instead of Article
Alexandre Emsenhuber [Sun, 11 Dec 2011 09:31:47 +0000 (09:31 +0000)]
Use local context to get messages
Derk-Jan Hartman [Sat, 10 Dec 2011 22:50:28 +0000 (22:50 +0000)]
Add unit test for bug 32888
Follow up r105727
Aaron Schulz [Sat, 10 Dec 2011 20:08:58 +0000 (20:08 +0000)]
* Fixed failing FlaggedRevs tests (one due global to leaks from a core test) and made it clean up the DB table afterwards
Alexandre Emsenhuber [Sat, 10 Dec 2011 20:03:19 +0000 (20:03 +0000)]
Use WikiPage instead of Article
Alexandre Emsenhuber [Sat, 10 Dec 2011 17:01:22 +0000 (17:01 +0000)]
Factorise calls to $this->getTitle() in SkinTemplate::outputPage()
Alexandre Emsenhuber [Sat, 10 Dec 2011 16:30:40 +0000 (16:30 +0000)]
* Added revision's timestamp to OutputPage along with revision ID; avoid a DB hit in Skin::lastModified() when showing parser cache's content. This changed with the removal of $wgArticle in Skin since now it's a different WikiPage object and thus WikiPage::setTimetstamp() call is useless (but still kept).
* Added ParserOutput::(get|set)Timestamp() and the $mTimestamp member; avoid messing with isset()
Alexandre Emsenhuber [Sat, 10 Dec 2011 15:44:44 +0000 (15:44 +0000)]
Do the "user is allowed to edit" check when checking for protect rights with the same level of expensiveness as for the protect checks and also do "quick" checks since we don't care about the message names. This avoids a DB query for cascading protection on each page view for users with protect right.
Alexandre Emsenhuber [Sat, 10 Dec 2011 15:25:28 +0000 (15:25 +0000)]
* Group related functions
* Expand functions that were all declared in one line for consistency
* Removed big "Static functions" and "Other stuff" comments that are just confusing
Alexandre Emsenhuber [Sat, 10 Dec 2011 09:35:03 +0000 (09:35 +0000)]
* Changed WikiPage::exists() to call Title::exists()
* Changed some getId() calls to exists() and call that method directly on $mTitle
Aaron Schulz [Sat, 10 Dec 2011 05:47:46 +0000 (05:47 +0000)]
FU r105154: only clear tables that tests specify as written to. This reduces the obnoxious slowness that was getting in the way of FileBackend testing.
Since previously (pre-r105154) nothing was cleared, tests should still work.
Derk-Jan Hartman [Fri, 9 Dec 2011 22:39:04 +0000 (22:39 +0000)]
Fix issue with sortable headers when nesting a table INSIDE a table header cell ?
Who comes up with these usecases ? :D
Fixes bug 32888
Raimond Spekking [Fri, 9 Dec 2011 20:31:37 +0000 (20:31 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Fri, 9 Dec 2011 20:13:31 +0000 (20:13 +0000)]
Added LoggableUserIPData hook to hooks.txt and made CheckUser handle it. This is needed for bug 32925.
Sam Reed [Fri, 9 Dec 2011 14:48:34 +0000 (14:48 +0000)]
Followup r105575, r105619, r105671 Add RELEASE-NOTES-1.19
Sam Reed [Fri, 9 Dec 2011 14:46:28 +0000 (14:46 +0000)]
1.8.17 also
Tim Starling [Fri, 9 Dec 2011 10:32:55 +0000 (10:32 +0000)]
* Revert r103476, r105161 and implement the fix for bug 32858 (a.k.a. bug 32450) in WikiPage instead. See comment 14 for further rationale.
* Clarified release notes. Please write what the new code does, not the bug description.
Tim Starling [Fri, 9 Dec 2011 09:32:15 +0000 (09:32 +0000)]
Fix for r102295 per CR r105654: don't double-escape the URL
Tim Starling [Fri, 9 Dec 2011 06:03:27 +0000 (06:03 +0000)]
Revert r102504 (allow ESC in debug output): the justification in the comment above seems very reasonable to me, and is in fact an argument for stripping only ESC, since that's the only character that can change terminal modes. You could always make a highlighter pipe script for your wfDebugGreen(), instead of tailing the log directly.
Tim Starling [Fri, 9 Dec 2011 05:54:26 +0000 (05:54 +0000)]
Fixes for r102295:
* Rename getDiffText to getDiffLink since that's what it actually gets. Fix associated variable names.
* Use Html::element() not Html::rawElement() when escaping is desired.
Tim Starling [Fri, 9 Dec 2011 05:37:57 +0000 (05:37 +0000)]
Fix comment from r102287
Tim Starling [Fri, 9 Dec 2011 05:22:39 +0000 (05:22 +0000)]
Fix message documentation from r102284
Neil Kandalgaonkar [Fri, 9 Dec 2011 04:48:39 +0000 (04:48 +0000)]
add JS api, feedback libs from UW into core.
Tim Starling [Fri, 9 Dec 2011 04:31:10 +0000 (04:31 +0000)]
Add a configuration variable to work around the issue that has been reported at least twice on IRC: pages from MW with a 404 status code have the last block of their body replaced, and their headers appended to, resulting in totally broken output for page views of non-existent pages. BizLand or some reseller is probably at fault.
Neil Kandalgaonkar [Fri, 9 Dec 2011 00:29:52 +0000 (00:29 +0000)]
add guaranteed-to-be-undefined undefined to mw object
Daniel Friesen [Fri, 9 Dec 2011 00:28:34 +0000 (00:28 +0000)]
Followup r104676, r104688:
- Update our woefully out of date doc comment for WebRequest::getPathInfo (we haven't simply been extracting a PATH_INFO for ages)
- Make PathRouter::makeWeight protected
- Add more comments to the PathRouter code
- Add two more edge case tests to the PathRouter tests.
Brion Vibber [Thu, 8 Dec 2011 23:57:24 +0000 (23:57 +0000)]
remove stray alert() from r105560 which popped up during test runs (bug 32884)
Sam Reed [Thu, 8 Dec 2011 23:54:06 +0000 (23:54 +0000)]
Update jquery.effects
Sam Reed [Thu, 8 Dec 2011 23:42:08 +0000 (23:42 +0000)]
* (bug 32879) Upgrade jQuery to 1.7.1
Tests in qunit still pass fine
Sam Reed [Thu, 8 Dec 2011 19:25:08 +0000 (19:25 +0000)]
Delete images not in 1.8.17 download of jQuery-ui
Sam Reed [Thu, 8 Dec 2011 19:17:59 +0000 (19:17 +0000)]
Update jQuery.ui from 1.8.16 to 1.8.17
Aaron Schulz [Thu, 8 Dec 2011 19:02:36 +0000 (19:02 +0000)]
Removed swift subclass comments from r99546 (that is an extension and it will be done differently as well)
Sam Reed [Thu, 8 Dec 2011 18:07:26 +0000 (18:07 +0000)]
Fix version check version from r105559
Antoine Musso [Thu, 8 Dec 2011 16:27:19 +0000 (16:27 +0000)]
basic tests for bug 8115
Sam Reed [Thu, 8 Dec 2011 16:18:18 +0000 (16:18 +0000)]
Bug 32874 - Bitmap.php uses -define in ImageMagick configuration line which requires ImageMagick 6.5.6-2 but doesn't do a version check
"Patch"/Idea provided by Christian Neubauer
Antoine Musso [Thu, 8 Dec 2011 15:24:12 +0000 (15:24 +0000)]
clean whitespaces in jquery.tablesorter.test.js
Antoine Musso [Thu, 8 Dec 2011 14:03:04 +0000 (14:03 +0000)]
clean some files when testing upload
This catch temporary uploaded files which are six characters long.
Follow-up r102458
Antoine Musso [Thu, 8 Dec 2011 13:02:34 +0000 (13:02 +0000)]
clean up whitespace / reindent
Antoine Musso [Thu, 8 Dec 2011 12:51:53 +0000 (12:51 +0000)]
purgeThumbList debug message is now a oneliner
Antoine Musso [Thu, 8 Dec 2011 10:04:59 +0000 (10:04 +0000)]
(bug 32508) clean up update.php messages
The user_options migration messages were not prefixed with '...' and
were split on several lines. This patch make the output messages more
inline with the existant ones.
Follow-up r103917
. <-- that is a patch of ink sorry. ><OO>
Niklas Laxström [Thu, 8 Dec 2011 09:48:04 +0000 (09:48 +0000)]
Followup r104300
Niklas Laxström [Thu, 8 Dec 2011 09:07:10 +0000 (09:07 +0000)]
Revert r97468 and implemented it in another way suggested by Tim
Niklas Laxström [Thu, 8 Dec 2011 08:51:21 +0000 (08:51 +0000)]
Gender is already needed in addResultToCache
Santhosh Thottingal [Thu, 8 Dec 2011 08:29:33 +0000 (08:29 +0000)]
Follow up r105517. Corrected the CSS.
Santhosh Thottingal [Thu, 8 Dec 2011 06:19:15 +0000 (06:19 +0000)]
Fix the line heights for Indic languages. Refer Bug 32826.
Grouped the elements based on language.
Aaron Schulz [Thu, 8 Dec 2011 04:58:26 +0000 (04:58 +0000)]
FU r105512: just always use thumb.php style errors
Aaron Schulz [Thu, 8 Dec 2011 03:43:07 +0000 (03:43 +0000)]
FU r101117: removed cURL thumb handler code and made thumb_handler.php a thin wrapper around thumb.php
* Moved original URL fetching code and parameter extraction code to thumb.php
* Made use of local repo URL and hash settings to avoid extra config code
* This makes it easy to add hooks for extensions/config to alter behavoir (ExtractThumbParameters hook added)
* Added FileRepo::getHashLevels()
Aaron Schulz [Thu, 8 Dec 2011 02:02:21 +0000 (02:02 +0000)]
FU r104688:
* Removed a bit of cruft in from a comment (c&p error)
* Clarified 'value' params comment (AFAIK)
* Broke some long lines and made some other w/s cleanups
Jeroen De Dauw [Wed, 7 Dec 2011 23:54:51 +0000 (23:54 +0000)]
add since tag; please do this if you add new public methods, it avoids bugs and hassle for other people
Antoine Musso [Wed, 7 Dec 2011 14:25:26 +0000 (14:25 +0000)]
(bug 32473) [[Special:PasswordReset]] can not be used on private wiki
This patch is a quick fix for REL1_18 branch.
For later:
We should not have hack in Title.php to allow some specific special pages
this should be made possible using SpecialPage. Would make code cleaner.
Antoine Musso [Wed, 7 Dec 2011 11:04:11 +0000 (11:04 +0000)]
(bug 32853) DBA cache broken in MW 1.18
DBABagOStuff was not refactored by r83140 which pass BagOStuff constructors
an array. This patch honor the 'dir' parameter to let you override the global
$wgTmpDirectory.
Need backport in REL1_18
Tim Starling [Tue, 6 Dec 2011 23:50:22 +0000 (23:50 +0000)]
It looks documented to me
Brion Vibber [Tue, 6 Dec 2011 23:40:44 +0000 (23:40 +0000)]
* (bug 32617) Fix for edit summary on section 0 containing a bogus section heading
Based on patch posted by Dan Collins: https://bugzilla.wikimedia.org/attachment.cgi?id=9552
with a tweak to avoid breaking a similar case in other sections. Follows up on function extraction & test cases added in r105379.
Brion Vibber [Tue, 6 Dec 2011 23:35:42 +0000 (23:35 +0000)]
For bug 32617: lift some code out to a function - EditPage::extractSectionTitle - so it can be tested and fixed.
Added test cases, including one that fails thus demonstrating bug 32617.
Chad Horohoe [Tue, 6 Dec 2011 23:07:13 +0000 (23:07 +0000)]
Minor tweaks to cleanSig(inSig)
* Make cleanSig public, since it's a declared entry point per class docs
* Make cleanSigInSig public static, added 2 more test cases for it
Chad Horohoe [Tue, 6 Dec 2011 23:06:50 +0000 (23:06 +0000)]
Indentation fix
Brion Vibber [Tue, 6 Dec 2011 22:37:38 +0000 (22:37 +0000)]
* (bug 32786) Fix backwards compatibility for extensions using 1.17's Database::newFromType()
Patch based on https://bugzilla.wikimedia.org/attachment.cgi?id=9604 by Solitarius -- thanks!
Added a conversion for a changed tablePrefix / tableprefix bit.
Raimond Spekking [Tue, 6 Dec 2011 21:36:57 +0000 (21:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Platonides [Tue, 6 Dec 2011 21:27:55 +0000 (21:27 +0000)]
Follow up r104314 as noted in bug 21261 comment 9
Brion Vibber [Tue, 6 Dec 2011 19:45:56 +0000 (19:45 +0000)]
Followup r104350, r104318: only allow custom limits through if they're valid positive ints.
Brion Vibber [Tue, 6 Dec 2011 19:32:29 +0000 (19:32 +0000)]
Revert r104353, r104354, r104356, r104358, r104383: changes to pagers breaking existing links as noted in CR.
Aaron Schulz [Tue, 6 Dec 2011 18:48:48 +0000 (18:48 +0000)]
Reverted r105208 per CR