Aaron Schulz [Thu, 9 Apr 2015 18:11:31 +0000 (11:11 -0700)]
Made deleteTagEverywhere use start/endAtomic()
Change-Id: I54b697bc8c0f84d49bfcc20ec2753e18d24bf988
jenkins-bot [Thu, 9 Apr 2015 15:28:23 +0000 (15:28 +0000)]
Merge "Add @group Database tags to tests that need it"
jenkins-bot [Thu, 9 Apr 2015 14:54:47 +0000 (14:54 +0000)]
Merge "Fixed ApiQueryBase::selectNamedDb() return value"
Marius Hoch [Thu, 9 Apr 2015 08:32:59 +0000 (10:32 +0200)]
Have phpunit.php exit with 1 in case it couldn't run the tests
Just makes more sense not to claim we could complete everything
if we actually couldn't.
Change-Id: I4ec3a2da8913ca546782919813eb18a05a5cca0a
Yuri Astrakhan [Thu, 9 Apr 2015 05:20:56 +0000 (01:20 -0400)]
Fixed ApiQueryBase::selectNamedDb() return value
The doc specifies that this func should return
named database connection, but it does not. Fixed.
Change-Id: Ibe62ff4275201382243c4861cc4fd15cf0316e43
jenkins-bot [Thu, 9 Apr 2015 00:46:24 +0000 (00:46 +0000)]
Merge "Use XML localName when importing"
jenkins-bot [Thu, 9 Apr 2015 00:45:08 +0000 (00:45 +0000)]
Merge "Set context earlier in ImageListPager::__construct"
jenkins-bot [Thu, 9 Apr 2015 00:45:04 +0000 (00:45 +0000)]
Merge "Skip file count on Special:Statistics when no files and no upload"
jenkins-bot [Thu, 9 Apr 2015 00:44:21 +0000 (00:44 +0000)]
Merge "PLURAL support for list lengths in default-skin-not-found"
jenkins-bot [Thu, 9 Apr 2015 00:41:20 +0000 (00:41 +0000)]
Merge "Add help link to three rather important pages"
jenkins-bot [Thu, 9 Apr 2015 00:32:46 +0000 (00:32 +0000)]
Merge "Added LogEntryBase::extractParams/makeParamBlob"
jenkins-bot [Thu, 9 Apr 2015 00:31:23 +0000 (00:31 +0000)]
Merge "Do not pass null to Title::newFromText in Special:MyLanguage"
jenkins-bot [Thu, 9 Apr 2015 00:26:54 +0000 (00:26 +0000)]
Merge "update.php: Correctly report durations >= 1 hour"
jenkins-bot [Wed, 8 Apr 2015 23:08:25 +0000 (23:08 +0000)]
Merge "Warn when jobs do large DB writes at once"
jenkins-bot [Wed, 8 Apr 2015 22:53:30 +0000 (22:53 +0000)]
Merge "Removed unusable maintenance script"
Aaron Schulz [Wed, 8 Apr 2015 22:47:58 +0000 (15:47 -0700)]
Warn when jobs do large DB writes at once
Change-Id: I57e9bb630accd5b262188ab16b17b558cd3a2bc1
Aaron Schulz [Wed, 8 Apr 2015 22:41:36 +0000 (15:41 -0700)]
Removed unusable maintenance script
* Change left out of
4bdbfe6c1b
Change-Id: I2169586742653d0b43e2f581f28f79af960e7ada
Roan Kattouw [Wed, 8 Apr 2015 21:55:44 +0000 (14:55 -0700)]
ApiParse: Replace isCurrent() check with getLatest() comparison
Because the $pageObj state is what actually ends up getting used.
If $pageObj thinks an old rev is the latest one, then we are in
trouble, even if $rev knows what's really going on.
Bug: T95466
Change-Id: I4d6ba4f18adaaad052d3bee1a575ba034aaf112b
Thiemo Mättig [Thu, 26 Mar 2015 09:47:30 +0000 (10:47 +0100)]
Add array type hints to minor methods in the Html class
I'm aware that adding these type hints does have the potential of beeing
a breaking change if a caller misuses it. Note that it really is a misuse
in this case because all these parameters are documented as "array" and
nothing else.
I double-checked the usages of all methods I touched and could not find
any caller that does not fulfill the contract of these methods - in other
words, all callers I can find in my local code base (which includes all
major extensions like Echo, Flow, Parsoid, VisualEditor and so on) pass
arrays to these parameters.
I left the main methods openElement, rawElement and so on untouched
because they are called way to often (500 times and more).
Change-Id: I5ca13b26fb08d732ce4cadc4ee3d38314e606fd3
jenkins-bot [Wed, 8 Apr 2015 20:25:47 +0000 (20:25 +0000)]
Merge "Set a query group on SpecialRecentChanges query"
Bartosz Dziewoński [Wed, 8 Apr 2015 20:02:40 +0000 (20:02 +0000)]
Merge "Partially revert increased wikitable padding"
jenkins-bot [Wed, 8 Apr 2015 19:38:09 +0000 (19:38 +0000)]
Merge "Made wfReadOnly() more robust at handling the lagged-slave case"
jenkins-bot [Wed, 8 Apr 2015 19:20:38 +0000 (19:20 +0000)]
Merge "Make RedisBagOStuff support tag name hashing"
jenkins-bot [Wed, 8 Apr 2015 19:20:30 +0000 (19:20 +0000)]
Merge "Made WikiPage::doPurge() avoid calling commit()"
jenkins-bot [Wed, 8 Apr 2015 19:20:21 +0000 (19:20 +0000)]
Merge "Use wfWaitForSlaves in upload stash cleanup script"
Translation updater bot [Wed, 8 Apr 2015 19:07:02 +0000 (21:07 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I52aa3fcab215c84aa499cf2c8f1ff67d3fff47c3
jenkins-bot [Wed, 8 Apr 2015 18:44:45 +0000 (18:44 +0000)]
Merge "Log huge write queries in CLI scripts"
jenkins-bot [Wed, 8 Apr 2015 18:44:40 +0000 (18:44 +0000)]
Merge "Made mergeActiveUsers use "recentchanges" query group"
Aaron Schulz [Tue, 7 Apr 2015 18:04:17 +0000 (11:04 -0700)]
Made wfReadOnly() more robust at handling the lagged-slave case
* Previously if it was called before a DB_SLAVE connection, it would not
be set. This is fixed now.
* Also set mLaggedSlaveMode in LoadBalancer as appropriate. Before, it
was only set in the "too lagged for ChronologyProtector" case.
Change-Id: Ic4dc555cf762653f157df1795f53f3577c1e587a
jenkins-bot [Wed, 8 Apr 2015 18:22:12 +0000 (18:22 +0000)]
Merge "Removed unused wgDBAvgStatusPoll var"
Chad Horohoe [Wed, 8 Apr 2015 17:46:34 +0000 (10:46 -0700)]
Fix I9e63789e: Release notes should refer to old versions in HISTORY
Change-Id: Ibedf45f4a0a5b16f8fa494412b471e266404d9b3
Aaron Schulz [Wed, 8 Apr 2015 17:33:58 +0000 (10:33 -0700)]
Made WikiPage::doPurge() avoid calling commit()
* Calling commit() can cause imbalanced begin/commit problems
Change-Id: I55fec065de20653b216c8dfac7c361124c8fe10a
jenkins-bot [Wed, 8 Apr 2015 17:31:10 +0000 (17:31 +0000)]
Merge "Made User::invalidateCache() use touch() instead of the DB query"
Aaron Schulz [Wed, 8 Apr 2015 16:35:56 +0000 (09:35 -0700)]
Prevent SiteStats::loadAndLazyInit from reloading in $wgMiserMode
* Large sites can use a chron to handle accumulated drift
Bug: T95426
Change-Id: I59603a7aa329a10f8a7e4d11f3496e8f8243ca42
Aaron Schulz [Wed, 8 Apr 2015 16:24:36 +0000 (09:24 -0700)]
Use wfWaitForSlaves in upload stash cleanup script
Bug: T95382
Change-Id: I8d93eb15064693634076e864ed6724392448cb45
Baha Man [Mon, 23 Mar 2015 23:11:21 +0000 (19:11 -0400)]
Track search events
Tracking works only for the skin-provided search box (top right search
box on desktop). Also, add the 'update' option the jQuery suggestions
extension.
Change-Id: Icc0afcd6c9fa8c82a95d9decf988a19ae3edc165
umherirrender [Wed, 8 Apr 2015 10:12:15 +0000 (12:12 +0200)]
Add test for IRC line for type protect/move_prot
All other log types already have a test, just move_prot is missing.
Change-Id: I97fdb21d3cb58847a883917b06294bc92dac9410
Aaron Schulz [Wed, 8 Apr 2015 01:11:29 +0000 (18:11 -0700)]
Log huge write queries in CLI scripts
* This is already done for web scripts, but with lower limits
Bug: T95382
Change-Id: I0fe14bcdaebc3568b0cb7af8084b7bfefeb82826
Aaron Schulz [Wed, 8 Apr 2015 02:58:40 +0000 (19:58 -0700)]
Made User::invalidateCache() use touch() instead of the DB query
* This method is used for clearing the User cache as well
as bumping the value of getTouched() for HTTP 304 logic.
These do not need to do the actual user_touched update.
* This also avoids problems with setting mTouched but
deferring the update. That confused the CAS update
logic since it expects mTouched to be in the DB.
Change-Id: I96b30f5c9c8b4714e6663b187f741954a13312cf
Kevin Israel [Mon, 26 May 2014 15:02:45 +0000 (11:02 -0400)]
update.php: Correctly report durations >= 1 hour
Bug: T67772
Change-Id: I61492a1ad8bf7f574b198af82799b030221bb58b
Aaron Schulz [Wed, 8 Apr 2015 00:31:11 +0000 (17:31 -0700)]
Made mergeActiveUsers use "recentchanges" query group
Change-Id: I9b91fe5d81f7315d531c48530cfbcf779f3adec2
Aaron Schulz [Wed, 8 Apr 2015 00:29:19 +0000 (17:29 -0700)]
Set a query group on SpecialRecentChanges query
Change-Id: I2525aa9d504027aec6bb3f83c8a48ce818e252cd
Aaron Schulz [Tue, 7 Apr 2015 22:25:03 +0000 (15:25 -0700)]
Removed unused wgDBAvgStatusPoll var
Change-Id: Ib1abf72add4d62bb41f1e2061caf9de0abd84e43
umherirrender [Sat, 28 Mar 2015 17:55:45 +0000 (18:55 +0100)]
Added LogEntryBase::extractParams/makeParamBlob
Centralize the serialize and unserialize call in the new logging system
into two functions to allow reuse by tests.
Change-Id: Ibedca39558cbd566661b20e7ebb9d2b6537e4f24
Chad Horohoe [Tue, 7 Apr 2015 20:48:23 +0000 (13:48 -0700)]
Begin 1.26 development cycle
Change-Id: I9e63789e7bbec95e72fca6dfc1a79f0ae1fba9b0
jenkins-bot [Tue, 7 Apr 2015 20:33:43 +0000 (20:33 +0000)]
Merge "mime.types: allow bzip2 upload"
jenkins-bot [Tue, 7 Apr 2015 20:10:25 +0000 (20:10 +0000)]
Merge "Remove form when including empty Special:WhatLinksHere"
jenkins-bot [Tue, 7 Apr 2015 20:10:21 +0000 (20:10 +0000)]
Merge "Kill Dwimmerlaik"
jenkins-bot [Tue, 7 Apr 2015 20:08:31 +0000 (20:08 +0000)]
Merge "Revert "Hide HHVM tag on Special:{Contributions,RecentChanges,...}""
jenkins-bot [Tue, 7 Apr 2015 20:02:31 +0000 (20:02 +0000)]
Merge "Made User::loadPasswords respect "queryFlagsUsed""
Translation updater bot [Tue, 7 Apr 2015 19:52:45 +0000 (19:52 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Tue, 7 Apr 2015 19:51:09 +0000 (21:51 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I59a85ff5f09d46967e59feb3c65d76f1d04ec84d
jenkins-bot [Tue, 7 Apr 2015 19:43:41 +0000 (19:43 +0000)]
Merge "Mostly revert "Verify parameter for MapCacheLRU::has() can be passed to array_key_exists()""
Aaron Schulz [Tue, 7 Apr 2015 19:12:23 +0000 (12:12 -0700)]
Made User::loadPasswords respect "queryFlagsUsed"
* Also cleaned up a few var names
Change-Id: I3a835e3980dfc3205716cf5bb1a4c04aa037f36d
Legoktm [Tue, 7 Apr 2015 18:19:23 +0000 (18:19 +0000)]
Revert "Hide HHVM tag on Special:{Contributions,RecentChanges,...}"
This reverts commit
494989772cfce8805a10c2cd497880f6f6793896.
Bug: T1205
Change-Id: If47af4a663530d9a32c1d24b6b55a63954f53fcb
Aaron Schulz [Thu, 19 Mar 2015 18:42:48 +0000 (11:42 -0700)]
Fixed bug where catching DB errors left ignoreErrors() on
* Also fixed an actual rollback loop possible in postgres
Change-Id: I41508127f74e1bbee4c020546fed85ab53318ab7
jenkins-bot [Tue, 7 Apr 2015 17:11:40 +0000 (17:11 +0000)]
Merge "Report correct rev_id in missing-revision message"
jenkins-bot [Tue, 7 Apr 2015 16:18:19 +0000 (16:18 +0000)]
Merge "convertExtensionToRegistration: Still convert $wgTrackingCategories"
jenkins-bot [Tue, 7 Apr 2015 16:14:38 +0000 (16:14 +0000)]
Merge "mergeMessageFileList: Support reading extension/skin.json files"
jenkins-bot [Tue, 7 Apr 2015 16:14:35 +0000 (16:14 +0000)]
Merge "installer: Read from extension.json if possible"
jenkins-bot [Tue, 7 Apr 2015 16:14:02 +0000 (16:14 +0000)]
Merge "LocalFileTest does not require database access"
jenkins-bot [Tue, 7 Apr 2015 16:13:56 +0000 (16:13 +0000)]
Merge "SearchUpdateTest does not require database access"
jenkins-bot [Tue, 7 Apr 2015 16:13:51 +0000 (16:13 +0000)]
Merge "registration: Make it easier for other code to get extension metadata"
jenkins-bot [Tue, 7 Apr 2015 16:13:48 +0000 (16:13 +0000)]
Merge "registration: Support 'namemsg'"
jenkins-bot [Tue, 7 Apr 2015 16:13:41 +0000 (16:13 +0000)]
Merge "registration: Support ResourceModuleSkinStyles"
jenkins-bot [Tue, 7 Apr 2015 16:12:54 +0000 (16:12 +0000)]
Merge "Add special pages aliases for Western Balochi (bgn) from translatewiki"
jenkins-bot [Tue, 7 Apr 2015 15:59:59 +0000 (15:59 +0000)]
Merge "Fix description for MessagesBgn.php"
jenkins-bot [Tue, 7 Apr 2015 15:43:43 +0000 (15:43 +0000)]
Merge "Added CAS-style logic to User::saveSettings as a final sanity check"
Kunal Mehta [Thu, 2 Apr 2015 17:15:43 +0000 (10:15 -0700)]
registration: Support 'namemsg'
Change-Id: I0f446b31c1d36a492997ef31fae6d2d2bea36517
Kunal Mehta [Thu, 2 Apr 2015 17:12:52 +0000 (10:12 -0700)]
registration: Support ResourceModuleSkinStyles
Structurally, it's set up exactly the same as ResourceModules, so we can
re-use the same code.
Bug: T91566
Change-Id: I7cd1330edc3e97b4658c81aac67071a90ac61fb6
jenkins-bot [Tue, 7 Apr 2015 15:40:48 +0000 (15:40 +0000)]
Merge "resourceloader: Require $wgResourceModuleSkinStyles paths to be in the base definition"
Brad Jorsch [Tue, 7 Apr 2015 15:11:21 +0000 (11:11 -0400)]
Report correct rev_id in missing-revision message
When trying to fetch the current revision, it currently always reports
"0" even when it's trying to fetch some other revision.
Bug: T92046
Change-Id: Ia5eb73ac32de0f654ac28ee929d5c4dda71c2f1b
jenkins-bot [Tue, 7 Apr 2015 12:01:40 +0000 (12:01 +0000)]
Merge "Make {{int:emailuserfooter}} use {{int:emailpage}} in the quotes"
Niklas Laxström [Tue, 7 Apr 2015 10:45:47 +0000 (12:45 +0200)]
Do not pass null to Title::newFromText in Special:MyLanguage
This currently breaks phpunit integration test in Translate.
Change-Id: Ibdc04e9e20c0264076d7a8766ac9a4826033371e
jenkins-bot [Tue, 7 Apr 2015 10:03:02 +0000 (10:03 +0000)]
Merge "Made Block::insert handle expired rows"
jenkins-bot [Tue, 7 Apr 2015 09:54:14 +0000 (09:54 +0000)]
Merge "Removed "page-lastedit" cache key trick from WikiPage"
jenkins-bot [Tue, 7 Apr 2015 09:44:59 +0000 (09:44 +0000)]
Merge "Log when User::saveSettings is called in read-only mode"
jenkins-bot [Tue, 7 Apr 2015 09:29:54 +0000 (09:29 +0000)]
Merge "Made replaceSectionContent try to use DB_SLAVE"
jenkins-bot [Tue, 7 Apr 2015 08:53:49 +0000 (08:53 +0000)]
Merge "Avoid master queries on SpecialBlockList"
jenkins-bot [Tue, 7 Apr 2015 08:17:57 +0000 (08:17 +0000)]
Merge "Avoid DB_MASTER in replaceSectionAtRev()"
jenkins-bot [Tue, 7 Apr 2015 08:00:02 +0000 (08:00 +0000)]
Merge "Made getWatchlistInfo use DB_SLAVE"
Aaron Schulz [Mon, 30 Mar 2015 21:44:50 +0000 (14:44 -0700)]
Removed "page-lastedit" cache key trick from WikiPage
* Just rely on chronology protected and edit conflict handling.
The time a user spends looking at and editing pages is larger
than any normal slave lag anyway.
* However make sure that pages just made in the request are visible.
* In "master" datacenters, the slave lag will low anyway, and
callers make use of $flags when needed. In other datacenters,
the cache will itself be subject to lag anyway.
* Logging (DBPerformance log) shows this case is very rarely
hit anyway.
Change-Id: If34d67c02f9a7bf0a506ee8f3990697eb403a710
Aaron Schulz [Tue, 7 Apr 2015 06:52:34 +0000 (23:52 -0700)]
Make RedisBagOStuff support tag name hashing
Bug: T95126
Change-Id: I266dd30c93cfc44395eba5bca64f451ca77c23a4
jenkins-bot [Tue, 7 Apr 2015 06:37:08 +0000 (06:37 +0000)]
Merge "Output converted namespace name in nstab when nstab-* is not defined"
jenkins-bot [Tue, 7 Apr 2015 06:27:16 +0000 (06:27 +0000)]
Merge "Fix list=logevents for new revision delete log entries"
Kevin Israel [Tue, 31 Mar 2015 17:42:32 +0000 (13:42 -0400)]
Allow setting anonnotice to "" to prevent fallback to sitenotice
Previously we only used Message::isDisabled (non-existent, empty string,
or "-") to decide whether to show a notice. If 'anonnotice' was disabled
'sitenotice' was shown instead.
When addressing logged-in users only, wikis typically use 'sitenotice'
and then put invisible content in 'anonnotice' (so that it shadows the
'sitenotice'). Now that the DismissableSiteNotice extension supports
closing of the notice for anonymous users (as of I87df3301c), this
becomes problematic as it has no way of knowing the notice was meant to
be invisible (and thus renders bogus "[close]" to all users).
This supersedes hacks such as <p></p> or <span></span>. Instead, the
empty string can now be used to have no anonnotice content, but also
don't show the 'sitenotice'.
Disabling with '-' (default) can still used to fallback to 'sitenotice'.
Also changed the code to, for consistency, allow hiding $wgSiteNotice
for all users by setting the sitenotice message to "-".
Bug: T94536
Change-Id: I11b8b883d480d0e07d8b395dd92360cb15de7c5b
Alex Monk [Tue, 7 Apr 2015 01:41:33 +0000 (01:41 +0000)]
Mostly revert "Verify parameter for MapCacheLRU::has() can be passed to array_key_exists()"
This broke a few things, and the debug line was basically pointless.
Instead, continue to only throw an exception if $text is an object, but only
warn if it's otherwise not a string.
This reverts commit
372ded2fea436bf0e61318991f903d61bde26366.
Change-Id: I060da9191cdbd00c4873caba875bfb77c917bcd7
jenkins-bot [Tue, 7 Apr 2015 01:19:36 +0000 (01:19 +0000)]
Merge "Fix param order of a Title::newFromText call in MediaWiki"
jenkins-bot [Tue, 7 Apr 2015 01:03:42 +0000 (01:03 +0000)]
Merge "MessagePoster followup: Dependency and docs"
Alex Monk [Tue, 7 Apr 2015 01:01:45 +0000 (02:01 +0100)]
Fix param order of a Title::newFromText call in MediaWiki
Otherwise it throws an exception on the latest master (I2b36b7a3)
I'm kind of surprised this didn't break when it was introduced in I60f44a10
Change-Id: I62f12aa9267d0812c3689064f512298187ac3c84
Matthew Flaschen [Mon, 6 Apr 2015 23:31:54 +0000 (16:31 -0700)]
MessagePoster followup: Dependency and docs
* WikitextMessagePoster depends on mediawiki.messagePoster
* Tweak how promises are documented
Change-Id: Ie48bde9d5995e86f22744d6b6f3773d125ccb1b0
Aaron Schulz [Mon, 6 Apr 2015 23:22:10 +0000 (16:22 -0700)]
Made replaceSectionContent try to use DB_SLAVE
Bug: T92357
Change-Id: I1626280c863a46d49215cc384e207458b2f8ec39
Aaron Schulz [Mon, 6 Apr 2015 23:07:08 +0000 (16:07 -0700)]
Avoid DB_MASTER in replaceSectionAtRev()
Bug: T92357
Change-Id: Iac4511176b5c70e9deaf71302bc1866b8b1a241a
Kunal Mehta [Mon, 6 Apr 2015 22:31:31 +0000 (15:31 -0700)]
resourceloader: Require $wgResourceModuleSkinStyles paths to be in the base definition
No skin in gerrit uses the feature of per-module local or remote paths,
and not supporting it will make implementing extension/skin.json support
easier.
Change-Id: I22863ef29426dbacd65439a12aeae56d4d757951
Aaron Schulz [Mon, 6 Apr 2015 22:19:56 +0000 (15:19 -0700)]
Avoid master queries on SpecialBlockList
* Filter out expired rows and rely on the insert() pruning
to keep the table size reasonable.
Bug: T92357
Change-Id: Icdbd606979d3d9ce9b2d923f574447e3e7dd72f7
jenkins-bot [Mon, 6 Apr 2015 22:14:11 +0000 (22:14 +0000)]
Merge "Add pluggable talk page poster and use it for mediawiki.feedback"
Aaron Schulz [Mon, 6 Apr 2015 22:13:07 +0000 (15:13 -0700)]
Made Block::insert handle expired rows
Bug: T90780
Change-Id: Ife9bcc0ec329156dac0bd033de35b25430234764
Aaron Schulz [Mon, 6 Apr 2015 21:48:31 +0000 (14:48 -0700)]
Made getWatchlistInfo use DB_SLAVE
Bug: T92357
Change-Id: I3b7d5d20d3028e15651dbca453a8bc47010b8194
Matthew Flaschen [Tue, 31 Mar 2015 03:28:11 +0000 (23:28 -0400)]
Add pluggable talk page poster and use it for mediawiki.feedback
The core implementation will only support wikitext.
Flow will add its own implementation, and it can be used for any talk
page system identifiable by content model.
Bug: T91805
Change-Id: Ic69acafb24aa737536fe3a074e1958690732f0a7
jenkins-bot [Mon, 6 Apr 2015 20:44:54 +0000 (20:44 +0000)]
Merge "Some cleanups to MWExceptionHandler::handleException"