Roan Kattouw [Wed, 13 Jul 2011 00:03:27 +0000 (00:03 +0000)]
Now that wfParseUrl() can handle protocol-relative URLs, make wfExpandUrl() work in cases where it's fed a protocol-relative URL and $wgServer is also protocol-relative.
Roan Kattouw [Tue, 12 Jul 2011 23:52:43 +0000 (23:52 +0000)]
Extend wfParseUrl() to handle protocol-relative URLs. parse_url() doesn't handle these either so it needs more workaround logic
Aaron Schulz [Tue, 12 Jul 2011 22:04:21 +0000 (22:04 +0000)]
Fixed r92012 comment
Aaron Schulz [Tue, 12 Jul 2011 21:58:23 +0000 (21:58 +0000)]
* Made (un)watch action show a form if the token is bad/missing (this handles unwatch links given in emails)
* Changed misleading watch/unwatch subtitle msgs
Robin Pepermans [Tue, 12 Jul 2011 21:28:44 +0000 (21:28 +0000)]
Do r91966 in a different way, per Brion: use unicode-bidi:embed; instead of white-space:nowrap;
Robin Pepermans [Tue, 12 Jul 2011 21:15:09 +0000 (21:15 +0000)]
Fix r91772: left should be right (copy-paste error)
Ian Baker [Tue, 12 Jul 2011 21:11:43 +0000 (21:11 +0000)]
Refactored UploadStash and related classes to use the database for file metadata storage instead of the session, see bug 26179
Tweaked the UploadWizard to work properly with the new backend code, updated tests
Roan Kattouw [Tue, 12 Jul 2011 20:56:56 +0000 (20:56 +0000)]
Parser tests for protocol-relative URLs, for r91663 and r92005
Roan Kattouw [Tue, 12 Jul 2011 20:55:05 +0000 (20:55 +0000)]
Fix r14202 (!!): this validates the protocol against the regex for the second time (preg_split has already made sure it matches wfUrlProtocols() so no need), and uses strpos() to validate against a regex (that's just wrong). I'm removing it not because it's useless but because it breaks for URL protocols that don't contain a ':' ('//' in my case) for no reason at all. Found out about this when writing parser tests for it (will commit these in a minute), so yay tests!
Aaron Schulz [Tue, 12 Jul 2011 20:32:09 +0000 (20:32 +0000)]
Follow-up r91997, moved newFromTitle() function to WikiPage.php and renamed to factory(). This avoids an extra class.
Raimond Spekking [Tue, 12 Jul 2011 20:05:07 +0000 (20:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-12 19:38:00 UTC)
Aaron Schulz [Tue, 12 Jul 2011 20:05:02 +0000 (20:05 +0000)]
Fixed failing XML tests (on windows) due to newline vs carriage return discrepancy...ugh
Sam Reed [Tue, 12 Jul 2011 19:59:35 +0000 (19:59 +0000)]
Documentation
Mark A. Hershberger [Tue, 12 Jul 2011 19:09:20 +0000 (19:09 +0000)]
followup r91985 — remove duplication of code per ^demon's suggestion.
Mark A. Hershberger [Tue, 12 Jul 2011 18:44:15 +0000 (18:44 +0000)]
Bug #29807 — Special:PasswordReset listed on Special:SpecialPages when Authplugin allowPasswordChange() is false
After my spanking last week, I've gone over the patch more closely this time.
Mark A. Hershberger [Tue, 12 Jul 2011 18:22:53 +0000 (18:22 +0000)]
eol w/s before commiting real patch
Chad Horohoe [Tue, 12 Jul 2011 18:02:16 +0000 (18:02 +0000)]
Followup r91832: move maintenance script from core to Renameuser extension.
Aaron Schulz [Tue, 12 Jul 2011 18:01:16 +0000 (18:01 +0000)]
Added WikiPageFactory class with newFromTitle() function
Alexandre Emsenhuber [Tue, 12 Jul 2011 17:22:23 +0000 (17:22 +0000)]
* Added token to watch links
* Call Linker methods statically
Brion Vibber [Tue, 12 Jul 2011 17:21:15 +0000 (17:21 +0000)]
Revert r91973 " Bug 24254: Output JS var wgCategories on other actions than view as well"
This code just looks really wrong -- it seems to be stuffing things into OutputPage::getCategories() which seems clearly designed to only return a set of categories that have been previously set by something else; rather than a lazy loader it also seems to fetch them every time. Nor does it even check if the article exists before loading from the DB -- and in general it looks like it doesn't really fit in with other code. It also only lists itself as altering wgCategories, but it's changing what's in the OutputPage itself so this may affect other things.
Leo Koppelkamm [Tue, 12 Jul 2011 16:53:46 +0000 (16:53 +0000)]
Bug 24254: Output JS var wgCategories on other actions than view as well. Bug 24254
Alexandre Emsenhuber [Tue, 12 Jul 2011 15:38:07 +0000 (15:38 +0000)]
* In EditPage.php: don't add the separator if getCancelLink() returns an empty string
* In TalkHere extension: override getCancelLink() instead of having mangleEditForm() hack
Ariel Glenn [Tue, 12 Jul 2011 15:01:58 +0000 (15:01 +0000)]
libxml >= 2.7.3 ha a 10mb cap on the size of a text node and the LIBXML_PARSEHUGE lets us override that, needed for lucid since there are a few revs in the db larger than that limit
Robin Pepermans [Tue, 12 Jul 2011 14:58:58 +0000 (14:58 +0000)]
(bug 12205) Bidirectional names in action=credits are split and displayed incorrectly when wrapped to the next line.
Alexandre Emsenhuber [Tue, 12 Jul 2011 12:42:57 +0000 (12:42 +0000)]
Use createContext() instead of using the global context
Alexandre Emsenhuber [Tue, 12 Jul 2011 12:35:06 +0000 (12:35 +0000)]
Use the local context instead of global variables
Leo Koppelkamm [Tue, 12 Jul 2011 11:53:58 +0000 (11:53 +0000)]
Revert r91942, r91943 & reimplement. wgActions doesn't contain all possible actions!
Leo Koppelkamm [Tue, 12 Jul 2011 10:19:08 +0000 (10:19 +0000)]
r91943. Add global.
Leo Koppelkamm [Tue, 12 Jul 2011 09:58:15 +0000 (09:58 +0000)]
r91942: Add nosuchaction also if action not in
Leo Koppelkamm [Tue, 12 Jul 2011 09:42:07 +0000 (09:42 +0000)]
Followup r91871 per CR. Write back the actually executed action to . Ping r57415
Tim Starling [Tue, 12 Jul 2011 08:08:58 +0000 (08:08 +0000)]
Non-concurrent pop_type() since the $row === false case was being hit 99% of the time on WMF in a backlog situation.
Brion Vibber [Tue, 12 Jul 2011 00:25:20 +0000 (00:25 +0000)]
Followup r91833 -- use Sanitizer::escapeId's 'noninitial' option when generating sanitized ID for a sidebar entry; the actual id is prefixed with 'n-'; this fix makes the items behave like the folder sections ('p-', already escaped this way)
Aaron Schulz [Tue, 12 Jul 2011 00:09:37 +0000 (00:09 +0000)]
Added $wgAutopromoteOnceLogInRC variable (bug 29655)
Brion Vibber [Mon, 11 Jul 2011 23:51:21 +0000 (23:51 +0000)]
followup r91869: validate id chars for incoming prefs tabs in hash ([\w-]+ is sufficient for our needs here)
Brion Vibber [Mon, 11 Jul 2011 23:41:49 +0000 (23:41 +0000)]
Revert r91870, r91873 -- seems to be trying to remove the 'view' action on diff views; diffs are a subset of regular page views, like old page views, and don't have a separate action.
Aaron Schulz [Mon, 11 Jul 2011 22:17:15 +0000 (22:17 +0000)]
Added explicit parse() call to wfMessage object
Brion Vibber [Mon, 11 Jul 2011 21:39:06 +0000 (21:39 +0000)]
Followup to r91608: reduce impact of bug 29784 (high jsmin+ memory usage during parsing) by skipping JS validation on modules backed by files. Unless you're developing them, these will usually be stable, and large individual files like the pre-bundled jQuery can hit memory limits much sooner than we like.
Validation on JS from wiki pages is still on by default ($wgResourceLoaderValidateJS = true).
Validation on static files can be re-enabled by setting $wgResourceLoaderValidateStaticJS = true (defaults false).
Brion Vibber [Mon, 11 Jul 2011 21:09:45 +0000 (21:09 +0000)]
Add jsparse.php maintenance script to run given JavaScript files through JSMin+'s JS parser for syntax validity checks.
This also confirms JSMin+'s fairly abysmal memory usage on large complex files. :) Pass --memory-limit to set to arbitrary values to see where it dies on your file. ;)
Raimond Spekking [Mon, 11 Jul 2011 19:37:00 +0000 (19:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-11 19:26:00 UTC)
Bryan Tong Minh [Mon, 11 Jul 2011 18:38:26 +0000 (18:38 +0000)]
Follow-up r91895: Call parent destructor as well, just to be safe.
Bryan Tong Minh [Mon, 11 Jul 2011 18:36:29 +0000 (18:36 +0000)]
Add unit tests for $wgGroupPermissions/$wgRevokePermissions
Brion Vibber [Mon, 11 Jul 2011 18:14:33 +0000 (18:14 +0000)]
Followup r91844: fix jquery.byteLimit test cases on IE6, IE7
str[i] doesn't work on these older browsers; use str.charAt(i) instead.
Niklas Laxström [Mon, 11 Jul 2011 18:05:32 +0000 (18:05 +0000)]
ping r91875
Brion Vibber [Mon, 11 Jul 2011 17:53:52 +0000 (17:53 +0000)]
* (bug 29804) Fix byte-length-limited fields to check the length of to-be-added char instead of hardcoding a possible length of 3.
Since the Unicode code point of the character being inserted is passed with the keypress event, we can simply turn it into a string and toss it into jquery.byteLength to calculate the length in bytes.
Also fixed a broken test case that had the wrong number of expected chars.
Note that this will probably still not work right in many circumstances -- pastes, anything dealing with selection, and it's entirely possible that individual 'keypress' events might be totally unreliable when dealing with funky input methods.
Robin Pepermans [Mon, 11 Jul 2011 17:01:44 +0000 (17:01 +0000)]
Jarry1250 = Harry Burt, per Reedy on r91886
Robin Pepermans [Mon, 11 Jul 2011 16:53:31 +0000 (16:53 +0000)]
(bug 29797) Error: "Tried to load block with invalid type" when subpages are disabled for user pages.
Patch by Jarry1250
Brian Wolff [Mon, 11 Jul 2011 16:42:15 +0000 (16:42 +0000)]
(follow-up r90256) Unit tests.
Niklas Laxström [Mon, 11 Jul 2011 12:23:39 +0000 (12:23 +0000)]
* (bug 16699) {{#language:}} accepts second parameter to specify the language in
which the language name is wanted. Coverage depends on the cldr extension.
Leo Koppelkamm [Mon, 11 Jul 2011 11:05:24 +0000 (11:05 +0000)]
r91870 : Got tricked into believing it was action=diff instead of action=historysubmit
Leo Koppelkamm [Mon, 11 Jul 2011 10:57:01 +0000 (10:57 +0000)]
Add action-* class to body. Bug 4438. Based on patch by Subfader
Leo Koppelkamm [Mon, 11 Jul 2011 10:54:05 +0000 (10:54 +0000)]
wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a &action parameter. Bug 25800
Leo Koppelkamm [Mon, 11 Jul 2011 09:54:40 +0000 (09:54 +0000)]
use tab name, not tab index for anchors on Special:Preferences. Bug 29672 . Patch by Jarry1250. Ping r91757
Alexandre Emsenhuber [Mon, 11 Jul 2011 08:46:37 +0000 (08:46 +0000)]
Call Linker methods statically and removed the $mSkin member
Alexandre Emsenhuber [Mon, 11 Jul 2011 08:27:07 +0000 (08:27 +0000)]
Override UsersPager::getTitle() in ActiveUsersPager
Alexandre Emsenhuber [Mon, 11 Jul 2011 08:17:26 +0000 (08:17 +0000)]
Use getPageTitle() to set the page title instead of doing it manually
Alexandre Emsenhuber [Mon, 11 Jul 2011 07:56:22 +0000 (07:56 +0000)]
Removed print and render actions from the check:
* print was removed in 86373
* render does not reach this point since it simply output the content without any part of the skin
Robin Pepermans [Mon, 11 Jul 2011 00:39:41 +0000 (00:39 +0000)]
BetterDirectionality fixes:
* SkinTemplate: also set <div class="mw-content-ltr/rtl"> when action = historysubmit, so a diff displays correctly when you clicked on the "compare selected revisions" button on the history page
* ImagePage: set a dir attribute (according to the site content language) for the user comment in the file history
* FlaggedRevs: use CSS class sitedir-ltr/rtl instead of ambiguous rtl class
Sam Reed [Sun, 10 Jul 2011 23:26:13 +0000 (23:26 +0000)]
Amend RELEASE-NOTES-1.19 for r91845
Krinkle [Sun, 10 Jul 2011 21:17:28 +0000 (21:17 +0000)]
Update jQuery from 1.6.1 to 1.6.2 (maintenance/bugfix release)
* Release notes: http://blog.jquery.com/2011/06/30/jquery-162-released/
* Source: http://code.jquery.com/jquery-1.6.2.js
* Requested in bug 29773
Krinkle [Sun, 10 Jul 2011 21:01:24 +0000 (21:01 +0000)]
Add test suite for jquery.byteLimit:
- Tests to verify that the byteLength does not exceed the byteLimit when inserting more characters
- Tests to verify that it doesn't prevent too early (ie. if limit is 10 and we insert 20 characters, there should be 10 characters in the input field).
This test suite has exposed that the latter is currently broken. jquery.byteLimit is preventing characters to be added as soon as byteLength(currentValue) + 3 is more than the given limit.
(Follows-up r86698, r91148)
Krinkle [Sun, 10 Jul 2011 19:10:51 +0000 (19:10 +0000)]
Centralize QUnit customizations for MediaWiki:
- Rename 'awesome.js' to 'defineTestCallback.js' (more descriptive)
- Move all runner customizations into 'testrunner.js'
- Move all customization files into /data
- Fix bug in jquery.qunit.completenesstest that sometimes caused the element to be re-created if it was ran again from the console.
- Centralize additional assertion helpers in testrunner.js
Alexandre Emsenhuber [Sun, 10 Jul 2011 18:12:11 +0000 (18:12 +0000)]
* Changed dynamic calls to Linker methods into static ones
* Also preferably pass a Language object instead of a Skin one or boolean indicating whether it's for content. No other calls to these methods in core or extensions.
Rotem Liss [Sun, 10 Jul 2011 17:48:44 +0000 (17:48 +0000)]
Localization update for he.
Krinkle [Sun, 10 Jul 2011 15:27:31 +0000 (15:27 +0000)]
Removing @broken comment. Not anymore, they don't as of r91388.
- (Follows-up 91387)
Leo Koppelkamm [Sun, 10 Jul 2011 14:56:55 +0000 (14:56 +0000)]
Escape sidebar ID's. Bug 18688
Ariel Glenn [Sun, 10 Jul 2011 14:20:17 +0000 (14:20 +0000)]
fix issues after failed renameUser; this script will ask for lots of confirmation, better safe than sorry.
Leo Koppelkamm [Sun, 10 Jul 2011 13:19:19 +0000 (13:19 +0000)]
Add a font-size to .redirectText in Vector and fix the vertical alignment of the arrow. Bug 26544
Alexandre Emsenhuber [Sun, 10 Jul 2011 07:33:29 +0000 (07:33 +0000)]
Disable feed mode when including the page. I know that there is already r87705 to address this, but this one is needed for the future.
Alexandre Emsenhuber [Sun, 10 Jul 2011 06:45:40 +0000 (06:45 +0000)]
Stylised ParserOptions.php
Robin Pepermans [Sat, 9 Jul 2011 21:13:57 +0000 (21:13 +0000)]
Bug 29792: notice undefined index 'other' due to my commit r91803
Raimond Spekking [Sat, 9 Jul 2011 20:12:43 +0000 (20:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-09 19:33:00 UTC)
Alexandre Emsenhuber [Sat, 9 Jul 2011 19:38:58 +0000 (19:38 +0000)]
Added Request::setLang() and RequestContext::setSkin(); the latter will clone the object and set the context on it.
Robin Pepermans [Sat, 9 Jul 2011 19:33:58 +0000 (19:33 +0000)]
Allow the 'other' parameter for HTMLForm selectorother: it is used in SpecialBlock.php::getFormFields() (and maybe in more files)
Alexandre Emsenhuber [Sat, 9 Jul 2011 18:57:33 +0000 (18:57 +0000)]
Call doMarkPatrolled() on the RecentChange object instead of calling RecentChange::markPatrolled() that will create a second instance
Robin Pepermans [Sat, 9 Jul 2011 12:54:42 +0000 (12:54 +0000)]
Follow-up r91770: only translate when possible
Bryan Tong Minh [Sat, 9 Jul 2011 10:31:09 +0000 (10:31 +0000)]
Follow-up r88054: register the file if a hook changed the target file.
Alexandre Emsenhuber [Sat, 9 Jul 2011 09:17:35 +0000 (09:17 +0000)]
Pass the User object to RecentChange::doMarkPatrolled() instead of relying on $wgUser
Alexandre Emsenhuber [Sat, 9 Jul 2011 09:01:50 +0000 (09:01 +0000)]
Fix for r91651: don't escape HTML
Sam Reed [Sat, 9 Jul 2011 03:49:25 +0000 (03:49 +0000)]
Fix whitespace, documentation
Sam Reed [Sat, 9 Jul 2011 03:47:43 +0000 (03:47 +0000)]
* (bug 28630) Add iwlinks, langlinks, redirect to RefreshLinks::deleteLinksFromNonexistent
Sam Reed [Sat, 9 Jul 2011 03:43:22 +0000 (03:43 +0000)]
Followup r86183 and per bug 28628
Might awell make refreshLinks remove dead iwlinks from the table
Robin Pepermans [Sat, 9 Jul 2011 01:03:48 +0000 (01:03 +0000)]
Inline CSS is bad in itself and bad for RTL support (why was there even a message containing CSS?)
Robin Pepermans [Fri, 8 Jul 2011 23:36:35 +0000 (23:36 +0000)]
Translate the block expiry date
I wonder why this hasn't been done yet...
Chad Horohoe [Fri, 8 Jul 2011 22:15:29 +0000 (22:15 +0000)]
Wow major typo, r91763
Chad Horohoe [Fri, 8 Jul 2011 22:08:19 +0000 (22:08 +0000)]
Use estimateRowCount() in CleanupTable rather than select count(*) which will take forevvvveeeerrrrr on tables like image or page. It's only used for estimating progress, so a little estimating is ok :)
Krinkle [Fri, 8 Jul 2011 21:32:30 +0000 (21:32 +0000)]
Undo browser defaults (underline/strike) for the <del> and <ins> DairikiDiff inserts. Fixes bug 29779
Krinkle [Fri, 8 Jul 2011 21:29:24 +0000 (21:29 +0000)]
Reverting r91756 per CR and bug 26470
Krinkle [Fri, 8 Jul 2011 21:28:54 +0000 (21:28 +0000)]
Selfrevert r91759. Messed up working-copy
Krinkle [Fri, 8 Jul 2011 21:27:44 +0000 (21:27 +0000)]
Reverting r91756 per CR and bug 26470
Leo Koppelkamm [Fri, 8 Jul 2011 21:12:10 +0000 (21:12 +0000)]
HTMLForm: Add option to output a title for a fieldset & activate it for Special:Pref. Preliminary work for Bug 29672
Leo Koppelkamm [Fri, 8 Jul 2011 20:34:08 +0000 (20:34 +0000)]
Bug 26470 : Add checkered background image for transparent images on hover
Leo Koppelkamm [Fri, 8 Jul 2011 20:17:46 +0000 (20:17 +0000)]
redoing r91673 . Second step: Actually moving the files
Leo Koppelkamm [Fri, 8 Jul 2011 19:01:13 +0000 (19:01 +0000)]
r86603 : Updatin last call to mediawiki.legacy.edit and removing the module
Alexandre Emsenhuber [Fri, 8 Jul 2011 18:20:09 +0000 (18:20 +0000)]
Fix for r78786: make Special:Wantedpages includable again
Alexandre Emsenhuber [Fri, 8 Jul 2011 18:17:02 +0000 (18:17 +0000)]
Removed some error suppression operators
Mark A. Hershberger [Fri, 8 Jul 2011 18:08:30 +0000 (18:08 +0000)]
Fixes Bug #28838 — remove CSS references to div.editsection which grep
confirms isn't currently in use.
Leo Koppelkamm [Fri, 8 Jul 2011 17:59:42 +0000 (17:59 +0000)]
Moving skins/common/diff.css to mediawiki.action.history.diff.css and updating some old comments in the process. Also moved one vendor-prefixed attribute in fron of the standard one. Extension follow in a second
Krinkle [Fri, 8 Jul 2011 17:45:26 +0000 (17:45 +0000)]
Reverting r91642 per CR and pending review need-patch/patch in bug 29755
Leo Koppelkamm [Fri, 8 Jul 2011 17:20:56 +0000 (17:20 +0000)]
r91734: Do the same for search.css and remove module from resources.php
Leo Koppelkamm [Fri, 8 Jul 2011 17:07:11 +0000 (17:07 +0000)]
Migrate skins/common/search.js functionality to mediawiki.special.search.js. Make JS unobtrusive.