From 1f8b761dae4688f40d7b7dcab065b3fde8bf6270 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 4 Jul 2019 17:29:29 +0100 Subject: [PATCH] resourceloader: Remove 'mw.legacy' placeholder object This was very briefly used during the development cycle of MediaWiki 1.16 in 2010. The idea was to port some pre-RL legacy modules from global variables to mw.legacy.* (such as sajax, wikibits and other such 'mediawiki.legacy.*' modules), with a back-compat deprecate-warning alias from their old global names to the mw.legacy.* namespace. This was abandoned prior to stable release and never used again, and properly deprecated after years of no use in MediaWiki 1.22. Remove this now, finally. Change-Id: I9ef0984da7a07d4778fbeb71f3d4a7ebba97f29f --- RELEASE-NOTES-1.34 | 3 +++ resources/src/startup/mediawiki.js | 13 ------------- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34 index d708dd6643..3223948413 100644 --- a/RELEASE-NOTES-1.34 +++ b/RELEASE-NOTES-1.34 @@ -260,6 +260,9 @@ because of Phabricator reports. removed. * The JavaScript global variable wgLoadScript has been removed. Use mw.util.wikiScript( 'load' ) instead. +* ResourceLoader no longer creates the 'mw.legacy' placeholder object. It has + been unused since 1.16 and was deprecated in 1.22. To deprecate a property + in JavaScript, use mw.log.deprecate() instead. * … === Deprecations in 1.34 === diff --git a/resources/src/startup/mediawiki.js b/resources/src/startup/mediawiki.js index 2976dca849..d339704635 100644 --- a/resources/src/startup/mediawiki.js +++ b/resources/src/startup/mediawiki.js @@ -444,19 +444,6 @@ */ libs: {}, - /** - * Access container for deprecated functionality that can be moved from - * from their legacy location and attached to this object (e.g. a global - * function that is deprecated and as stop-gap can be exposed through here). - * - * This was reserved for future use but never ended up being used. - * - * @deprecated since 1.22 Let deprecated identifiers keep their original name - * and use mw.log#deprecate to create an access container for tracking. - * @property - */ - legacy: {}, - /** * Store for messages. * -- 2.20.1