Aaron Schulz [Fri, 13 Jan 2012 23:39:48 +0000 (23:39 +0000)]
Removed call to ParserTest::setUp() which was unnecessary. Also, the called function leaks globals anyway atm.
Aaron Schulz [Fri, 13 Jan 2012 23:30:46 +0000 (23:30 +0000)]
In FileBackend:
* Made secure() call doPrepare() for caller dummy proofing (especially those that don't check the status).
In FSFileBackend:
* Removed redundant wfMkdirParents() calls in FSFileBackend, we already have prepare() for this purpose. This also keeps it's behavior more consistent with the other backends.
* Made use of 'backend-fail-store' message in doStoreInternal().
Other:
* Updated unit tests and renamed $src => $source in some functions for consistency.
* Added some documentation comments and @since tags.
Antoine Musso [Fri, 13 Jan 2012 23:26:26 +0000 (23:26 +0000)]
Disable MWDebug tests for now
PHPUnit is too old on gallium so assertCount() is not recognized
The other two tests are broken for an unknown reason.
Sam Reed [Fri, 13 Jan 2012 23:14:28 +0000 (23:14 +0000)]
Rather than using an error code of unknownerror, use the error code returned by EditPage if it's a string, and it has length, else just return the usual "unknownerror"
Antoine Musso [Fri, 13 Jan 2012 23:10:21 +0000 (23:10 +0000)]
MWDebug: avoid double count()
Follow r107954
Antoine Musso [Fri, 13 Jan 2012 23:07:52 +0000 (23:07 +0000)]
some tests for MWDebug
Really incomplete. We need better testing.
Added two new public methods so we can get or clear the internal logs.
Benny Situ [Fri, 13 Jan 2012 22:58:32 +0000 (22:58 +0000)]
followup to -r107187 - adding bug24430 patch to 1.19 release note
Benny Situ [Fri, 13 Jan 2012 22:48:21 +0000 (22:48 +0000)]
Add bug33703 fix to 1.19 release note
Benny Situ [Fri, 13 Jan 2012 22:27:16 +0000 (22:27 +0000)]
patch from fomafix - bug33703 - remove black border-bottom-color for abbr
mrbluesky [Fri, 13 Jan 2012 22:19:01 +0000 (22:19 +0000)]
Fixing comments
Using shell style comments here stops Doxygen from processing the rest of the comments.
See http://svn.wikimedia.org/doc/classHTMLForm.html
Antoine Musso [Fri, 13 Jan 2012 22:09:11 +0000 (22:09 +0000)]
XCF: force rendering
Browsers do not support GIMP native format (yet?!). So we really need
to force rendering.
Noticed by Mark while testing the feature on labs.
Follow r107351
Rob Moen [Fri, 13 Jan 2012 21:57:52 +0000 (21:57 +0000)]
reverted r108850 as patch should be introduced after code freeze
Niklas Laxström [Fri, 13 Jan 2012 21:50:13 +0000 (21:50 +0000)]
@since, ping r101030
Sam Reed [Fri, 13 Jan 2012 21:42:31 +0000 (21:42 +0000)]
() are valid in URLs, not sure why we're using them as a finishing point in ApiFormatBase
Fixes fixme on r95572 as urls are now complete with () in them
Siebrand Mazeland [Fri, 13 Jan 2012 21:28:59 +0000 (21:28 +0000)]
Add 'api-error-unknownerror' and update punctuation and quotes for api-error-* where needed.
Rob Moen [Fri, 13 Jan 2012 21:24:38 +0000 (21:24 +0000)]
patch from MrBlueSky, resloves bug 25909. Add dropdown list for tags in recent changes and new pages
Niklas Laxström [Fri, 13 Jan 2012 21:19:44 +0000 (21:19 +0000)]
Ping r108847, missed one half quote
Siebrand Mazeland [Fri, 13 Jan 2012 21:11:27 +0000 (21:11 +0000)]
Change usage of quotes in API messages from ``x'' to "x".
Raimond Spekking [Fri, 13 Jan 2012 20:57:43 +0000 (20:57 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Niklas Laxström [Fri, 13 Jan 2012 16:56:48 +0000 (16:56 +0000)]
Fixing plural. Would "file, which" be clearer?
Siebrand Mazeland [Fri, 13 Jan 2012 14:47:27 +0000 (14:47 +0000)]
Add 'api-error-emptypage'.
Alexandre Emsenhuber [Fri, 13 Jan 2012 13:30:58 +0000 (13:30 +0000)]
Fix for r108376: the whole string is already espcaed on output, no need to escape it twice
Alexandre Emsenhuber [Fri, 13 Jan 2012 13:28:58 +0000 (13:28 +0000)]
Per Aaron, fix for r107776: correct count() check
Aaron Schulz [Fri, 13 Jan 2012 09:14:56 +0000 (09:14 +0000)]
r88633: lazy-load 'customFilters' field in SpecialRecentChanges. Almost every function is public here so there no control of the order stuff happens.
Niklas Laxström [Fri, 13 Jan 2012 08:41:33 +0000 (08:41 +0000)]
Fix broken indentation
Aaron Schulz [Fri, 13 Jan 2012 04:32:28 +0000 (04:32 +0000)]
* Distinguish "does not exist" from failure in FSFileBackend::doGetFileStat().
* Added clearstatcache() to doConcatenate() to make it safe for callers to stat the file.
* A few minor comment tweaks.
Sam Reed [Fri, 13 Jan 2012 02:40:09 +0000 (02:40 +0000)]
Partial revert ContextSource changes from r108785, r108786
Sam Reed [Fri, 13 Jan 2012 02:37:04 +0000 (02:37 +0000)]
Push msg from ContextSource/RequestContext into IContextSource
Sam Reed [Fri, 13 Jan 2012 02:30:51 +0000 (02:30 +0000)]
A couple more for r108785
More doucmentations
Sam Reed [Fri, 13 Jan 2012 02:27:44 +0000 (02:27 +0000)]
Documentation
As we're using stuff from ContextSource everwhere, limiting stuff to a type hint of IContextSource isn't much use
OverlordQ [Thu, 12 Jan 2012 23:22:09 +0000 (23:22 +0000)]
Followup to r108744
Sam Reed [Thu, 12 Jan 2012 23:10:22 +0000 (23:10 +0000)]
Maintenance class-ify eval.php
Sam Reed [Thu, 12 Jan 2012 22:57:51 +0000 (22:57 +0000)]
Give sql.php eval.php type scrollback
Sam Reed [Thu, 12 Jan 2012 22:35:48 +0000 (22:35 +0000)]
Followup r108768, callign the right callback helps too
Brion Vibber [Thu, 12 Jan 2012 22:17:54 +0000 (22:17 +0000)]
Revert r108764: doesn't appear to do what it says in the description, and no explanation why it's being done (presumably would just break searches again?)
Sam Reed [Thu, 12 Jan 2012 22:14:56 +0000 (22:14 +0000)]
Fix typo in SpecialVersion
Change require to require_once in commandLine.inc
Make eval.php require an absolute path rather than just one in itself
Simplify if statement
OverlordQ [Thu, 12 Jan 2012 22:11:12 +0000 (22:11 +0000)]
Followup to r107866, add in new job_timestamp field which was likely completely breaking anything related to the job queue, should fix failing TemplateCategoriesTest.testTemplateCategories on PG
Sam Reed [Thu, 12 Jan 2012 22:10:24 +0000 (22:10 +0000)]
Add $inputCsllback to sourceStream(), to return full lines back to the calling function
Will be used soooon
Aaron Schulz [Thu, 12 Jan 2012 22:01:02 +0000 (22:01 +0000)]
* Collapse multiple directory separators in FileBackend::normalizeStoragePath(). Also renamed the function to normalizeContainerPath() to be less confusing.
* Made SwiftFileBackend respect the 'latest' parameter of various functions via "X-Newest: true" header. Added to TODO in the doGetFileStat() function, as cloudfiles needs upstream changes for that.
* Fixed SwiftFileIterator to return paths relative to the given directory.
* Clean up for FSFileBackend trailing slash handling.
Diederik van Liere [Thu, 12 Jan 2012 21:34:55 +0000 (21:34 +0000)]
This commit restores getPrefixedText() to the Title in the XML. This means it does not break anything, the only change is that there is a new separate element that contains the namespace.
This commit is a follow up to:
r102575: Commit to fix bug 30513.
Raimond Spekking [Thu, 12 Jan 2012 21:22:22 +0000 (21:22 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Thu, 12 Jan 2012 20:50:14 +0000 (20:50 +0000)]
FU r106752: updated populateImageSha1.php script as needed
Aaron Schulz [Thu, 12 Jan 2012 20:05:25 +0000 (20:05 +0000)]
* Added backend name to 'backend-fail-internal' message
* Removed TODO comment in SwiftFileBackend
Aaron Schulz [Thu, 12 Jan 2012 20:01:54 +0000 (20:01 +0000)]
* Merged (added) SwiftFileBackend class from branch.
* Added i18n messages used by the new class.
Aaron Schulz [Thu, 12 Jan 2012 19:41:18 +0000 (19:41 +0000)]
Reverted r108743 per CR comment. This should at least be discussed first.
Aaron Schulz [Thu, 12 Jan 2012 19:20:58 +0000 (19:20 +0000)]
* Fixed a bit of bogus code left in r108740
* Added some class comments
Sam Reed [Thu, 12 Jan 2012 19:12:24 +0000 (19:12 +0000)]
Kill "* @return void"
Sam Reed [Thu, 12 Jan 2012 19:04:06 +0000 (19:04 +0000)]
Unindent code to use elseif
Sam Reed [Thu, 12 Jan 2012 19:03:32 +0000 (19:03 +0000)]
Documentation
Wrap some long lines
Aaron Schulz [Thu, 12 Jan 2012 18:44:00 +0000 (18:44 +0000)]
* Added 'basePath' config param to FSFileBackend and tweaked it to behave more similarly to the backends with real containers (e.g. everything else). Resolution to absolute paths is now deferred after resolveStoragePath(), using resolveToFSPath().
* Fixed whitespace in FSFileIterator.
Max Semenik [Thu, 12 Jan 2012 17:36:06 +0000 (17:36 +0000)]
Consistency: made all API examples a verbs
OverlordQ [Thu, 12 Jan 2012 17:10:48 +0000 (17:10 +0000)]
Followup to whatever revision added us_chunk_inx
Antoine Musso [Thu, 12 Jan 2012 16:42:33 +0000 (16:42 +0000)]
swap assertEquals parameters in TemplateCategoriesTest
First parameter is expected, second is the result
Antoine Musso [Thu, 12 Jan 2012 10:59:13 +0000 (10:59 +0000)]
(bug 32508) Fix updater output
site_stats updated is still a database action.
Purge cache is now the very last one.
Output:
<snip>
...site_stats is populated...done.
Purging caches...done.
Done.
Antoine Musso [Thu, 12 Jan 2012 09:03:38 +0000 (09:03 +0000)]
bug 33583 search ns user pref ignored!
r106780 to fix bug 33270 introduced a new bug that prevented selected
namespaces for search to be applied. This patch fix the issue.
Credits to Brad Jorsch
Sam Reed [Wed, 11 Jan 2012 21:52:44 +0000 (21:52 +0000)]
* (bug 33117) prop=revisions allows deleted text to be exposed through cache pollution
Max Semenik [Wed, 11 Jan 2012 20:19:55 +0000 (20:19 +0000)]
Revert r108603, which was itself a revert of r107376, r107994. Before considering something unneeded, please ask first ;)
Raimond Spekking [Wed, 11 Jan 2012 20:17:10 +0000 (20:17 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Niklas Laxström [Wed, 11 Jan 2012 19:47:21 +0000 (19:47 +0000)]
Apparently we can commit code that doesn't compile but I am not allowed to have commit summary as "){} -> ) {}"
Alexandre Emsenhuber [Wed, 11 Jan 2012 19:23:57 +0000 (19:23 +0000)]
Whitespaces fixes only, no functional changes.
Rob Moen [Wed, 11 Jan 2012 18:00:49 +0000 (18:00 +0000)]
remove concurrency resource per revert. follow up r108600
Sam Reed [Wed, 11 Jan 2012 15:51:07 +0000 (15:51 +0000)]
Add @since to getPerformedAction, added in r108342
Caused site errors as not in 1.18 when trying to merge r108345 as a followup to r94131
Sam Reed [Wed, 11 Jan 2012 15:45:49 +0000 (15:45 +0000)]
Remove RELEASE-NOTES-1.19 from r108145, moved to 1.18 in r108629
Max Semenik [Wed, 11 Jan 2012 15:42:29 +0000 (15:42 +0000)]
Made Parser::addTrackingCategory() public to benefit tag hooks/parser functions developers
Sam Reed [Wed, 11 Jan 2012 14:53:52 +0000 (14:53 +0000)]
Kill bug 25355 RELEASE-NOTES-1.19 from r92703 as moved to 1.18 in r108620
Jeroen De Dauw [Wed, 11 Jan 2012 14:11:06 +0000 (14:11 +0000)]
revert r108508 which reverted for no good reason
Max Semenik [Wed, 11 Jan 2012 10:38:25 +0000 (10:38 +0000)]
Fixed reporting in importDump.txt
Alexandre Emsenhuber [Wed, 11 Jan 2012 10:33:31 +0000 (10:33 +0000)]
Moved RessourceLoader modules and stylesheet related stuff from EditPage::edit() to EditPage::setHeaders() and header messages to EditPage::showHeader(); there's no point running all that code when the edit form is not displayed (e.g. page save).
Antoine Musso [Wed, 11 Jan 2012 09:46:21 +0000 (09:46 +0000)]
Reverts MySQL stored procedure support
This is reverting the work done by MaxSem to support stored procedures
and stored function in MySQL. The reasons are:
- it is not needed yet
- tests are not functionals
- alter the stable include/db/Database.php and drop support for ';;'
So please create a branch to work on it and merge it back in trunk
once we have branched 1.19 :-)
I have opened bug 33654 to track this enhancement request.
Reverts r107376, r107994.
Antoine Musso [Wed, 11 Jan 2012 09:05:56 +0000 (09:05 +0000)]
reverts Concurrency works
trunk is frozen pending stabilisation so we can release MediaWiki 1.19.
Those changes introduces API changes and new SQL tables, so that sounds like
new feature we do not have time to review right now.
Please reapply changes in branches/concurrency and have code review handled
there. Once the branch has been reviewed, please hold. Once trunk is stable
enough and 1.19 got branched, you are welcome to merge the branch in trunk.
Note: we can have a Jenkins jobs setup to run the branch tests if you need.
Reverts:
r108595 r108591 r108585 r108584 108572 r108564 108560 r108559
Ian Baker [Wed, 11 Jan 2012 02:48:28 +0000 (02:48 +0000)]
Commenting these tests out so that CI can run, since I need to leave and nobody uses this code yet.
These fail only on sqlite, and only when run with the entire suite (they're fine when run individually).
Skipping ApiBlockTest allows ApiConcurrencyTest to run, oddly enough.
Clearly, this will need to be fixed ASAP. I'll take care of it on Thursday when I'm back online, or possibly
before.
Ian Baker [Wed, 11 Jan 2012 02:02:26 +0000 (02:02 +0000)]
sqlite needs its timestamps quoted
fixed some memcache timestamp bugs
followup to r108559
Ian Baker [Wed, 11 Jan 2012 01:27:55 +0000 (01:27 +0000)]
sqlite doesn't actually support read locks. added a workaround until i can do the correct implementation.
followup to r108559
Ian Baker [Wed, 11 Jan 2012 01:10:27 +0000 (01:10 +0000)]
Fixed concurrency issues related to mysql default locking mode, per Roan's comments. Fixed other little bugs Roan pointed out also.
followup to r108559
Chad Horohoe [Wed, 11 Jan 2012 00:53:08 +0000 (00:53 +0000)]
Revert r102624, r104262 (user display name stuff). Per CR there isn't consensus on this yet.
Rob Moen [Wed, 11 Jan 2012 00:17:17 +0000 (00:17 +0000)]
add js resource for concurrency api, check method for resource checkin & checkout
Ian Baker [Tue, 10 Jan 2012 23:42:03 +0000 (23:42 +0000)]
Updated to use correct cross-db timestamps and date functions
Added to SQLite updater
Sam Reed [Tue, 10 Jan 2012 23:12:00 +0000 (23:12 +0000)]
Add svn:keywords Id
Trim trailing whitespace
Add explicit member variables
Ian Baker [Tue, 10 Jan 2012 23:03:03 +0000 (23:03 +0000)]
MERGE branches/concurrency 108301:108557 into trunk
Raimond Spekking [Tue, 10 Jan 2012 21:07:49 +0000 (21:07 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Tue, 10 Jan 2012 21:03:09 +0000 (21:03 +0000)]
[Core JS] Remove superfluous comments (follows-up r107329)
Antoine Musso [Tue, 10 Jan 2012 20:50:34 +0000 (20:50 +0000)]
move parser fuzz test to ParserFuzz group
Somehow fixes bug 29493:
« Put parser fuzz tests in @group and disable by default »
Sam Reed [Tue, 10 Jan 2012 18:42:59 +0000 (18:42 +0000)]
Fix whitespace
Fix/improve documentation
Gabriel Wicke [Tue, 10 Jan 2012 18:16:38 +0000 (18:16 +0000)]
Support If-modified-since for RawPage, fixes bug #10023.
The check to WikiPage::getTouched will load the latest revision data, which is
not ideal for performance. In a quick test using ab -c 100 -n 1000 and without
MemCached enabled, the request rate for plain GET requests drops slightly from
108 to 104 req/second. As described in my comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=10023#c9, this could certainly be
improved on. Overall, a few unmodified responses should still make the
server-side performance impact of this patch positive, while improving
client-side performance considerably for unmodified content.
Aaron Schulz [Tue, 10 Jan 2012 18:05:36 +0000 (18:05 +0000)]
Reverted r108502, r108504 per CR
Antoine Musso [Tue, 10 Jan 2012 15:40:01 +0000 (15:40 +0000)]
reverts $wgDeprecationWhitelist
There is no point in ignoring a deprecated function. The call really need
to be migrated OR the core function should not be deprecated if there is
any kind of valid usage.
If you really want to hide notifications, uses:
$wgDevelopmentWarnings = false;
Reverts r106993 r106946
Sam Reed [Tue, 10 Jan 2012 15:04:05 +0000 (15:04 +0000)]
Cleanup "text" (nee old) table, dropping old indexes and fields
Add oldwatchlist to dropAncientTables
Antoine Musso [Tue, 10 Jan 2012 14:26:17 +0000 (14:26 +0000)]
StoreBatchText note about using custom repo
follow up r108308
Sam Reed [Tue, 10 Jan 2012 14:07:32 +0000 (14:07 +0000)]
Noticed looking at schema posted by Joerg in bug 33228
It seems many ancient tables (removed mainly in 1.4, and some in 1.6)
Kill them with fire, if they've still got unmigrated data in or something, we've got bigger issues!
Noticed "user_rights" table is not documented at Manual:Database_layout
Niklas Laxström [Tue, 10 Jan 2012 07:39:51 +0000 (07:39 +0000)]
Moved GenderCache to cache/
Santhosh Thottingal [Tue, 10 Jan 2012 05:13:50 +0000 (05:13 +0000)]
Make the plural rules for Southern Sami consistant with the rules in LanguageSma.php
Santhosh Thottingal [Tue, 10 Jan 2012 05:03:27 +0000 (05:03 +0000)]
Make the plural rules consistant with the rules in LanguageSe.php.
Santhosh Thottingal [Tue, 10 Jan 2012 04:25:21 +0000 (04:25 +0000)]
Make the javascript implementation of Macedonian(mk) plural consistant with php side rule.
Add a todo in php code since the rules differs from CLDR definition for mk plural.
Aaron Schulz [Tue, 10 Jan 2012 02:18:27 +0000 (02:18 +0000)]
r108353: Distinguish null/false in FileBackend::fileExists(). This is intended for things that might really care.
Platonides [Mon, 9 Jan 2012 22:33:00 +0000 (22:33 +0000)]
Revert r108358. It's a good fellow and we like to keep it.
Raimond Spekking [Mon, 9 Jan 2012 21:29:15 +0000 (21:29 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Mon, 9 Jan 2012 21:22:54 +0000 (21:22 +0000)]
Removed debug code from r108472
Aaron Schulz [Mon, 9 Jan 2012 21:21:40 +0000 (21:21 +0000)]
Fix r108185: file transform store op needs 'overwriteDest'
Aaron Schulz [Mon, 9 Jan 2012 21:04:48 +0000 (21:04 +0000)]
* Fixed FileOp::attemptBatch() bug that had status->ok set wrong if 'force' option was used.
* Added missing prepare() call to File::maybeDoTransform().
* Improved documentation.
Antoine Musso [Mon, 9 Jan 2012 19:38:38 +0000 (19:38 +0000)]
fix '999bps' test message
follow r108413