Jason Richey [Wed, 15 Oct 2008 23:53:38 +0000 (23:53 +0000)]
added 'UnwatchArticle', 'WatchArticle' and 'WatchArticleComplete' in response to code review of rev 42109
Danny B [Wed, 15 Oct 2008 22:50:14 +0000 (22:50 +0000)]
* added line-wraps to make the XHTML output easier legible
Jason Richey [Wed, 15 Oct 2008 22:12:46 +0000 (22:12 +0000)]
added a check for a null value when adding session values
Ilmari Karonen [Wed, 15 Oct 2008 21:51:21 +0000 (21:51 +0000)]
Switch order of apple-touch-icon and favicon links in HTML head section to work around a quirk in
Konqueror's handling of those links. Should not affect other browsers in any way.
Brion Vibber [Wed, 15 Oct 2008 21:35:19 +0000 (21:35 +0000)]
Back out r41630 -- merging of Nuke extension to core
Nuke started as a crappy hack, and it's still pretty crappy. ;) Needs better reversibility tools etc before we consider merging to core.
Brion Vibber [Wed, 15 Oct 2008 21:20:13 +0000 (21:20 +0000)]
Fix for r41837 -- apply HTML stripping to explicit alt text as well as implicit.
Added parser test cases to confirm.
Brion Vibber [Wed, 15 Oct 2008 21:05:39 +0000 (21:05 +0000)]
Pull out incorrect fixme comments from r42075
Brion Vibber [Wed, 15 Oct 2008 20:57:02 +0000 (20:57 +0000)]
Pulling out r42105 for now -- "Added 2 hooks. One in Parser to allow custom handling of namespace links, and one in EditPage, to allow custom output/handling when a user has no edit rights"
The namespace parsing thing feels very hacky and grabs bits out of an internal implementation function which doesn't feel like a stable interface.
Would recommend thinking about this and coming up with a more serious stable interface for it.
Siebrand Mazeland [Wed, 15 Oct 2008 20:43:48 +0000 (20:43 +0000)]
Localisation updates for core messages from Betawiki (2008-10-15 22:11 CEST)
Jason Richey [Wed, 15 Oct 2008 20:40:14 +0000 (20:40 +0000)]
updated REALEASE-NOTES following my change concerning the watchlist hook (extensions using this hook may be affected)
Chad Horohoe [Wed, 15 Oct 2008 20:38:50 +0000 (20:38 +0000)]
Let's do this again, without all the breakages... (bug 15925) Properly bold rc bytes changed in all cases. Patch by Happy-melon and FunPika.
Jason Richey [Wed, 15 Oct 2008 20:31:53 +0000 (20:31 +0000)]
added "UnwatchArticleComplete" hook to watchlisteditor so that it gets called when users use the editor rather than clicking an "unwatch" link
Jason Richey [Wed, 15 Oct 2008 19:32:59 +0000 (19:32 +0000)]
Added 2 hooks. One in Parser to allow custom handling of namespace links, and one in EditPage, to allow custom output/handling when a user has no edit rights
Aaron Schulz [Wed, 15 Oct 2008 14:23:23 +0000 (14:23 +0000)]
Bump limit to 50
Brion Vibber [Wed, 15 Oct 2008 00:06:51 +0000 (00:06 +0000)]
Revert broken r42078 "(bug 15925) Properly bold rc bytes changed in all cases. Patch by Happy-melon."
Bad HTML output breaks things entirely, plus the code is much harder to read. Plus it's unclear if this behavior is desirable.
Chad Horohoe [Tue, 14 Oct 2008 12:56:25 +0000 (12:56 +0000)]
(bug 15925) Properly bold rc bytes changed in all cases. Patch by Happy-melon.
Roan Kattouw [Tue, 14 Oct 2008 12:46:11 +0000 (12:46 +0000)]
(bug 15945) API: Use User::useRCPatrol() and useNPPatrol() rather than isAllowed('patrol') in list=recentchanges
Andrew Garrett [Tue, 14 Oct 2008 10:50:26 +0000 (10:50 +0000)]
Mark a FIXME in RecentChange.php - We shouldn't be treating log entries as page changes. This causes a few problems with deletions.
Alex Z [Mon, 13 Oct 2008 22:39:53 +0000 (22:39 +0000)]
* (bug 1250) Let users use "show preview" and "show changes" even if the wiki is set to read-only mode.
Brion Vibber [Mon, 13 Oct 2008 21:50:16 +0000 (21:50 +0000)]
Quick hack: add $wgMaxAnimatedGifArea so we don't try to render animated thumbs for huge animated GIFs.
'Tugra Mahmuds II Big Size.gif' on Commons otherwise seems to eat as much CPU and memory as you can throw at it (1,876 × 1,500 pixel, file size: 4.36 MB, MIME type: image/gif)
Ryan Lane [Mon, 13 Oct 2008 19:48:20 +0000 (19:48 +0000)]
Removing $result from UserLoadAfterLoadFromSession to match User.php
Ryan Lane [Mon, 13 Oct 2008 19:26:16 +0000 (19:26 +0000)]
Fixing documentation line for UserLoadAfterLoadFromSession
Ryan Lane [Mon, 13 Oct 2008 19:23:27 +0000 (19:23 +0000)]
Removing $result from UserLoadAfterLoadFromSession hook, as it was unused.
Brion Vibber [Mon, 13 Oct 2008 19:22:14 +0000 (19:22 +0000)]
Fix poem parser test cases not quite fixed up from r42012
2 previously failing test(s) now PASSING! :)
* nested <poem><nowiki> [Fixed between 13-Oct-2008 18:22:08, 1.14alpha (r42038) and now]
* nested <poem><nowiki> with formatting [Fixed between 13-Oct-2008 18:22:08, 1.14alpha (r42038) and now]
Alexandre Emsenhuber [Mon, 13 Oct 2008 19:15:46 +0000 (19:15 +0000)]
Fatal error: Call to undefined function getInterwikiCacheEntry() in ./includes/Interwiki.php on line 79
Aaron Schulz [Mon, 13 Oct 2008 19:13:54 +0000 (19:13 +0000)]
Add debug log item for r42040
Aaron Schulz [Mon, 13 Oct 2008 19:08:27 +0000 (19:08 +0000)]
Use $dbw->addQuotes :)
Ryan Lane [Mon, 13 Oct 2008 19:00:54 +0000 (19:00 +0000)]
Adding hook UserLoadAfterLoadFromSession to fix bug 14178
Aaron Schulz [Mon, 13 Oct 2008 18:49:43 +0000 (18:49 +0000)]
Add quotes
Brion Vibber [Mon, 13 Oct 2008 18:43:55 +0000 (18:43 +0000)]
Cleanup for r42022/r42023 interwiki stuff
* Remove duplicate code in Interwiki::isValidInterwiki(), which should help avoid future drift between the two copies
* Early return on prefix = '', we know it won't be valid :)
* Dump extra isValidInterwikiCached function -- just go through the regular fetch() path, it doesn't do much more processing.
* Simplify Title codepath in full URL generation to ensure we never call an invalid object
Aaron Schulz [Mon, 13 Oct 2008 18:41:09 +0000 (18:41 +0000)]
(bug 6464) Check for session id collisions by checking cookie user ID against session user ID
Alexandre Emsenhuber [Mon, 13 Oct 2008 18:38:01 +0000 (18:38 +0000)]
Revert r41506 and make LoadBalancer::openForeignConnection() call Database::tablePrefix() on successful new connection
Aaron Schulz [Mon, 13 Oct 2008 17:27:44 +0000 (17:27 +0000)]
Allow no prefix here
Aaron Schulz [Mon, 13 Oct 2008 15:40:02 +0000 (15:40 +0000)]
Improve hidden field checks for bug 1181
Aaron Schulz [Mon, 13 Oct 2008 15:02:02 +0000 (15:02 +0000)]
Comment out accidentally committed code from r42020; didn't mean to commit just yet
Aaron Schulz [Mon, 13 Oct 2008 14:48:17 +0000 (14:48 +0000)]
(bug 1150) Do not skip edit conflict and override just because editing user was the last to edit. This caused removal of edits if a user edit conflicts, merges/automerges, then presses back (such as fixing a typo) and saves again. Check all users since edit time instead. If they are *all* the editing user, then go ahead and skip.
Tim Starling [Mon, 13 Oct 2008 14:19:25 +0000 (14:19 +0000)]
Fixed getSlavePos() to use the SQL thread fields, not the IO thread fields.
Matt Johnston [Mon, 13 Oct 2008 09:31:46 +0000 (09:31 +0000)]
Fix r42022, always returning true for isValidInterwiki as I forgot to add the check.
Matt Johnston [Mon, 13 Oct 2008 08:35:11 +0000 (08:35 +0000)]
Clean up Interwiki.php to meet Tim's suggestions. Hopefully should make cleaner to read as well.
Aaron Schulz [Mon, 13 Oct 2008 06:17:42 +0000 (06:17 +0000)]
Refactor sendToUDP() some more
Siebrand Mazeland [Mon, 13 Oct 2008 06:10:39 +0000 (06:10 +0000)]
Follow up on r42011: remove from messages.inc
Aaron Schulz [Mon, 13 Oct 2008 06:02:32 +0000 (06:02 +0000)]
Don't use vague boolean
Aaron Schulz [Mon, 13 Oct 2008 04:38:54 +0000 (04:38 +0000)]
*Remove useless garbage hooks. This kind of stuff shouldn't be in the core.
Brion Vibber [Mon, 13 Oct 2008 02:38:31 +0000 (02:38 +0000)]
Cleanup for r41952: > is usually easier to understand than !<= :)
Ryan Schmidt [Mon, 13 Oct 2008 02:18:49 +0000 (02:18 +0000)]
* re-implement r41983 (forgot to add log message). Changes made:
** <poem> handling fixes: use DoubleReplacer class instead of create_function(), moving recursiveTagParse above line-break replacements, removed strip items, updated parser tests to reflect new output when combined with <nowiki>
Brion Vibber [Mon, 13 Oct 2008 01:44:22 +0000 (01:44 +0000)]
Tweaks to r41902 "(bug 14634) Show range blocks for IPs"
* Remove the "scan range blocks" checkbox -- doing the range check is sane default behavior, and should Just Work. :)
* Paranoia SQL escaping. We may "know" that the strings will never include something escapable, but then again someone might make a mistake one day. By ensuring we escape them, we have one less thing to worry about, and one less thing to double-check every time we look at this code.
Note that a search for a particular range block currently does not turn up larger range blocks that include it, which it probably should.
Brion Vibber [Mon, 13 Oct 2008 00:08:44 +0000 (00:08 +0000)]
Back out r41786 for now "(bug 9226) Fetch restrictions properly on export"
Per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/41786#c121:
Issues:
1. Restriction fetches may not be synchronous with original start in a long-running export
2. Looks like this adds an SQL query to slave for every single page
3. In case of timed-out DB connections or a dying slave, this might break a long-running dump process
Brion Vibber [Sun, 12 Oct 2008 23:14:39 +0000 (23:14 +0000)]
Revert mystery change r41983 -- no explanation of the change or its purpose.
Appears to be an attempt to remove some extra whitespace, but it's kind of unclear.
Siebrand Mazeland [Sun, 12 Oct 2008 20:02:32 +0000 (20:02 +0000)]
Localisation updates for core messages from Betawiki (2008-10-12 21:44 CEST)
Aaron Schulz [Sun, 12 Oct 2008 19:00:27 +0000 (19:00 +0000)]
Check $wgUser->useRCPatrol()
Aaron Schulz [Sun, 12 Oct 2008 17:33:24 +0000 (17:33 +0000)]
Rebuilt messages
Aaron Schulz [Sun, 12 Oct 2008 17:31:03 +0000 (17:31 +0000)]
(bug 15946) Add hidepatrolled option to Special:Watchlist
Aaron Schulz [Sun, 12 Oct 2008 17:07:09 +0000 (17:07 +0000)]
(bug 15952) Don't try to lazy populate sha1 in read-only mode
Tim Starling [Sun, 12 Oct 2008 14:29:55 +0000 (14:29 +0000)]
Add readOnlyBySection setting, to replace live hack.
Tim Starling [Sun, 12 Oct 2008 13:28:04 +0000 (13:28 +0000)]
Reverted r41655. Causes a text load on parser cache hit. Reduces parser cache hit performance especially for ES clusters. Messages not reverted on the assumption that this revert is temporary.
Siebrand Mazeland [Sun, 12 Oct 2008 11:03:44 +0000 (11:03 +0000)]
Localisation updates for core messages from Betawiki (2008-10-12 12:47 CEST)
Siebrand Mazeland [Sun, 12 Oct 2008 08:57:48 +0000 (08:57 +0000)]
Fix bug in namespace aliases definition. Was introduced in r26981
Siebrand Mazeland [Sun, 12 Oct 2008 08:55:06 +0000 (08:55 +0000)]
(bug 15947) Fix bug introduced in r41134: removed quotes
Huji [Sun, 12 Oct 2008 08:28:30 +0000 (08:28 +0000)]
Localisation updates: Adding/updating Persian translations
Ryan Schmidt [Sun, 12 Oct 2008 02:20:08 +0000 (02:20 +0000)]
Aaron Schulz [Sat, 11 Oct 2008 23:30:38 +0000 (23:30 +0000)]
(bug 15428) Fix erroneous coloring of unrelated items due to text matches. Only do the links.
Ryan Schmidt [Sat, 11 Oct 2008 21:53:44 +0000 (21:53 +0000)]
* fixes for the merged Poem extension, per comments by Tim Starling on CodeReview (r41710)
* adding <poem> tests to the parser tests file
Aaron Schulz [Sat, 11 Oct 2008 21:06:21 +0000 (21:06 +0000)]
* Make $user->invalidateCache() get the Id if needed
* Remove redundant cache clearing in renameuser
Aaron Schulz [Sat, 11 Oct 2008 17:35:38 +0000 (17:35 +0000)]
More RC UDP refactoring for bug 15276
Chad Horohoe [Sat, 11 Oct 2008 16:38:43 +0000 (16:38 +0000)]
Revert r41603, r41751 (splitting Preferences validation into its own class). Breaks a lot of things per comments on Code Review by Tim.
Tim Starling [Sat, 11 Oct 2008 13:53:00 +0000 (13:53 +0000)]
Fix freaky calling method for MovePageForm::showForm(), add docs
Greg Sabino Mullane [Sat, 11 Oct 2008 12:08:10 +0000 (12:08 +0000)]
Add column ipblocks.ipb_allow_usertalk
Greg Sabino Mullane [Sat, 11 Oct 2008 11:45:26 +0000 (11:45 +0000)]
Add index on templatelinks.tl_from
Siebrand Mazeland [Sat, 11 Oct 2008 09:14:03 +0000 (09:14 +0000)]
Rebuild messages files involved in recent reverts.
Siebrand Mazeland [Sat, 11 Oct 2008 09:06:11 +0000 (09:06 +0000)]
* Want to commit new messages? "php rebuildLanguage.php --lang=en"
* Does it give output about unknown messages? Fix it in messages.inc. Repeat cycle.
Tim Starling [Sat, 11 Oct 2008 08:28:07 +0000 (08:28 +0000)]
* Revert r38347, removal of movenologintext. This error message is and has always been used in Title.php.
* Readded some cant-move-user-page messages by reverse-merging r41596
Tim Starling [Sat, 11 Oct 2008 08:26:01 +0000 (08:26 +0000)]
* Reintroduce user page move permission as per r41465, generally useful regardless of whether the Renameuser extension is in use. Do the check in Title::getUserPermissionsErrorsInternal(), so that the move page tab won't be displayed on user pages for users who can't move them.
* Use error message text suitable for humans. Be specific about whether the source or the destination is the problem, say what the namespace is for those people who don't get namespaces, don't introduce unnecessary jargon words like "root" for a page that isn't a subpage.
* Fixed incorrect display of movenotallowed for immobile namespaces, use the new specific error messages.
Tim Starling [Sat, 11 Oct 2008 05:20:18 +0000 (05:20 +0000)]
Revert r41445: static members invite permanent use in the caller, which would give us an ugly interface to remain backwards compatible with. See CodeReview.
Tim Starling [Sat, 11 Oct 2008 04:31:15 +0000 (04:31 +0000)]
Revert merge of DismissableSiteNotice into the core (r41679 and subsequent edits). We should have higher standards than this for core code. This is largely my own crap code and there's a reason I didn't commit it to the core in the first place.
* The sitenotice_id hack is virtually unusable and needs to be replaced with a dedicated message update interface.
* There's a need for automatic message expiry.
* The Wikimedia-specific "spite the anons" feature, preventing anonymous users from dismissing site notices because they allegedly don't contribute to the wiki enough to deserve it, needs to be made optional.
Alex Z [Fri, 10 Oct 2008 22:19:55 +0000 (22:19 +0000)]
Adding file cache to the parser to improve rendering time on pages with several uses of the same image; designed with input from Brion and Tim. Cache size is limited to 1000.
Aaron Schulz [Fri, 10 Oct 2008 20:42:39 +0000 (20:42 +0000)]
remove unused var
Aryeh Gregor [Fri, 10 Oct 2008 19:23:21 +0000 (19:23 +0000)]
(bug 2796) Remove selector that will never match
#p-tbx has never actually matched anything that I know of: the correct id is #p-tb. Maybe it would be better to switch the rule to actually apply to #p-tb, but nobody has actually pointed out what this will do for two years, and for all I know it will break something. So delete it so the source code matches how it actually works.
Greg Sabino Mullane [Fri, 10 Oct 2008 18:24:02 +0000 (18:24 +0000)]
Quick fix to index dropping, without using IF EXISTS clause, per bug #15896
Greg Sabino Mullane [Fri, 10 Oct 2008 18:15:53 +0000 (18:15 +0000)]
Fix invalid SQL, per bug #15836
Greg Sabino Mullane [Fri, 10 Oct 2008 18:08:45 +0000 (18:08 +0000)]
Alter oldimage.metadata to bytea, per bug 15815
Aryeh Gregor [Fri, 10 Oct 2008 17:43:17 +0000 (17:43 +0000)]
(bug 15928) Make special pages dropdown inline
There was a weird extra "|" at the end of lines in Nostalgia (probably other non-MonoBook skins too). Upon investigation, I found that the special pages dropdown (which immediately followed that separator but on the next line) had a class="inline", which actually did nothing but whose intent was fairly obvious. I removed the presentational class and just styled it using the id, so now the separator actually . . . separates.
Ilmari Karonen [Fri, 10 Oct 2008 17:09:53 +0000 (17:09 +0000)]
Use getParameter() for the "maxage" and "smaxage" parameters rather than pulling them straight out of the request
so that they'll be properly validated (and in particular coerced to integers).
Aaron Schulz [Fri, 10 Oct 2008 16:01:54 +0000 (16:01 +0000)]
Tweak udp function to allow any prefix
Meno25 [Fri, 10 Oct 2008 15:54:29 +0000 (15:54 +0000)]
Update files
Aryeh Gregor [Fri, 10 Oct 2008 15:37:51 +0000 (15:37 +0000)]
Add more info to Title::newFromText() comment
Point the reader to makeTitle() and makeTitleSafe() to force a namespace to be used regardless of prefix, to hopefully reduce confusion.
Aryeh Gregor [Fri, 10 Oct 2008 15:37:44 +0000 (15:37 +0000)]
Reformat comment for Title::newFromText
Don't use ugly \type nonsense. We want this to be readable in the source code at least as much as in the auto-generated docs. Follow the standard used everywhere else, documented at <http://www.mediawiki.org/wiki/Manual:Code_standards>: "@param varname type desc...". Also respace to 80 chars per line, not some random number.
Aryeh Gregor [Fri, 10 Oct 2008 15:37:32 +0000 (15:37 +0000)]
Fix E_NOTICE from r41770
Alexandre Emsenhuber [Fri, 10 Oct 2008 15:26:34 +0000 (15:26 +0000)]
typo *sigh*
Tim Starling [Fri, 10 Oct 2008 13:02:57 +0000 (13:02 +0000)]
Fixed regression from r35821: the status key is meant to prevent DB overload, not memcached overload.
Meno25 [Fri, 10 Oct 2008 11:52:30 +0000 (11:52 +0000)]
Update files
Aaron Schulz [Fri, 10 Oct 2008 06:53:54 +0000 (06:53 +0000)]
Update
Aaron Schulz [Fri, 10 Oct 2008 06:16:18 +0000 (06:16 +0000)]
Tweak r41829 to use new messages
Fran Rogers [Fri, 10 Oct 2008 06:00:46 +0000 (06:00 +0000)]
Fix template-included categories from 'leaking' from older revisions when cascading protection is on.
Tim Starling [Fri, 10 Oct 2008 01:54:04 +0000 (01:54 +0000)]
Fix stomach-churning case of edititis in r41350: made optional.
Ryan Schmidt [Fri, 10 Oct 2008 01:15:11 +0000 (01:15 +0000)]
* integrating UniversalEditButton extension into core (enabled by default, set $wgUniversalEditButton = false; in LocalSettings to disable)
Tim Starling [Fri, 10 Oct 2008 01:02:39 +0000 (01:02 +0000)]
Fix error display on invalid destination title on GET, e.g. with URL /wiki/Special:MovePage/Main_Page?wpNewTitle=Main_Page . Broken by r35990 and again by r41343.
Tim Starling [Fri, 10 Oct 2008 00:27:06 +0000 (00:27 +0000)]
Parser test for bug 15196
Rotem Liss [Thu, 9 Oct 2008 21:56:16 +0000 (21:56 +0000)]
Localization update.
Aaron Schulz [Thu, 9 Oct 2008 21:49:20 +0000 (21:49 +0000)]
(bug 14634) Show range blocks for IPs
Antoine Musso [Thu, 9 Oct 2008 21:11:10 +0000 (21:11 +0000)]
Document wfVarDump()