Alexandre Emsenhuber [Sat, 2 Aug 2008 13:06:08 +0000 (13:06 +0000)]
Fixes for r38424:
* $wgAddGroups[$group] can be true if the user can add all rights, show this in Special:ListGroupRights
* added messages to messages.inc
Somehow related:
* Setting $wgAddGroups = $wgRemoveGroups = array(); in DefaultSettings.php seems to put a reference between these two variables.
Chad Horohoe [Sat, 2 Aug 2008 12:42:51 +0000 (12:42 +0000)]
Create User::getGroupsInRoles(). Given an array of roles (edit, read, delete), return the groups allowed to do each.
Victor Vasiliev [Sat, 2 Aug 2008 12:39:29 +0000 (12:39 +0000)]
* Fix WebRequest.php
* Add RELEASE-NOTES for my previous commit
Victor Vasiliev [Sat, 2 Aug 2008 11:29:27 +0000 (11:29 +0000)]
Show $wgAddGroups and $wgRemoveGroups on Special:ListGroupRights
Chad Horohoe [Sat, 2 Aug 2008 08:10:45 +0000 (08:10 +0000)]
Remove unused global.
Andrew Garrett [Sat, 2 Aug 2008 03:07:03 +0000 (03:07 +0000)]
Use content language for rightsnone
Chad Horohoe [Sat, 2 Aug 2008 02:39:09 +0000 (02:39 +0000)]
Take Article::viewRedirect() public and have it return a string so it can be used other places, like EditPage for proper rendering of redirects on preview (bug 2333). +Docs here and there.
Jon Harald Søby [Sat, 2 Aug 2008 01:06:35 +0000 (01:06 +0000)]
Gah, committed Linker.php by mistake. Reverting.
Jon Harald Søby [Sat, 2 Aug 2008 01:04:25 +0000 (01:04 +0000)]
Adding messages for new global group 'sysadmin'. Brion, Tim, Kate and JeLuF are all in it from the beginning.
Aaron Schulz [Fri, 1 Aug 2008 22:59:06 +0000 (22:59 +0000)]
Add date selector to history pages
Aaron Schulz [Fri, 1 Aug 2008 22:56:17 +0000 (22:56 +0000)]
Opps, var renamed
Aryeh Gregor [Fri, 1 Aug 2008 22:44:11 +0000 (22:44 +0000)]
Fix the regression Brion noticed (not caused by me!) with special page links getting fragments eaten. I noticed that additionally, all nonexistent pages with fragments eat the fragment, and fixed that. Added three new passing parser tests.
Aaron Schulz [Fri, 1 Aug 2008 22:39:45 +0000 (22:39 +0000)]
Remove extra vars
Aaron Schulz [Fri, 1 Aug 2008 22:38:45 +0000 (22:38 +0000)]
* Better yet, move getDateCond() to reverseChronologicalPager to avoid duplication.
* Make LogPager use getDateCond(). This also means that greg's fixes to contribs apply to logs as well.
Jack Phoenix [Fri, 1 Aug 2008 22:38:11 +0000 (22:38 +0000)]
adding new hook, MakeGlobalVariablesScript
Siebrand Mazeland [Fri, 1 Aug 2008 22:35:32 +0000 (22:35 +0000)]
Localisation updates for core messages from Betawiki (2008-08-02 00:20 CEST)
Aaron Schulz [Fri, 1 Aug 2008 22:28:31 +0000 (22:28 +0000)]
Minor refactoring and code style tweaks
Purodha B Blissenbach [Fri, 1 Aug 2008 22:20:41 +0000 (22:20 +0000)]
Message text punktuation.
Brion Vibber [Fri, 1 Aug 2008 21:00:24 +0000 (21:00 +0000)]
Don't die horribly from sql.php when making INSERT/DELETE/UPDATE/CREATE TABLE/etc calls that return 'true' instead of a result object.
Code was attempting to handle this case by asking the result object for its db so we can ask for the affected row count -- obviously that doesn't do so good when the result is not an object.
Changed Database::sourceStream() to send itself as the second parameter to the result-handling callback, so the callback knows which DB to check.
Siebrand Mazeland [Fri, 1 Aug 2008 19:57:27 +0000 (19:57 +0000)]
Fix previous change to 'undo-summary'. Should be shown in content language instead of user language
Brion Vibber [Fri, 1 Aug 2008 16:38:15 +0000 (16:38 +0000)]
* (bug 13376) Use $wgPasswordSender, not $wgEmergencyContact, as return
address for page update notification mails.
Note that $wgEmergencyContact is now not currently in active use, but could
in theory be used for some kinds of failure notifications or to provide to
users to contact in case of failure, which I think was its original intention.
Certainly it's silly to throw an "emergency" contact on auto-sent mails!
There's also a $wgNoReplyAddress, which is currently used to add a Reply-To
header on notification mails. WTF? :)
We should probably refactor all this address crap...
Chad Horohoe [Fri, 1 Aug 2008 16:22:51 +0000 (16:22 +0000)]
Remove global that exists nowhere but here.
Daniel Friesen [Fri, 1 Aug 2008 15:50:59 +0000 (15:50 +0000)]
Bugfix... PHP Notice outputted cause $skin was used in hook instead of $this.
Aryeh Gregor [Fri, 1 Aug 2008 15:13:14 +0000 (15:13 +0000)]
More profiling points for Linker::link(). And that's enough work on it for the moment.
Aryeh Gregor [Fri, 1 Aug 2008 15:09:57 +0000 (15:09 +0000)]
Convert two more Parser uses, no parser test failures. Any more conversions look like they'll have to get the parser to use arrays for query strings instead of storing them as strings.
Aryeh Gregor [Fri, 1 Aug 2008 15:02:46 +0000 (15:02 +0000)]
Start finding more bugs in Linker::link() by having the Parser use it, and running the parser tests.
* Support class="extiw"
* Do not double the fragment for external links with fragments. Move the code for this into a new Title::getLinkUrl() instead of a Linker method, because it seems like a useful concept to be able to get a *usable* link to the current Title.
* Fix a few parser tests that expected attributes in the opposite order.
* Don't overwrite actions for broken links.
* Style
If you want me to stop doing this, by the way, please say so before I spend too many more hours of my life on it.
Daniel Friesen [Fri, 1 Aug 2008 14:40:05 +0000 (14:40 +0000)]
New hook SkinBuildSidebar to allow extensions to modify the sidebar to do things like adding custom portlets.
Aryeh Gregor [Fri, 1 Aug 2008 14:33:14 +0000 (14:33 +0000)]
Revert 38348 and fix properly. $text must be raw HTML to allow things like images to be the link text. Use Xml::openElement() and Xml::closeElement() instead of Xml::element().
Aryeh Gregor [Fri, 1 Aug 2008 14:18:27 +0000 (14:18 +0000)]
Quick, how many days in
2592000 seconds? Yeah, I needed a calculator too.
Rotem Liss [Fri, 1 Aug 2008 13:03:34 +0000 (13:03 +0000)]
Properly escape URL fragment in Linker::link (using Title::getFragementForURL), else it breaks in non-ASCII characters. Bug reported by Hebrew Wikipedia users.
Siebrand Mazeland [Fri, 1 Aug 2008 10:57:38 +0000 (10:57 +0000)]
Revert removal of 2 core messages in r38352. Still in use.
* accmailtitle
* accmailtext
Siebrand Mazeland [Fri, 1 Aug 2008 10:38:14 +0000 (10:38 +0000)]
Remove 6 unused core messages
* whitelistreadtitle
* whitelistreadtext
* whitelistacctitle
* whitelistacctext
* accmailtitle
* accmailtext
Rotem Liss [Fri, 1 Aug 2008 10:15:29 +0000 (10:15 +0000)]
Fixing two double-escaping problems in Linker::link (Xml::element escapes the element text):
* In Linker::userLink - already live in Wikimedia sites.
* When no text is given, i.e. in Linker::linkText.
Also fixing documentation comment to prevent more mistakes.
Siebrand Mazeland [Fri, 1 Aug 2008 10:11:29 +0000 (10:11 +0000)]
Remove 2 unused core messages "movenologin", "movenologintext".
Appears to be used in 1 extension. May need fixing.
(not stable) extensions/LiquidThreads/LqtPages.php: $this->output->showErrorPage( 'movenologin', 'movenologintext' );
Alexandre Emsenhuber [Fri, 1 Aug 2008 09:44:47 +0000 (09:44 +0000)]
* (bug 14987) Only fix double redirects on page move when the checkbox is checked
Huji [Fri, 1 Aug 2008 09:35:41 +0000 (09:35 +0000)]
Localisation updates: Adding/updating Persian translations
Alexandre Emsenhuber [Fri, 1 Aug 2008 09:22:39 +0000 (09:22 +0000)]
Remove call to Linker::postParseLinkColour() which is useless and deprecated
Brion Vibber [Fri, 1 Aug 2008 02:02:08 +0000 (02:02 +0000)]
Fix regression from r38325 -- caused first character of section name in a history link to be trimmed.
Title::setFragment() does not do what you'd think it does. :)
Aryeh Gregor [Fri, 1 Aug 2008 01:47:02 +0000 (01:47 +0000)]
(bug 14995 again) Fix behavior of link() when it's provided with Titles that have no text, only a fragment. getLocalURL() doesn't work here either. Can we have a function that actually means "generate a link to whatever this Title points at"?
Also remove, as Tim so eloquently terms it, "that crap in the release notes", which I also think is unnecessary and crufty.
Aryeh Gregor [Fri, 1 Aug 2008 01:37:07 +0000 (01:37 +0000)]
Use Linker::link() in a couple more places, since I want to break lots more bits of the site interface. Also clean up Skin::nameAndLogin(), although it's seemingly only used in Standard.
Aryeh Gregor [Fri, 1 Aug 2008 01:03:26 +0000 (01:03 +0000)]
Revert 38323 for now. Causes massive parser test failure. Also needs to update RELEASE-NOTES.
Aryeh Gregor [Fri, 1 Aug 2008 00:55:29 +0000 (00:55 +0000)]
Rollback links should not get new/mw-redirect/stub classes, either.
Aryeh Gregor [Fri, 1 Aug 2008 00:54:08 +0000 (00:54 +0000)]
(bug 14997) Rollback links now work again, yay! But doesn't the code look so much prettier?
Aryeh Gregor [Fri, 1 Aug 2008 00:47:26 +0000 (00:47 +0000)]
(bug 14995) Some link fragments in the interface stopped appearing, because Title::getLocalURL() doesn't include the fragment. For some reason Title::getFullURL() does, however . . . more functions to clean up? :)
Siebrand Mazeland [Fri, 1 Aug 2008 00:30:13 +0000 (00:30 +0000)]
Adding links to a lot of messages to improve usability.
Jon Harald Søby [Fri, 1 Aug 2008 00:22:39 +0000 (00:22 +0000)]
Changing the code rendered for headers; removing <a name="$anchor">, making into <h# id="$anchor"> instead. This removes one line from the output code, but more importantly enables CSS marking of a title based on its id. Probably not backwards-compatible with browsers like IE4 (brion checked with IE5) and Netscape 4, but hey, who cares?
Brion Vibber [Thu, 31 Jul 2008 23:20:37 +0000 (23:20 +0000)]
Revert r38302,38306 -- "Add an order by to the list of watched pages."
This looks wrong -- an order by title wouldn't be indexed properly, and could be rather slow.
Chad Horohoe [Thu, 31 Jul 2008 22:06:54 +0000 (22:06 +0000)]
Not setting various parameters no longer causes the ForeignAPIRepo to fail horribly. Thanks to Siebrand for pointing it out.
Siebrand Mazeland [Thu, 31 Jul 2008 21:50:17 +0000 (21:50 +0000)]
Localisation updates for core messages from Betawiki (2008-07-31 23:37 CEST)
Siebrand Mazeland [Thu, 31 Jul 2008 21:33:50 +0000 (21:33 +0000)]
Update 'sma' to 'Åarjelsaemien'.
Siebrand Mazeland [Thu, 31 Jul 2008 21:31:01 +0000 (21:31 +0000)]
Localisation updates for core from Betawiki
Bryan Tong Minh [Thu, 31 Jul 2008 20:10:36 +0000 (20:10 +0000)]
API: Added iiprop=bitdepth to imageinfo and aiprop=bitdepth to allimages
Aryeh Gregor [Thu, 31 Jul 2008 17:04:56 +0000 (17:04 +0000)]
(bug 14990) Don't hardcode MySQL backticks in table names for parser tests. Instead, switch the database prefix back and forth. This doesn't seem to either trash my wiki or change how well the parser tests run, but if you run this on Wikipedia without testing please don't blame me if it drops all tables on the :)
Of course, $wgDBprefix is not meant to be changed a few dozen times every time a script is run, but I don't think it will cause problems. If it does, an alternative would be supporting a $prefix parameter to Database::tableName().
Aryeh Gregor [Thu, 31 Jul 2008 16:34:33 +0000 (16:34 +0000)]
Fix r38302:
* PHP syntax error: mixing double and single quotes
* Probably an SQL syntax error too, due to lack of a space, unless "wl_user = 123ORDER BY wl_title" works in non-MySQL databases. It doesn't in MySQL, and if it does in other engines, it probably shouldn't. :)
Greg Sabino Mullane [Thu, 31 Jul 2008 16:19:15 +0000 (16:19 +0000)]
Not so verbose, please.
Greg Sabino Mullane [Thu, 31 Jul 2008 16:18:59 +0000 (16:18 +0000)]
Add separate index for watchlist(wl_user) [Postgres]
Greg Sabino Mullane [Thu, 31 Jul 2008 16:14:32 +0000 (16:14 +0000)]
Add an order by to the list of watched pages.
Jon Harald Søby [Thu, 31 Jul 2008 14:05:29 +0000 (14:05 +0000)]
Putting #mw_header in one line in Modern; this way, when you triple-click then copy-paste the title of a page (in Firefox), you won't get two newlines as well.
Meno25 [Thu, 31 Jul 2008 10:53:09 +0000 (10:53 +0000)]
Update magic words
Tim Starling [Thu, 31 Jul 2008 09:41:28 +0000 (09:41 +0000)]
$wgCleanSignatures to disable Parser::cleanSig(). Requested by Wikia.
Aaron Schulz [Thu, 31 Jul 2008 07:39:05 +0000 (07:39 +0000)]
set baserevid (part of bug 14984)
Chad Horohoe [Thu, 31 Jul 2008 02:44:56 +0000 (02:44 +0000)]
I honestly have no clue how this got committed; wasn't even using subversion. I really need some sleep it seems.
Chad Horohoe [Thu, 31 Jul 2008 02:28:49 +0000 (02:28 +0000)]
Shinjiman [Thu, 31 Jul 2008 01:37:53 +0000 (01:37 +0000)]
Localisation updates Chinese
Last minute changes for the release branch 1.13
Shinjiman [Thu, 31 Jul 2008 01:36:18 +0000 (01:36 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese
Chad Horohoe [Thu, 31 Jul 2008 01:01:26 +0000 (01:01 +0000)]
Syntax fix.
Jon Harald Søby [Wed, 30 Jul 2008 23:41:02 +0000 (23:41 +0000)]
Adding accesskey="s" to forms in the following special pages:
* Special:BlockIP
* Special:EmailUser
* Special:ExpandTemplates
* Special:Export
* Special:Import
* Special:ParserDiffTest
* Special:UserRights
Aryeh Gregor [Wed, 30 Jul 2008 23:33:13 +0000 (23:33 +0000)]
Add twelve new parser tests, of which four fail, to cover bug 6200. Brings failing tests back up to 15 for me.
Aryeh Gregor [Wed, 30 Jul 2008 22:39:40 +0000 (22:39 +0000)]
Change the results for 6 out of 17 failing parser tests so that they pass. Now only 11 tests fail for me. The remaining outcomes are:
* Invalid XML (this is nine of them)
* Double apostrophes in a link
* Something about language variants that I don't understand and so will leave alone
Aryeh Gregor [Wed, 30 Jul 2008 22:02:23 +0000 (22:02 +0000)]
Use Sanitizer::mergeAttributes() for Linker::linkAttribs(). Also clean up whitespace for mergeAttributes and reduce number of nested functions, and don't try to merge non-string 'class' arguments. This last point is necessary so I can have 'class' => false work right for linkAttribs(), but it makes sense. Parser tests pass.
Aryeh Gregor [Wed, 30 Jul 2008 21:52:15 +0000 (21:52 +0000)]
As Brion points out, Linker::linkUrl() duplicates wfArrayToCGI. Fix that, and also respace/expand a comment in Title.php.
Aryeh Gregor [Wed, 30 Jul 2008 21:11:17 +0000 (21:11 +0000)]
Add a comment, and fix up another. Writing the documentation before you write the code is nice, until you scale back what the code tries to achieve and the documentation becomes wrong. :)
Aryeh Gregor [Wed, 30 Jul 2008 21:02:28 +0000 (21:02 +0000)]
New Linker::link() function, intended to replace Linker::make*Link*() functions. Cleaner interface and more cleanly written. Convert a bunch of stuff to use it. All parser tests pass (except the usual 17).
Rotem Liss [Wed, 30 Jul 2008 20:48:14 +0000 (20:48 +0000)]
Localization update for he.
Brion Vibber [Wed, 30 Jul 2008 20:14:52 +0000 (20:14 +0000)]
Revert r38214 (IPv6 check for $wgServerName) -- failing to load IP class in some situations as seen on Wikimedia live installation.
Haven't been able to reproduce locally, though.
Aryeh Gregor [Wed, 30 Jul 2008 19:55:44 +0000 (19:55 +0000)]
Fix fatal error trying to run parser tests:
Notice: Undefined variable: prevResults in /var/www/trunk/phase3/maintenance/parserTests.inc on line 1098
Fatal error: Unsupported operand types in /var/www/trunk/phase3/maintenance/parserTests.inc on line 1098
Brion Vibber [Wed, 30 Jul 2008 19:55:11 +0000 (19:55 +0000)]
Revert r38229:
"* Add a nice fieldset for consistency
* Switch result line and input form
* Do not show result line "Below is a list of 0 files...". We have the message 'noimages' instead."
Fieldset label duplicates inputbox label, which looks kind of odd to me.
Moving lines around when set is empty changes the click hotspot for "Show new images since..." link, which is pretty annoying when following new uploads
Brion Vibber [Wed, 30 Jul 2008 19:45:35 +0000 (19:45 +0000)]
Revert r38221, 38238 -- "Add new parser function {{apiurl}}. Also, add new global $wgApiScript because manually constructing the api script's path seemed like a bad idea."
I don't really like this in general; the API isn't meant for the UI and there should be little to no call to link to it from body content.
Additionally, I believe we're trying to move all new parser functions to the convention of using the # prefix to avoid conflict with the template namespace.
Rotem Liss [Wed, 30 Jul 2008 17:32:06 +0000 (17:32 +0000)]
Localization update for he.
Jon Harald Søby [Wed, 30 Jul 2008 14:14:42 +0000 (14:14 +0000)]
Fixing capitalisation in two English messages
Chad Horohoe [Wed, 30 Jul 2008 14:09:02 +0000 (14:09 +0000)]
I love case-sensitivity. Don't you?
Raimond Spekking [Wed, 30 Jul 2008 14:05:20 +0000 (14:05 +0000)]
Partly revert of r38236. looks like a commit accident by Jhs
Jon Harald Søby [Wed, 30 Jul 2008 13:58:55 +0000 (13:58 +0000)]
Changing User:E's blog link from search to feed, so it works properly
Raimond Spekking [Wed, 30 Jul 2008 13:20:38 +0000 (13:20 +0000)]
Remove unused var $dims
Shinjiman [Wed, 30 Jul 2008 13:12:13 +0000 (13:12 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese
Raimond Spekking [Wed, 30 Jul 2008 11:30:56 +0000 (11:30 +0000)]
Add myself :)
Raimond Spekking [Wed, 30 Jul 2008 11:29:18 +0000 (11:29 +0000)]
* Add a nice fieldset for consistency
* Switch result line and input form
* Do not show result line "Below is a list of 0 files...". We have the message 'noimages' instead.
Raimond Spekking [Wed, 30 Jul 2008 10:42:18 +0000 (10:42 +0000)]
Add text for header of the patrol log for consistency with all other log headers.
Raimond Spekking [Wed, 30 Jul 2008 10:13:17 +0000 (10:13 +0000)]
Add/change a few punctuation marks (.) for consistency with other header/summary messages.
Siebrand Mazeland [Wed, 30 Jul 2008 09:17:20 +0000 (09:17 +0000)]
Localisation updates for extension messages from Betawiki (2008-07-30 11:03 CEST)
Chad Horohoe [Wed, 30 Jul 2008 07:46:25 +0000 (07:46 +0000)]
Add new parser function {{apiurl}}. Also, add new global $wgApiScript because manually constructing the api script's path seemed like a bad idea.
Huji [Wed, 30 Jul 2008 07:30:22 +0000 (07:30 +0000)]
Localisation updates: Adding/updating Persian translations
Victor Vasiliev [Wed, 30 Jul 2008 07:23:22 +0000 (07:23 +0000)]
* (bug 14968) Specifying blank action parameter triggers API error now
Purodha B Blissenbach [Wed, 30 Jul 2008 07:19:13 +0000 (07:19 +0000)]
Superfluous unneccessary html markup removed from 3 messages.
Chad Horohoe [Wed, 30 Jul 2008 04:13:30 +0000 (04:13 +0000)]
The documented setting on MW.org (and in DefaultSettings) is $wgSearchForwardUrl, so tweaked Special:Search to use the newer (and better) titled setting. Should make it actually work as advertised now.
Chad Horohoe [Wed, 30 Jul 2008 03:23:38 +0000 (03:23 +0000)]
(bug 14977) Installations on servers using IPv6 addresses for $wgServer were largely unusable because $wgServer didn't wrap the IP in brackets
Chad Horohoe [Wed, 30 Jul 2008 03:07:54 +0000 (03:07 +0000)]
Bah! Partial revert of r38212. Unrelated file snuck into my commit window.
Chad Horohoe [Wed, 30 Jul 2008 03:05:23 +0000 (03:05 +0000)]
Remove unused $wgServer global.
Shinjiman [Wed, 30 Jul 2008 01:55:35 +0000 (01:55 +0000)]
Localisation updates Chinese
Last minute changes for the release branch 1.13
Shinjiman [Wed, 30 Jul 2008 01:37:09 +0000 (01:37 +0000)]
Update the Chinese conversion tables
Last minute changes for the release branch 1.13