Fomafix [Mon, 18 Jul 2016 05:33:12 +0000 (05:33 +0000)]
Rename filenames with spaces
Change-Id: I94dd6f9ae9cf855d058955b30bde866e70c94901
Translation updater bot [Sun, 17 Jul 2016 20:03:10 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1ef79558110f52fe4e33a378e4bedd1f7d0966e5
Translation updater bot [Sat, 16 Jul 2016 20:04:15 +0000 (22:04 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I22ac1b8641454231b4b145027de68876bfdb7403
jenkins-bot [Sat, 16 Jul 2016 06:45:52 +0000 (06:45 +0000)]
Merge "Chinese Conversion Table Update 2016-5"
Chiefwei [Sun, 10 Jul 2016 12:40:28 +0000 (20:40 +0800)]
Chinese Conversion Table Update 2016-5
Update the Chinese conversion table routinely to fix bugs reported from
https://zh.wikipedia.org/wiki/Wikipedia:%E5%AD%97%E8%AF%8D%E8%BD%AC%E6%8D%A2/%E4%BF%AE%E5%A4%8D%E8%AF%B7%E6%B1%82 .
It is only data changes and only works for Chinese WikiProjects.
Change-Id: I63054fc4a6cdc6e0fc350a6509ca1154f9464f42
Translation updater bot [Fri, 15 Jul 2016 19:54:16 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I59ddd452a76279db71a1d6dbf067a8cd23791834
Kunal Mehta [Fri, 10 Jun 2016 20:11:01 +0000 (13:11 -0700)]
registration: Add test to check extension.json globals are documented
Verify that all the global settings listed in
ExtensionProcessor::$globalSettings are documented in the extension.json
schema.
Change-Id: If0ed09ed19b92934e869bbd40d8716a83e4b0a30
jenkins-bot [Fri, 15 Jul 2016 13:58:50 +0000 (13:58 +0000)]
Merge "Make LocalFile::lock() initialize DBO_TRX transactions"
jenkins-bot [Fri, 15 Jul 2016 13:58:45 +0000 (13:58 +0000)]
Merge "Make pre-commit DB callbacks more atomic with multi-DB updates"
Aaron Schulz [Thu, 14 Jul 2016 03:45:20 +0000 (20:45 -0700)]
Use proper SELECT options in User::idFromName() for locking
Change-Id: Ia3ec245ecf5bb2fe7996828696b09f12a8ce10e1
jenkins-bot [Fri, 15 Jul 2016 00:01:38 +0000 (00:01 +0000)]
Merge "Upgrade error logging when implicit transactions are committed early"
Aaron Schulz [Thu, 14 Jul 2016 21:51:25 +0000 (14:51 -0700)]
Make LocalFile::lock() initialize DBO_TRX transactions
If the first query to the master DB is after lock() and DBO_TRX is
set, make sure that the LocalFile updates still join the implicit
transaction that the rest of the request is in.
This helps keep the commit step tight when multiple DBs are touched
by making sure that the main DB commits in commitMasterChanges()
along with any others.
Bug: T119736
Change-Id: I6cc29f9201947e4415336528d30cba7f88567b41
Aaron Schulz [Thu, 14 Jul 2016 23:29:21 +0000 (16:29 -0700)]
Make pre-commit DB callbacks more atomic with multi-DB updates
Bug: T119736
Change-Id: I141903145aae0f6874f4e631624e52b6b9d8a4c8
jenkins-bot [Thu, 14 Jul 2016 21:57:33 +0000 (21:57 +0000)]
Merge "resourceloader: Update expected length of module version hash"
Ori Livneh [Wed, 13 Jul 2016 22:43:08 +0000 (15:43 -0700)]
resourceloader: Update expected length of module version hash
It's 7, not 8, as of I1e4fb08d179.
Change-Id: I882bf7075292ff849f2bc3af61217f7e38a4ec5f
jenkins-bot [Thu, 14 Jul 2016 21:38:56 +0000 (21:38 +0000)]
Merge "Hide marked empty elements by default (stage 1)"
Tim Starling [Wed, 13 Jul 2016 02:01:59 +0000 (12:01 +1000)]
Hide marked empty elements by default (stage 1)
We originally imagined rolling out the display of empty elements
simultaneously with the Html5Depurate, but now we have added support for
marking empty elements to Html5Depurate and plan on having some sort of
longer migration period. So, move the relevant CSS to content.css, and
remove the concept of CSS dependant on tidy driver.
Add a body class which will allow the effect to be toggled in a gadget or
extension. Actual toggling in the CSS will be in the stage 2 patch, to be
deployed after the varnish cache and parser cache have expired.
I originally imagined that there would be a gadget that overrides the
rule with an !important selector, but that method does not allow you to
recover the original display property, which is often overridden by the
style attribute or site CSS to be "inline".
Also, in RaggettWrapper, switch to the new class mw-empty-elt, following
Html5Depurate, instead of mw-empty-li. The old class will be removed in
the stage 2 patch.
Change-Id: Ic0f432c43a006629ca5a1a7c2dda3552ceb4dc4f
jenkins-bot [Thu, 14 Jul 2016 21:08:53 +0000 (21:08 +0000)]
Merge "AuthManager: Break AuthPlugin::addUser more explicitly"
Translation updater bot [Thu, 14 Jul 2016 20:04:31 +0000 (22:04 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib93bbea5f21ed351de36fdf88f864d6f0a678da0
jenkins-bot [Thu, 14 Jul 2016 19:50:33 +0000 (19:50 +0000)]
Merge "resourceloader: Track state of page-style modules"
Timo Tijhof [Tue, 10 May 2016 19:00:44 +0000 (20:00 +0100)]
resourceloader: Track state of page-style modules
This allows dynamically loaded modules to depend on page-style modules
without it causing the page-style module to be loaded a second time.
* New method Module::getType() indicates whether a module is
a page-style module or supposed to be dynamically loaded.
* Emit warning from addModuleStyles() when given a module that is
not a page-style module (to be enforced later)
Bug: T92459
Bug: T87871
Change-Id: I8b6c6a10d965e73965f877c42e995d04202524f3
Bartosz Dziewoński [Thu, 14 Jul 2016 18:59:44 +0000 (18:59 +0000)]
Revert "mediawiki.toolbar: temporary workaround for T113868"
No longer needed after
280d29215a89ecc68cf860a25f28f7091707a107.
This reverts commit
08cb9076d4903578591c61fff93905d9bddd7237.
Bug: T113868
Change-Id: I480f70fdc223db9c8083e7ee5b5be8d91a8c60c0
jenkins-bot [Thu, 14 Jul 2016 16:26:20 +0000 (16:26 +0000)]
Merge "DumpStringOutput: Rename getOutput() to __toString()"
jenkins-bot [Thu, 14 Jul 2016 13:12:27 +0000 (13:12 +0000)]
Merge "registration: Convert "config" into an object with metadata"
Kevin Israel [Thu, 14 Jul 2016 10:28:16 +0000 (06:28 -0400)]
DumpStringOutput: Rename getOutput() to __toString()
Though getOutput() is what first came to mind, I do not particularly
like the name, partly because it is used in many, many places as a
method that returns an OutputPage object.
* Renamed the method to __toString(). This is appropriate because
each instance, at any given time, corresponds to a single string
value (and exceptions cannot occur during this conversion).
* Removed unnecessary variables from ApiQuery and ExportTest. In
these and most other cases, it should no longer be necessary to
call getOutput() explicitly.
Change-Id: Icf202743d1f332f8981338f42eb6e3e5a04abdf1
Niklas Laxström [Thu, 14 Jul 2016 07:37:32 +0000 (09:37 +0200)]
Add Shan (shn)
Bug: T135867
Change-Id: I6cd17284b82f6cab0b1fe12557005f0ac541f1e9
Kunal Mehta [Wed, 13 Jul 2016 23:54:38 +0000 (16:54 -0700)]
SpecialLog: Add help link
Bug: T140013
Change-Id: Ief7b596e9972911106a55a4d2353a63a1ca0a436
Kunal Mehta [Wed, 22 Jun 2016 22:33:35 +0000 (00:33 +0200)]
registration: Convert "config" into an object with metadata
To add extra metadata for "config" options without constantly adding
hacky underscore prefixed keys, convert "config" items into an object,
where the value is under a "value" key.
"_merge_strategy" is now just "merge_strategy", but still has the
underscore prefix for the cache structure, to avoid changing it.
Since this is a fully breaking change, it only applies to files with
manifest_version: 2 set. A conversion script has been added to assist
with automated conversion.
Bug: T133626
Change-Id: Id1071fc0647892438e5cd0e3ee621fbdaaa64014
Translation updater bot [Wed, 13 Jul 2016 20:02:32 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I9aa72a1de8d331e8f2b2b832a50effc8c97a8763
jenkins-bot [Wed, 13 Jul 2016 12:14:17 +0000 (12:14 +0000)]
Merge "mw.widgets.CategorySelector: Avoid JS exceptions for invalid user input"
jenkins-bot [Wed, 13 Jul 2016 09:28:11 +0000 (09:28 +0000)]
Merge "API: Remove index forcing in ApiQueryRecentChanges"
jenkins-bot [Tue, 12 Jul 2016 23:26:38 +0000 (23:26 +0000)]
Merge "Don't use $wgContentNamespaces directly"
Kunal Mehta [Fri, 27 May 2016 17:21:27 +0000 (10:21 -0700)]
Don't use $wgContentNamespaces directly
Change-Id: If8ed1bf7e7c6429c405c956413af07a191ec9c40
Kunal Mehta [Tue, 12 Jul 2016 22:10:25 +0000 (15:10 -0700)]
MWExceptionHandler: Fix PHP7 compatibility
The `Exception` type-hint will cause issues if a PHP7 `Error` is thrown.
Change-Id: Iab0af90235badd57304131ae2274a1cfa0be822a
Tim Starling [Thu, 7 Apr 2016 02:24:29 +0000 (12:24 +1000)]
Rewrite TidySupport and add option --use-tidy-config
* Have TidySupport provide $wgTidyConfig instead of the legacy globals
* Add --use-tidy-config option to parserTests.php. This tells
TidySupport to use the tidy configuration from LocalSettings.php
instead of the traditional safe defaults.
* Add a way for TidySupport to disable tidy via $wgTidyConfig, using
driver=>disabled
Change-Id: Ie76e68e2d5238d0a1aef49a1a815c0d1cd8bfdae
James D. Forrester [Tue, 12 Jul 2016 20:30:06 +0000 (13:30 -0700)]
Update OOjs UI to v0.17.6
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.17.6
Change-Id: I82b26aa68c7402346c449cafb3f6ec9b772bc5c6
Translation updater bot [Tue, 12 Jul 2016 20:11:51 +0000 (20:11 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Tue, 12 Jul 2016 20:07:01 +0000 (20:07 +0000)]
Merge "Balancer: Inline BalancerStack::length()"
jenkins-bot [Tue, 12 Jul 2016 20:03:14 +0000 (20:03 +0000)]
Merge "Balancer: remove all Assert::parameterType() calls"
Translation updater bot [Tue, 12 Jul 2016 20:02:29 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Icab7d562d8131e2c59b5f3d7c51d2a94f0ea3945
jenkins-bot [Tue, 12 Jul 2016 20:00:00 +0000 (20:00 +0000)]
Merge "Balancer: Introduce BalanceElement::isHtmlNamed()"
jenkins-bot [Tue, 12 Jul 2016 19:58:23 +0000 (19:58 +0000)]
Merge "Balancer: cache BalanceStack::currentNode()"
Timo Tijhof [Thu, 7 Jul 2016 19:26:36 +0000 (20:26 +0100)]
OutputPage: Make use of WrappedStringList in headElement()
Right now, getInlineHeadScripts(), buildCssLinks() and getExternalHeadScripts()
all return WrappedString::join(). But because they don't know about each other
and because they need to return strings (not arrays), headElement() has no way
of merging them.
WrappedStringList allows this array to be kept, whilst still being backward-compatible
with code that calls these methods and assumig a string (since it will lazy-join
the array if the object is treated like a string).
To be used by I8b6c6a10d965e7396. Output is not changed in this commit.
Merely refactoring.
Change-Id: Iae08345473bd93cc0948d51b62c48aeb1ea460a3
jenkins-bot [Tue, 12 Jul 2016 18:06:51 +0000 (18:06 +0000)]
Merge "Add any prior block to BlockIpComplete hook"
Brad Jorsch [Tue, 12 Jul 2016 17:35:10 +0000 (13:35 -0400)]
AuthManager: Commit transaction after auto-creating a user
As things stand now, DBO_TRX or DBO_DEFAULT will cause a transaction to
be started, and then anything in the entire request failing will
probably cause the newly-added user row to be lost. But updates to
external databases (e.g. CentralAuth) likely won't be since those DB
connections were probably shut down after the update was completed.
So let's explicitly commit changes af the end of auto-creation so that
problems with the request itself don't undo it.
Bug: T119736
Change-Id: I6c13c8feb86d8b9a01df894733c38445d048fea0
Brad Jorsch [Tue, 12 Jul 2016 15:29:04 +0000 (11:29 -0400)]
API: Remove index forcing in ApiQueryRecentChanges
It's preventing better indexes from being chosen; hopefully removing it
doesn't cause worse indexes to be chosen anymore in other cases.
Bug: T140108
Change-Id: Iee480e221dc26f89e8583be5f26c6571b240e390
Ed Sanders [Tue, 12 Jul 2016 13:48:58 +0000 (14:48 +0100)]
Rename 'slider' gallery mode to 'slideshow'
Bug: T140093
Change-Id: I6f01344b9ac61e3d2a8e7a9d920ba37786537ff8
Tim Starling [Tue, 5 Jul 2016 10:32:44 +0000 (20:32 +1000)]
Balancer: Inline BalancerStack::length()
Provides 1% reduction in benchmark time
Change-Id: Ie8ff66a836cd137234828effcce9547e2cb3cd58
Tim Starling [Tue, 5 Jul 2016 09:09:36 +0000 (19:09 +1000)]
Balancer: remove all Assert::parameterType() calls
Profiling shows they are especially expensive. 29% reduction in
benchmark time.
Change-Id: I5206b05007c7e1d6552974bcd7c57aa03eea231d
Tim Starling [Tue, 5 Jul 2016 05:41:55 +0000 (15:41 +1000)]
Balancer: Introduce BalanceElement::isHtmlNamed()
An optimised special case of BalanceElement::isA, reducing benchmark
time by 4%
Change-Id: I1204de9454eb7b8f9f3a5ed137218c3293f9ab27
Tim Starling [Tue, 5 Jul 2016 02:50:24 +0000 (12:50 +1000)]
Balancer: cache BalanceStack::currentNode()
Make currentNode into a public property instead of a function call, for
a performance improvement of about 4%.
Change-Id: I89861557531c55a63abef52c0acabbfb5c155bda
Tim Starling [Mon, 4 Jul 2016 05:15:18 +0000 (15:15 +1000)]
Some Balancer improvements for performance and compatibility
* Use a doubly-linked list for the AFE list, instead of an array,
allowing efficient insertion and removal from the middle, and trivial
O(1) lookup of existing elements.
* Use a hashtable of singly-linked lists for storing Noah's Ark buckets,
instead of iterating through the entire AFE list on every push.
* Store attributes in an array instead of serializing them in the
tokenizer. This allows us to avoid sorting them in the output. For the
Noah's Ark clause, the array is copied and then sorted on demand.
* XHTML-style serialization with self-closing tags.
* Clear the AFE list in stopParsing(), otherwise all the BalanceElement
objects are kept alive until after serialization, thus using O(N^2)
memory (in stack depth N) since the full serialization is stored at
each stack level.
Change-Id: I517129c0658f03eb2ddee61fdf33ffe6fbd48509
C. Scott Ananian [Tue, 14 Jun 2016 21:59:20 +0000 (17:59 -0400)]
Hook up Balancer as a Tidy implementation.
This is an HTML5-compliant parse/serialize tidy implementation, with
well-delineated hacks to support the <p>-wrapping done by legacy tidy.
Change-Id: I4fd433fd6f1847061b0bf4b3e249c918720d4fae
C. Scott Ananian [Tue, 15 Mar 2016 19:13:43 +0000 (15:13 -0400)]
HTML5 Balancer
This adds an implementation of the HTML5 Tree Builder algorithm to PHP,
along with test cases from the tree builder derived from the
html5lib-tests package on github. The test cases were preprocessed
into JSON for the `domino` HTML5 parser, and we're using the JSON
form of the tests.
The implementation follows both the language of the HTML5 specification
and the implementation in `domino` very closely, easing updates if the
specification changes.
This code is used in follow-on commits to support an HTML5-based
"tidy" for mediawiki and the `{{#balance}}` parser function, which
ensures that a template expands to properly-balanced HTML, with all
tags closed and nothing left on the HTML active formatting elements
list.
See: https://github.com/fgnass/domino
Change-Id: I6f4d20a43510dd819776bb333b639315b19d150d
C. Scott Ananian [Wed, 4 May 2016 18:01:00 +0000 (14:01 -0400)]
Add tracking category when editors use the deprecated self-closed tag hack.
Some pages use constructs like `<b/>` or `<span/>` to protect spaces or
special characters at the beginning/end of templates. This syntax is
incompatible with HTML5 parsing rules, which dictate that these should
be treated as open tags, and instead rely on an unusual quirk of the
`tidy` program that removes invalid constructs.
This syntax is deprecated as part of the process of reconciling `tidy`
with modern HTML5 parsing semantics. Authors can use ` ` or `<nowiki/>`
as valid replacements.
In order to provide time to transition existing content, pages using
self-closing tags in violation of the HTML5 parsing specification
will have their templates/pages added to a new tracking category.
After these uses are fixed, we will change the sanitizer to treat these
as normal open tags, to be consistent with the HTML5 parsing spec.
Note that this construct is already disallowed if tidy is disabled; it
is rendered as `<b/>`. We add a tracking category in the no-tidy
case as well, in preparation for eventually making the no-tidy and
with-tidy behaviors consistent.
Bug: T134423
Change-Id: Ie1cf3aa40d5483bf395ece539f0240b694ff04ab
jenkins-bot [Tue, 12 Jul 2016 00:40:58 +0000 (00:40 +0000)]
Merge "Improve comments on fields and fix opening_text - needs no highlights."
Translation updater bot [Mon, 11 Jul 2016 20:03:45 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic1d591a09a31a027c0799e6833a302bb4de9477e
jenkins-bot [Mon, 11 Jul 2016 19:38:51 +0000 (19:38 +0000)]
Merge "mw.Upload.BookletLayout: Better handle error messages from AbuseFilter and TitleBlacklist"
jenkins-bot [Mon, 11 Jul 2016 19:34:49 +0000 (19:34 +0000)]
Merge "ApiUpload: Better handle ApiMessage errors from UploadVerifyFile hook"
jenkins-bot [Mon, 11 Jul 2016 16:25:33 +0000 (16:25 +0000)]
Merge "Move span.comment back to shared.css as its more widely used"
Prateek Saxena [Sun, 10 Jul 2016 05:08:30 +0000 (10:38 +0530)]
Move span.comment back to shared.css as its more widely used
...than the other changeslist CSS classes. This commit partially
reverts
9e458504c7b4.
Bug: T139722
Bug: T139832
Bug: T139833
Bug: T139835
Bug: T139836
Bug: T139837
Bug: T139838
Bug: T139839
Bug: T139840
Bug: T139841
Change-Id: Ia4a7b6d0d19f0f62cd2402cd81f944ab31fb84c0
jenkins-bot [Mon, 11 Jul 2016 16:03:20 +0000 (16:03 +0000)]
Merge "build: Bump grunt-karma and related tools to 1.0.x"
Brad Jorsch [Mon, 11 Jul 2016 15:16:18 +0000 (11:16 -0400)]
Update documentation for I30e359fb
Change-Id: I3a13c02ecaf76ac9affcae1a895a6194466c7658
Paladox [Tue, 28 Jun 2016 17:12:45 +0000 (18:12 +0100)]
build: Bump grunt-karma and related tools to 1.0.x
Also bump karma to 1.1.0 see changelog at
https://github.com/karma-runner/karma/releases please
Change-Id: Ic982dfc7ccebeecd6082b5476372cbb87fec5f1b
jenkins-bot [Mon, 11 Jul 2016 07:59:02 +0000 (07:59 +0000)]
Merge "Make classes actually work in lines in EnhancedChangesList"
jenkins-bot [Mon, 11 Jul 2016 00:58:37 +0000 (00:58 +0000)]
Merge "API: Allow anonymous CORS from anywhere, when specifically requested"
Aaron Schulz [Sun, 10 Jul 2016 23:39:31 +0000 (16:39 -0700)]
Upgrade error logging when implicit transactions are committed early
Change-Id: If976a405cd1374e70fc9af76e47b9a3f12c354c9
jenkins-bot [Sun, 10 Jul 2016 23:28:21 +0000 (23:28 +0000)]
Merge "ApiQuery: Don't mess with PHP output buffering"
jenkins-bot [Sun, 10 Jul 2016 23:22:24 +0000 (23:22 +0000)]
Merge "Use READ_LATEST for the WikiPage in RefreshLinksJob"
jenkins-bot [Sun, 10 Jul 2016 23:19:43 +0000 (23:19 +0000)]
Merge "Fix grammar in transaction-duration-limit-exceeded"
jenkins-bot [Sun, 10 Jul 2016 23:15:14 +0000 (23:15 +0000)]
Merge "Use more short array syntax in comments (/tests/)"
jenkins-bot [Sun, 10 Jul 2016 23:12:39 +0000 (23:12 +0000)]
Merge "Parse sidebar message for main page when cache is enabled"
jenkins-bot [Sun, 10 Jul 2016 23:07:40 +0000 (23:07 +0000)]
Merge "Revert "If rev_content_model is null, use page_content_model.""
Legoktm [Sun, 10 Jul 2016 22:58:36 +0000 (22:58 +0000)]
Revert "If rev_content_model is null, use page_content_model."
This patch effectively reverted
a5bc9f49cd01e49c, which
was the correct behavior. If a page were to have its content
model changed, the NULL revision rows would now be interpreted
as the page's new content model instead of the default content
model (which they should be).
This reverts commit
9a6ff0bd82faafbf9746a6fa3ed33f42092587c3.
Change-Id: I6801d09bd847f477222e503b912005b02a9df045
jenkins-bot [Sun, 10 Jul 2016 21:42:29 +0000 (21:42 +0000)]
Merge "Remove old WebResponse::setCookie() calling method"
Reedy [Sun, 10 Jul 2016 20:44:18 +0000 (21:44 +0100)]
composer/semver 1.4.0 -> 1.4.1
https://github.com/composer/semver/compare/1.4.0...1.4.1
Depends-On: I29afc0187f0fe0e920c27710ff06ff1d502896e6
Change-Id: Idd09dcee04c5781946079bcec087d15186fb1bea
umherirrender [Sun, 10 Jul 2016 20:17:27 +0000 (22:17 +0200)]
Parse sidebar message for main page when cache is enabled
When the sidebar cache is enabled, parse the messages for the links and
link text of the sidebar with the main page as title, because variable
like FULLPAGENAME would vary on page, but cache does not.
Change-Id: I0bbb05f1abe4be1a61f520d647c8ca696d184ccf
Translation updater bot [Sun, 10 Jul 2016 19:54:23 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5b1be9bfed1741466b7364c6314f8cfe86c27128
umherirrender [Sun, 10 Jul 2016 15:23:29 +0000 (17:23 +0200)]
Use more short array syntax in comments (/tests/)
Change-Id: I86c73cb9447ac562a73348b4030e24ebf49a90dc
Aaron Schulz [Sun, 10 Jul 2016 14:36:31 +0000 (07:36 -0700)]
Fix grammar in transaction-duration-limit-exceeded
Change-Id: I5e9db36abdb4c498c97640790490508452fdefd3
Brad Jorsch [Sun, 10 Jul 2016 13:09:43 +0000 (09:09 -0400)]
AuthManager: Break AuthPlugin::addUser more explicitly
AuthPlugin::addUser() is intended to only touch the external database
without creating a local user, which isn't possible under AuthManager
without reproducing too much of AuthManager's account creation methods
(and risking breaking things in even more obscure ways) to be
worthwhile.
As it is, either this will fail because the caller already called
User::addToDatabase() or the caller's subsequent User::addToDatabase()
call will fail because we're creating the local user.
So instead, let's just throw an exception unconditionally instead of
pretending it could work.
Bug: T137843
Change-Id: I8a439ea190c752a7fc49de5617e2c64c314c38f0
Aaron Schulz [Sun, 10 Jul 2016 11:14:12 +0000 (04:14 -0700)]
Use READ_LATEST for the WikiPage in RefreshLinksJob
Also sanity check that the revision belongs to that page.
Change-Id: I4e6897b52212d9787d74fb017861ec62f2927f0e
jenkins-bot [Sat, 9 Jul 2016 21:18:53 +0000 (21:18 +0000)]
Merge "Add missing colons"
matejsuchanek [Sat, 9 Jul 2016 19:58:36 +0000 (21:58 +0200)]
Add missing colons
Consistent with other log-action-filter-(action) messages.
Bug: T132889
Change-Id: I6b5e98aedd7bec37280684b362ccf936e45f6a30
Translation updater bot [Sat, 9 Jul 2016 19:57:10 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I655debf814eca6ac00daaca122ed838da8c45a9b
Seb35 [Sat, 9 Jul 2016 08:07:49 +0000 (10:07 +0200)]
Handle the default value of $wgExternalDiffEngine without warning
The default value (false) was not handled by the recent depreciation warnings
in
037f056, and was triggering the last warning. This removes this warning.
Change-Id: If7fe92d874eb10525a72f6d3a97f00117c79acc1
Kevin Israel [Fri, 8 Jul 2016 22:52:20 +0000 (18:52 -0400)]
Run generateLocalAutoload.php
Follows-up
ae0bae92afe0307d.
Change-Id: I5f7decd6a5279e941a7e1406dca77bbe37a1f3cb
Kevin Israel [Fri, 8 Jul 2016 20:22:27 +0000 (16:22 -0400)]
ApiQuery: Don't mess with PHP output buffering
Specifically, it is not necessary to use output buffering functions
to capture XML generated by the export code because it is already
possible to set the "output sink" object to be used.
* Created a DumpStringOutput class, which appends all output to a
string property rather than printing output immediately.
* Used that class, instead of ob_start() and ob_get_clean(), in
ApiQuery and ExportTest.
Change-Id: I238f5d5ec7fd442c845b25cb59ef81ac3285099f
daniel [Thu, 7 Jul 2016 13:06:12 +0000 (15:06 +0200)]
If rev_content_model is null, use page_content_model.
We currently leave rev_content_model = null if it'S the default, to save space.
When loading a revision, we so far fell back to the per-namespace default content
model if rev_content_model was null, even if page_content_model was null.
This patch changes the fallback from rev_contentModel -> namespace-default-model
to rev_content_model -> page_content_model -> namespace-default-model.
This will prevent errors triggered when chaing a namespace'sdefault content model:
so far, revisions with the old content model would fail to deserialize becaue,
because they were being interpreted according to the changed namespace defrault,
instead of the correct model in page_content_model.
Bug: T128466
Change-Id: I75c60eb129428b0b433480443ab9153cc58cda8f
Translation updater bot [Fri, 8 Jul 2016 20:33:15 +0000 (22:33 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7c5e1326e76de65612653cb8e8167c7d062fa7c2
Stanislav Malyshev [Fri, 8 Jul 2016 18:52:55 +0000 (11:52 -0700)]
Improve comments on fields and fix opening_text - needs no highlights.
Change-Id: Iad6876aae109ad84c5534619f47c72edc900d704
jenkins-bot [Fri, 8 Jul 2016 19:06:06 +0000 (19:06 +0000)]
Merge "Clarify functionality of 'captionLength' in GalleryOptions"
Ed Sanders [Fri, 8 Jul 2016 17:33:25 +0000 (18:33 +0100)]
TitleWidget: Add missing return documentation
Change-Id: Iea34d7e5dd4c54a13ac559bb2685246e0f096227
Ed Sanders [Fri, 8 Jul 2016 16:23:43 +0000 (17:23 +0100)]
Clarify functionality of 'captionLength' in GalleryOptions
Change-Id: Ieaacec06282785d789ed89acc984b4dff4ad4460
amir [Fri, 8 Jul 2016 09:36:09 +0000 (09:36 +0000)]
Make classes actually work in lines in EnhancedChangesList
Change-Id: I2a1dc712d735077dd3741aa0d066933a81c4e568
Tim Starling [Wed, 9 Mar 2016 04:42:33 +0000 (15:42 +1100)]
New parserTests.php features
Features to support T89331 analysis:
* Support dwdiff for word-level diffing
* Add --mark-ws feature which produces cleaner diffs when line breaks
differ
* Add optional normalization of parser test output, allowing significant
differences to be separated from insignificant differences.
Change-Id: I0e151caad1f8b2f97bf20b219f26f3101be82506
jenkins-bot [Thu, 7 Jul 2016 22:47:22 +0000 (22:47 +0000)]
Merge "API: Generate head items in the context of the given title"
Timo Tijhof [Thu, 7 Jul 2016 18:45:08 +0000 (19:45 +0100)]
Update wikimedia/wrappedstring to v2.1.1
New method to be used in OutputPage.
Depends-On: I18c93dbb29c61c515de74b02d04aea077aadeb52
Change-Id: I70ab1b57cef5b988e215c7c4365b92f7eb9c5693
Translation updater bot [Thu, 7 Jul 2016 20:07:09 +0000 (20:07 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Thu, 7 Jul 2016 19:54:54 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Idc43190454d0d375d7537815a400438c21101171