From: Tim Starling <tstarling@users.mediawiki.org>
Date: Wed, 17 Dec 2008 07:42:46 +0000 (+0000)
Subject: Is this needed? Probably not, but it doesn't hurt. The connection is only used for... 
X-Git-Tag: 1.31.0-rc.0~43915
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/modifier.php?a=commitdiff_plain;h=bb6f68137406df747f41c02f5570ff4da31e1216;p=lhc%2Fweb%2Fwiklou.git

Is this needed? Probably not, but it doesn't hurt. The connection is only used for reading, so the commitMasterChanges() is technically unnecessary but harmless. Without closeAll(), the connection will be held open until the script terminates, but that's probably pretty soon in this case.
---

diff --git a/maintenance/FiveUpgrade.inc b/maintenance/FiveUpgrade.inc
index 3d917e72dd..4fb34308a4 100644
--- a/maintenance/FiveUpgrade.inc
+++ b/maintenance/FiveUpgrade.inc
@@ -77,8 +77,7 @@ class FiveUpgrade {
 	}
 	
 	/**
-	 * Close out the connections when we're done...
-	 * Is this needed?
+	 * Commit transactions and close the connections when we're done...
 	 */
 	function close() {
 		foreach( $this->loadBalancers as $lb ) {