From: Chad Horohoe <chadh@wikimedia.org>
Date: Mon, 21 Nov 2016 21:47:09 +0000 (-0800)
Subject: Exception renderer: Remove useless check for isCommandLine()
X-Git-Tag: 1.31.0-rc.0~4804
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/modifier.php?a=commitdiff_plain;h=524e62463738c5a31a4c6c8d32fc2fdcd6c5aa74;p=lhc%2Fweb%2Fwiklou.git

Exception renderer: Remove useless check for isCommandLine()

If we're on the cli, we would've never hit this else block

Change-Id: Idff009ab255b1907f752e0c6b5652715923b0ed7
---

diff --git a/includes/exception/MWExceptionRenderer.php b/includes/exception/MWExceptionRenderer.php
index 8fdc417c1e..f713115c55 100644
--- a/includes/exception/MWExceptionRenderer.php
+++ b/includes/exception/MWExceptionRenderer.php
@@ -74,11 +74,7 @@ class MWExceptionRenderer {
 					$message = MWExceptionHandler::getPublicLogMessage( $e );
 				}
 			}
-			if ( self::isCommandLine() ) {
-				self::printError( $message );
-			} else {
-				echo nl2br( htmlspecialchars( $message ) ) . "\n";
-			}
+			echo nl2br( htmlspecialchars( $message ) ) . "\n";
 		}
 	}