Merge "WikiPage: Do not set "undid revision ID" for rollbacks"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 29 Jun 2018 23:53:29 +0000 (23:53 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 29 Jun 2018 23:53:29 +0000 (23:53 +0000)
includes/page/WikiPage.php

index ad3c8c5..c25ff35 100644 (file)
@@ -2959,7 +2959,7 @@ class WikiPage implements Page, IDBAccessObject {
                }
 
                $updater->setOriginalRevisionId( $target->getId() );
-               $updater->setUndidRevisionId( $current->getId() );
+               // Do not call setUndidRevisionId(), that causes an extra "mw-undo" tag to be added (T190374)
                $updater->addTags( $tags );
 
                // TODO: this logic should not be in the storage layer, it's here for compatibility