Merge "Fix various minor IDEA warnings in LoadBalancer"

diff --combined includes/libs/rdbms/loadbalancer/LoadBalancer.php
index 856adb2,baab031..14d049c
--- 1/includes/libs/rdbms/loadbalancer/LoadBalancer.php
--- 2/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@@ -31,7 -31,7 +31,7 @@@ use Wikimedia\ScopedCallback
  class LoadBalancer implements ILoadBalancer {
        /** @var array[] Map of (server index => server config array) */
        private $mServers;
 -      /** @var IDatabase[][] Map of (local/foreignUsed/foreignFree => server index => IDatabase array) */
 +      /** @var IDatabase[][][] Map of local/foreignUsed/foreignFree => server index => IDatabase array */
        private $mConns;
        /** @var float[] Map of (server index => weight) */
        private $mLoads;
@@@ -441,12 -441,15 +441,15 @@@
  
        /**
         * @param int $i
-        * @return IDatabase
+        * @return IDatabase|bool
         */
        public function getAnyOpenConnection( $i ) {
                foreach ( $this->mConns as $connsByServer ) {
                        if ( !empty( $connsByServer[$i] ) ) {
-                               return reset( $connsByServer[$i] );
+                               /** @var $serverConns IDatabase[] */
+                               $serverConns = $connsByServer[$i];
+ 
+                               return reset( $serverConns );
                        }
                }