Revert r64853 (add $wgLogAutocreatedAccounts to enable/disable account autocreation...

I don't know what the proper solution is (other than introducing user preferences, like bug 28369 suggests, is not the answer)...but the status quo of what we had is better than this half-assed solution that *nobody* likes.

diff --git a/HISTORY b/HISTORY
index 7dcd728..79b89e1 100644 (file)
--- a/HISTORY
+++ b/HISTORY
@@ -19,8 +19,6 @@ are used instead.
 === Configuration changes in 1.17 ===
 * DatabaseFunctions.php that was needed for compatibility with pre-1.3
   extensions has been removed.
-* $wgLogAutocreatedAccounts controls whether autocreation of accounts is logged
-  to new users log.
 * $wgAllowImageTag can be set to true to whitelist the <img> tag in wikitext.
 * (bug 12797) Add $wgGalleryOptions for adjusting of default gallery display
   options.

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index c7d2876..36daef4 100644 (file)
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -4915,11 +4915,6 @@ $wgLogActionsHandlers = array();
  */
 $wgNewUserLog = true;
 
-/**
- * Log the automatic creations of new users accounts?
- */
-$wgLogAutocreatedAccounts = false;
-
 /** @} */ # end logging }
 
 /*************************************************************************//**

diff --git a/includes/User.php b/includes/User.php
index 06515cf..631babc 100644 (file)
--- a/includes/User.php
+++ b/includes/User.php
@@ -3699,8 +3699,8 @@ class User {
         * Used by things like CentralAuth and perhaps other authplugins.
         */
        public function addNewUserLogEntryAutoCreate() {
-               global $wgNewUserLog, $wgLogAutocreatedAccounts;
-               if( !$wgNewUserLog || !$wgLogAutocreatedAccounts ) {
+               global $wgNewUserLog;
+               if( !$wgNewUserLog ) {
                        return true; // disabled
                }
                $log = new LogPage( 'newusers', false );