* Set Vary: Cookie on action=raw generated CSS and JS, to ensure that user

  preferences don't get stuck in proxy caches for other people

Man this one's embarassing, we should have fixed it ages ago.
This should I think fix the longtime problem where people sometimes
see things like underlining of links change spontaneously.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index aa360ab..0d83d14 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -202,6 +202,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 7312) Don't emit SET NAMES utf8 if connection failed
 * (bug 7305) Proper compare for bot check on RC notify, should fix overrides
   that force edits by non-bot users to bot mode
+* Set Vary: Cookie on action=raw generated CSS and JS, to ensure that user
+  preferences don't get stuck in proxy caches for other people
 
 
 == Languages updated ==

diff --git a/includes/RawPage.php b/includes/RawPage.php
index 480c032..1a6d6ef 100644 (file)
--- a/includes/RawPage.php
+++ b/includes/RawPage.php
@@ -134,8 +134,10 @@ class RawPage {
        }
 
        function getRawText() {
-               global $wgUser, $wgOut;
+               global $wgUser, $wgOut, $wgRequest;
                if($this->mGen) {
+                       // May contain user-specific data; vary for open sessions
+                       $wgRequest->response()->header( 'Vary: Accept-Encoding, Cookie' );
                        $sk = $wgUser->getSkin();
                        $sk->initPage($wgOut);
                        if($this->mGen == 'css') {