Resolve required parameter after optional parameter in Linker

Change-Id: I2569e30922e93404a59fa282df8ae8d3d19912fd

diff --git a/includes/DummyLinker.php b/includes/DummyLinker.php
index 9aa6aeb..7958420 100644 (file)
--- a/includes/DummyLinker.php
+++ b/includes/DummyLinker.php
@@ -107,7 +107,7 @@ class DummyLinker {
                Title $title,
                $file,
                $label = '',
-               $alt,
+               $alt = '',
                $align = 'right',
                $params = [],
                $framed = false,

diff --git a/includes/Linker.php b/includes/Linker.php
index 3ee442d..6634127 100644 (file)
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -504,7 +504,7 @@ class Linker {
         * @param string $manualthumb
         * @return string
         */
-       public static function makeThumbLinkObj( Title $title, $file, $label = '', $alt,
+       public static function makeThumbLinkObj( Title $title, $file, $label = '', $alt = '',
                $align = 'right', $params = [], $framed = false, $manualthumb = ""
        ) {
                $frameParams = [

diff --git a/includes/linker/LinkRenderer.php b/includes/linker/LinkRenderer.php
index 160d2d1..87d7e0a 100644 (file)
--- a/includes/linker/LinkRenderer.php
+++ b/includes/linker/LinkRenderer.php
@@ -245,7 +245,7 @@ class LinkRenderer {
         * @return string
         */
        public function makePreloadedLink(
-               LinkTarget $target, $text = null, $classes, array $extraAttribs = [], array $query = []
+               LinkTarget $target, $text = null, $classes = '', array $extraAttribs = [], array $query = []
        ) {
                // Run begin hook
                $ret = $this->runBeginHook( $target, $text, $extraAttribs, $query, true );