* (bug 2101) a single variable was being used as both a counter and as a

  temporary variable causing invalid XHTML output.

diff --git a/includes/SpecialAllpages.php b/includes/SpecialAllpages.php
index 73d7ce1..b4142aa 100644 (file)
--- a/includes/SpecialAllpages.php
+++ b/includes/SpecialAllpages.php
@@ -257,9 +257,9 @@ function indexShowChunk( $namespace = NS_MAIN, $from, $invert ) {
                $t = Title::makeTitle( $s->page_namespace, $s->page_title );
                if( $t ) {
                        $ns = $s->page_namespace;
-                       $s = $invert && $namespaces[$ns] != $wgContLang->getNsText(NS_MAIN) ? ':' : '';
-                       $n = $invert ? $namespaces[$ns] : '';
-                       $link = $sk->makeKnownLinkObj( $t, $t->getText(), false, false, $n . $s ); 
+                       $prefix = $invert ? $namespaces[$ns] : '';
+                       $prefix .= $invert && $namespaces[$ns] != $wgContLang->getNsText(NS_MAIN) ? ':' : '';
+                       $link = $sk->makeKnownLinkObj( $t, $t->getText(), false, false, $prefix ); 
                } else {
                        $link = '[[' . htmlspecialchars( $s->page_title ) . ']]';
                }