Attempt at normalistion of comparison styles - empty string on left and right hand...
authorSam Reed <reedy@users.mediawiki.org>
Wed, 6 Jan 2010 19:59:42 +0000 (19:59 +0000)
committerSam Reed <reedy@users.mediawiki.org>
Wed, 6 Jan 2010 19:59:42 +0000 (19:59 +0000)
commitb6e0df246f8dda61643d9aba36d9f9e802c909ec
tree69dbf332f332a637d9ed40852f12852e860812a6
parent339f0bb3d98df5e9f8f1600b235f4d5cadb4924e
Attempt at normalistion of comparison styles - empty string on left and right hand side normalised to it being on the rhs

Before this change, there were (? being regex 0 or 1)

"" ===? 1
'' ===? 24
"" !==? 8
'' !==? 32

== "" 14
== '' 344
!= "" 9
!== "" 4
!= '' 151
!== '' 85

Rhs was the much more common, and the preferred style by many developers.. (Was a similar discussion in #mediawiki recently.. After that lolbugreport i think)

Where there is a string (non empty) on the lhs, and variable/method call on the rhs still need normalising
24 files changed:
includes/ChangesList.php
includes/EditPage.php
includes/Export.php
includes/GlobalFunctions.php
includes/Linker.php
includes/LogPage.php
includes/OutputPage.php
includes/ProtectionForm.php
includes/Skin.php
includes/SkinTemplate.php
includes/Title.php
includes/Wiki.php
includes/db/Database.php
includes/db/DatabaseOracle.php
includes/parser/Parser.php
includes/specials/SpecialEmailuser.php
includes/specials/SpecialIpblocklist.php
includes/specials/SpecialLockdb.php
includes/specials/SpecialProtectedpages.php
includes/specials/SpecialProtectedtitles.php
includes/specials/SpecialSearch.php
includes/specials/SpecialUnlockdb.php
includes/specials/SpecialUserlogin.php
skins/CologneBlue.php