Code housekeeping stuff (and barring any stuff-ups on my behalf, there should be...
authorNick Jenkins <nickj@users.mediawiki.org>
Thu, 23 Nov 2006 08:25:56 +0000 (08:25 +0000)
committerNick Jenkins <nickj@users.mediawiki.org>
Thu, 23 Nov 2006 08:25:56 +0000 (08:25 +0000)
commit14c53b728fe55f9ad21647b2303c49f1cb491901
treed99dd6fa7cdabb923ab6ab981dcaaddff67f377c
parent204e610f28b730639c1759101c4c096e97b3a0d1
Code housekeeping stuff (and barring any stuff-ups on my behalf, there should be no changes in behaviour whatsoever after this) -
* removing some unused global declarations.
* removing or commenting out or adding comments for unused local vars.
* Adding one or two local var declarations.
* Declaring $matches array passed to preg_match() / preg_match_all() as array() before using [not required, just have a slight preference for the explicitness].
* remove one or two pass-by-reference function declarations where the value is not modified.
* Adding some braces to if-else blocks.
* In Parser.php, stripstrate is now an object rather than an array as per r17820, so we no longer need ask for a reference to it (as in "$x =& $this->mStripState;"), and in fact it's probably just simpler to get rid of $x altogether.
* Moving some preg regexes from "" quoting to '' quoting to stop static analyzer whinging about bad escape sequences.

... up to "LinksUpdate.php" in the includes/ directory.
57 files changed:
includes/Article.php
includes/DatabaseFunctions.php
includes/DatabaseOracle.php
includes/EditPage.php
includes/Exif.php
includes/GlobalFunctions.php
includes/HTMLForm.php
includes/ImagePage.php
includes/Licenses.php
includes/LinkBatch.php
includes/Linker.php
includes/MessageCache.php
includes/MimeMagic.php
includes/OutputPage.php
includes/Parser.php
includes/Profiler.php
includes/ProtectionForm.php
includes/RecentChange.php
includes/Sanitizer.php
includes/SearchEngine.php
includes/SearchPostgres.php
includes/SpecialAllpages.php
includes/SpecialBlockip.php
includes/SpecialContributions.php
includes/SpecialImport.php
includes/SpecialMovepage.php
includes/SpecialNewimages.php
includes/SpecialRecentchanges.php
includes/SpecialRecentchangeslinked.php
includes/SpecialRevisiondelete.php
includes/SpecialSearch.php
includes/SpecialUpload.php
includes/SpecialUserlogin.php
includes/SpecialUserrights.php
includes/SpecialWatchlist.php
includes/SpecialWhatlinkshere.php
includes/User.php
includes/Xml.php
includes/ZhClient.php
includes/api/ApiBase.php
includes/api/ApiFeedWatchlist.php
includes/api/ApiFormatYaml_spyc.php
includes/api/ApiMain.php
includes/api/ApiOpenSearch.php
includes/api/ApiPageSet.php
includes/api/ApiQueryAllpages.php
includes/api/ApiQueryBacklinks.php
includes/api/ApiQueryInfo.php
includes/api/ApiQueryRecentChanges.php
includes/api/ApiQueryUserContributions.php
includes/api/ApiQueryWatchlist.php
includes/cbt/CBTCompiler.php
includes/normal/RandomTest.php
includes/normal/Utf8Test.php
includes/normal/UtfNormal.php
includes/normal/UtfNormalGenerate.php
includes/normal/UtfNormalTest.php