From b54ef9d1a05d683ca507067b8c23e5fe195b7b19 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Fri, 2 Oct 2015 17:00:33 +0200 Subject: [PATCH] Don't clobber existing styles when adding more in IE9 Follow-up to c2e8f505c12ace6af42161bf9930d483b1721f2e. This was really stupid and I feel stupid. Bug: T114323 Change-Id: I80292083d8fd50c2e2727446e4468b6a13ad40e5 --- resources/src/mediawiki/mediawiki.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index 2eecbabb4e..12d698b452 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -863,7 +863,7 @@ * @param {Function} [callback] */ function addEmbeddedCSS( cssText, callback ) { - var $style, styleEl; + var $style, styleEl, newCssText; function fireCallbacks() { var oldCallbacks = cssCallbacks; @@ -936,7 +936,9 @@ // write, dropping @media queries from the CSS text. If we read it and used its // value, we would accidentally apply @media-specific styles to all media. (T108727) if ( document.documentMode === 9 ) { - styleEl.styleSheet.cssText = $style.data( 'ResourceLoaderDynamicStyleTag' ) + cssText; + newCssText = $style.data( 'ResourceLoaderDynamicStyleTag' ) + cssText; + styleEl.styleSheet.cssText = newCssText; + $style.data( 'ResourceLoaderDynamicStyleTag', newCssText ); } else { styleEl.styleSheet.cssText += cssText; } -- 2.20.1