From 31047fb1bf03944158fe4f7da99686e7955a3b5c Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Mon, 20 Mar 2017 11:21:16 -0700 Subject: [PATCH] RCFilters: Change reset button title when it changes state The button changes state between 'restore default filters' and the trash icon which is to remove all selected filters. The title for the button should also change accordingly. Change-Id: I9070f0c4959f5c7c97d57d943103ae2baf89d6d2 --- languages/i18n/en.json | 1 + languages/i18n/qqq.json | 1 + resources/Resources.php | 1 + .../ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js | 5 +++++ 4 files changed, 8 insertions(+) diff --git a/languages/i18n/en.json b/languages/i18n/en.json index ccfa91b096..ea60fc82be 100644 --- a/languages/i18n/en.json +++ b/languages/i18n/en.json @@ -1366,6 +1366,7 @@ "rcfilters-activefilters": "Active filters", "rcfilters-restore-default-filters": "Restore default filters", "rcfilters-clear-all-filters": "Clear all filters", + "rcfilters-clear-filters-to-defaults": "Set filters to defaults", "rcfilters-search-placeholder": "Filter recent changes (browse or start typing)", "rcfilters-invalid-filter": "Invalid filter", "rcfilters-empty-filter": "No active filters. All contributions are shown.", diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json index f123189c2e..3116163234 100644 --- a/languages/i18n/qqq.json +++ b/languages/i18n/qqq.json @@ -1553,6 +1553,7 @@ "rcfilters-activefilters": "Title for the filters selection showing the active filters.", "rcfilters-restore-default-filters": "Label for the button that resets filters to defaults", "rcfilters-clear-all-filters": "Title for the button that clears all filters", + "rcfilters-clear-filters-to-defaults": "Title for the button that sets filters to default", "rcfilters-search-placeholder": "Placeholder for the filter search input.", "rcfilters-invalid-filter": "A label for an invalid filter.", "rcfilters-empty-filter": "Placeholder for the filter list when no filters were chosen.", diff --git a/resources/Resources.php b/resources/Resources.php index 392cdb3ff8..f57f8c826c 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -1795,6 +1795,7 @@ return [ 'rcfilters-activefilters', 'rcfilters-restore-default-filters', 'rcfilters-clear-all-filters', + 'rcfilters-clear-filters-to-defaults', 'rcfilters-search-placeholder', 'rcfilters-invalid-filter', 'rcfilters-empty-filter', diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js index 944ebaa120..3f461c76f0 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterCapsuleMultiselectWidget.js @@ -183,6 +183,11 @@ this.resetButton.setLabel( currFiltersAreEmpty ? mw.msg( 'rcfilters-restore-default-filters' ) : '' ); + this.resetButton.setTitle( + currFiltersAreEmpty ? + mw.msg( 'rcfilters-clear-filters-to-defaults' ) : + mw.msg( 'rcfilters-clear-all-filters' ) + ); this.resetButton.toggle( !hideResetButton ); this.emptyFilterMessage.toggle( currFiltersAreEmpty ); -- 2.20.1