From 1df9d33ba851759e193e5488768f636cc5154868 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= <matma.rex@gmail.com>
Date: Wed, 14 Oct 2015 16:39:32 +0200
Subject: [PATCH] mediawiki.special.preferences: Use standard IIFE

Directly using 'mediaWiki' variable rather than 'mw' makes it harder
to grep for things.

Change-Id: I2652ecd9a52b5ba05989dcfe8b106e3b4dd504d7
---
 .../mediawiki.special.preferences.js          | 546 +++++++++---------
 1 file changed, 274 insertions(+), 272 deletions(-)

diff --git a/resources/src/mediawiki.special/mediawiki.special.preferences.js b/resources/src/mediawiki.special/mediawiki.special.preferences.js
index 9b790e0361..0fda3dc363 100644
--- a/resources/src/mediawiki.special/mediawiki.special.preferences.js
+++ b/resources/src/mediawiki.special/mediawiki.special.preferences.js
@@ -1,306 +1,308 @@
 /*!
  * JavaScript for Special:Preferences
  */
-jQuery( function ( $ ) {
-	var $preftoc, $preferences, $fieldsets, $legends,
-		hash, labelFunc,
-		$tzSelect, $tzTextbox, $localtimeHolder, servertime,
-		$checkBoxes, allowCloseWindow,
-		notif;
-
-	labelFunc = function () {
-		return this.id.replace( /^mw-prefsection/g, 'preftab' );
-	};
-
-	$( '#prefsubmit' ).attr( 'id', 'prefcontrol' );
-	$preftoc = $( '<ul>' )
-		.attr( {
-			id: 'preftoc',
-			role: 'tablist'
-		} );
-	$preferences = $( '#preferences' )
-		.addClass( 'jsprefs' )
-		.before( $preftoc );
-	$fieldsets = $preferences.children( 'fieldset' )
-		.hide()
-		.attr( {
-			role: 'tabpanel',
-			'aria-hidden': 'true',
-			'aria-labelledby': labelFunc
-		} )
-		.addClass( 'prefsection' );
-	$legends = $fieldsets
-		.children( 'legend' )
-		.addClass( 'mainLegend' );
-
-	// Make sure the accessibility tip is selectable so that screen reader users take notice,
-	// but hide it per default to reduce interface clutter. Also make sure it becomes visible
-	// when selected. Similar to jquery.mw-jump
-	$( '<div>' ).addClass( 'mw-navigation-hint' )
-		.text( mediaWiki.msg( 'prefs-tabs-navigation-hint' ) )
-		.attr( 'tabIndex', 0 )
-		.on( 'focus blur', function ( e ) {
-			if ( e.type === 'blur' || e.type === 'focusout' ) {
-				$( this ).css( 'height', '0' );
-			} else {
-				$( this ).css( 'height', 'auto' );
-			}
-		} ).insertBefore( $preftoc );
-
-	/**
-	 * It uses document.getElementById for security reasons (HTML injections in $()).
-	 *
-	 * @ignore
-	 * @param {string} name the name of a tab without the prefix ("mw-prefsection-")
-	 * @param {string} [mode] A hash will be set according to the current
-	 *  open section. Set mode 'noHash' to surpress this.
-	 */
-	function switchPrefTab( name, mode ) {
-		var $tab, scrollTop;
-		// Handle hash manually to prevent jumping,
-		// therefore save and restore scrollTop to prevent jumping.
-		scrollTop = $( window ).scrollTop();
-		if ( mode !== 'noHash' ) {
-			location.hash = '#mw-prefsection-' + name;
-		}
-		$( window ).scrollTop( scrollTop );
-
-		$preftoc.find( 'li' ).removeClass( 'selected' )
-			.find( 'a' ).attr( {
-				tabIndex: -1,
-				'aria-selected': 'false'
+( function ( mw, $ ) {
+	$( function () {
+		var $preftoc, $preferences, $fieldsets, $legends,
+			hash, labelFunc,
+			$tzSelect, $tzTextbox, $localtimeHolder, servertime,
+			$checkBoxes, allowCloseWindow,
+			notif;
+
+		labelFunc = function () {
+			return this.id.replace( /^mw-prefsection/g, 'preftab' );
+		};
+
+		$( '#prefsubmit' ).attr( 'id', 'prefcontrol' );
+		$preftoc = $( '<ul>' )
+			.attr( {
+				id: 'preftoc',
+				role: 'tablist'
 			} );
-
-		$tab = $( document.getElementById( 'preftab-' + name ) );
-		if ( $tab.length ) {
-			$tab.attr( {
-				tabIndex: 0,
-				'aria-selected': 'true'
+		$preferences = $( '#preferences' )
+			.addClass( 'jsprefs' )
+			.before( $preftoc );
+		$fieldsets = $preferences.children( 'fieldset' )
+			.hide()
+			.attr( {
+				role: 'tabpanel',
+				'aria-hidden': 'true',
+				'aria-labelledby': labelFunc
 			} )
-			.focus()
-				.parent().addClass( 'selected' );
-
-			$preferences.children( 'fieldset' ).hide().attr( 'aria-hidden', 'true' );
-			$( document.getElementById( 'mw-prefsection-' + name ) ).show().attr( 'aria-hidden', 'false' );
-		}
-	}
-
-	// Check for messageboxes (.successbox, .warningbox, .errorbox) to replace with notifications
-	if ( $( '.mw-preferences-messagebox' ).length ) {
-		// If there is a #mw-preferences-success box and javascript is enabled, use a slick notification instead!
-		if ( $( '#mw-preferences-success' ).length ) {
-			notif = mediaWiki.notification.notify( mediaWiki.message( 'savedprefs' ), { autoHide: false } );
-			// 'change' event not reliable!
-			$( '#preftoc, .prefsection' ).one( 'change keydown mousedown', function () {
-				if ( notif ) {
-					notif.close();
-					notif = null;
+			.addClass( 'prefsection' );
+		$legends = $fieldsets
+			.children( 'legend' )
+			.addClass( 'mainLegend' );
+
+		// Make sure the accessibility tip is selectable so that screen reader users take notice,
+		// but hide it per default to reduce interface clutter. Also make sure it becomes visible
+		// when selected. Similar to jquery.mw-jump
+		$( '<div>' ).addClass( 'mw-navigation-hint' )
+			.text( mw.msg( 'prefs-tabs-navigation-hint' ) )
+			.attr( 'tabIndex', 0 )
+			.on( 'focus blur', function ( e ) {
+				if ( e.type === 'blur' || e.type === 'focusout' ) {
+					$( this ).css( 'height', '0' );
+				} else {
+					$( this ).css( 'height', 'auto' );
 				}
-			} );
-
-			// Remove now-unnecessary success=1 querystring to prevent reappearance of notification on reload
-			if ( history.replaceState ) {
-				history.replaceState( {}, document.title, location.href.replace( /&?success=1/, '' ) );
+			} ).insertBefore( $preftoc );
+
+		/**
+		 * It uses document.getElementById for security reasons (HTML injections in $()).
+		 *
+		 * @ignore
+		 * @param {string} name the name of a tab without the prefix ("mw-prefsection-")
+		 * @param {string} [mode] A hash will be set according to the current
+		 *  open section. Set mode 'noHash' to surpress this.
+		 */
+		function switchPrefTab( name, mode ) {
+			var $tab, scrollTop;
+			// Handle hash manually to prevent jumping,
+			// therefore save and restore scrollTop to prevent jumping.
+			scrollTop = $( window ).scrollTop();
+			if ( mode !== 'noHash' ) {
+				location.hash = '#mw-prefsection-' + name;
+			}
+			$( window ).scrollTop( scrollTop );
+
+			$preftoc.find( 'li' ).removeClass( 'selected' )
+				.find( 'a' ).attr( {
+					tabIndex: -1,
+					'aria-selected': 'false'
+				} );
+
+			$tab = $( document.getElementById( 'preftab-' + name ) );
+			if ( $tab.length ) {
+				$tab.attr( {
+					tabIndex: 0,
+					'aria-selected': 'true'
+				} )
+				.focus()
+					.parent().addClass( 'selected' );
+
+				$preferences.children( 'fieldset' ).hide().attr( 'aria-hidden', 'true' );
+				$( document.getElementById( 'mw-prefsection-' + name ) ).show().attr( 'aria-hidden', 'false' );
 			}
 		}
-	}
-
-	// Populate the prefToc
-	$legends.each( function ( i, legend ) {
-		var $legend = $( legend ),
-			ident, $li, $a;
-		if ( i === 0 ) {
-			$legend.parent().show();
-		}
-		ident = $legend.parent().attr( 'id' );
 
-		$li = $( '<li>' )
-			.attr( 'role', 'presentation' )
-			.addClass( i === 0 ? 'selected' : '' );
-		$a = $( '<a>' )
-			.attr( {
-				id: ident.replace( 'mw-prefsection', 'preftab' ),
-				href: '#' + ident,
-				role: 'tab',
-				tabIndex: i === 0 ? 0 : -1,
-				'aria-selected': i === 0 ? 'true' : 'false',
-				'aria-controls': ident
-			} )
-			.text( $legend.text() );
-		$li.append( $a );
-		$preftoc.append( $li );
-	} );
+		// Check for messageboxes (.successbox, .warningbox, .errorbox) to replace with notifications
+		if ( $( '.mw-preferences-messagebox' ).length ) {
+			// If there is a #mw-preferences-success box and javascript is enabled, use a slick notification instead!
+			if ( $( '#mw-preferences-success' ).length ) {
+				notif = mw.notification.notify( mw.message( 'savedprefs' ), { autoHide: false } );
+				// 'change' event not reliable!
+				$( '#preftoc, .prefsection' ).one( 'change keydown mousedown', function () {
+					if ( notif ) {
+						notif.close();
+						notif = null;
+					}
+				} );
+
+				// Remove now-unnecessary success=1 querystring to prevent reappearance of notification on reload
+				if ( history.replaceState ) {
+					history.replaceState( {}, document.title, location.href.replace( /&?success=1/, '' ) );
+				}
+			}
+		}
 
-	// Disable the button to save preferences unless preferences have changed
-	$( '#prefcontrol' ).prop( 'disabled', true );
-	$( '.prefsection' ).one( 'change keydown mousedown', function () {
-		$( '#prefcontrol' ).prop( 'disabled', false );
-	} );
+		// Populate the prefToc
+		$legends.each( function ( i, legend ) {
+			var $legend = $( legend ),
+				ident, $li, $a;
+			if ( i === 0 ) {
+				$legend.parent().show();
+			}
+			ident = $legend.parent().attr( 'id' );
+
+			$li = $( '<li>' )
+				.attr( 'role', 'presentation' )
+				.addClass( i === 0 ? 'selected' : '' );
+			$a = $( '<a>' )
+				.attr( {
+					id: ident.replace( 'mw-prefsection', 'preftab' ),
+					href: '#' + ident,
+					role: 'tab',
+					tabIndex: i === 0 ? 0 : -1,
+					'aria-selected': i === 0 ? 'true' : 'false',
+					'aria-controls': ident
+				} )
+				.text( $legend.text() );
+			$li.append( $a );
+			$preftoc.append( $li );
+		} );
 
-	// Enable keyboard users to use left and right keys to switch tabs
-	$preftoc.on( 'keydown', function ( event ) {
-		var keyLeft = 37,
-			keyRight = 39,
-			$el;
+		// Disable the button to save preferences unless preferences have changed
+		$( '#prefcontrol' ).prop( 'disabled', true );
+		$( '.prefsection' ).one( 'change keydown mousedown', function () {
+			$( '#prefcontrol' ).prop( 'disabled', false );
+		} );
 
-		if ( event.keyCode === keyLeft ) {
-			$el = $( '#preftoc li.selected' ).prev().find( 'a' );
-		} else if ( event.keyCode === keyRight ) {
-			$el = $( '#preftoc li.selected' ).next().find( 'a' );
-		} else {
-			return;
-		}
-		if ( $el.length > 0 ) {
-			switchPrefTab( $el.attr( 'href' ).replace( '#mw-prefsection-', '' ) );
-		}
-	} );
+		// Enable keyboard users to use left and right keys to switch tabs
+		$preftoc.on( 'keydown', function ( event ) {
+			var keyLeft = 37,
+				keyRight = 39,
+				$el;
 
-	// If we've reloaded the page or followed an open-in-new-window,
-	// make the selected tab visible.
-	hash = location.hash;
-	if ( hash.match( /^#mw-prefsection-[\w\-]+/ ) ) {
-		switchPrefTab( hash.replace( '#mw-prefsection-', '' ) );
-	}
-
-	// In browsers that support the onhashchange event we will not bind click
-	// handlers and instead let the browser do the default behavior (clicking the
-	// <a href="#.."> will naturally set the hash, handled by onhashchange.
-	// But other things that change the hash will also be catched (e.g. using
-	// the Back and Forward browser navigation).
-	// Note the special check for IE "compatibility" mode.
-	if ( 'onhashchange' in window &&
-		( document.documentMode === undefined || document.documentMode >= 8 )
-	) {
-		$( window ).on( 'hashchange', function () {
-			var hash = location.hash;
-			if ( hash.match( /^#mw-prefsection-[\w\-]+/ ) ) {
-				switchPrefTab( hash.replace( '#mw-prefsection-', '' ) );
-			} else if ( hash === '' ) {
-				switchPrefTab( 'personal', 'noHash' );
+			if ( event.keyCode === keyLeft ) {
+				$el = $( '#preftoc li.selected' ).prev().find( 'a' );
+			} else if ( event.keyCode === keyRight ) {
+				$el = $( '#preftoc li.selected' ).next().find( 'a' );
+			} else {
+				return;
+			}
+			if ( $el.length > 0 ) {
+				switchPrefTab( $el.attr( 'href' ).replace( '#mw-prefsection-', '' ) );
 			}
 		} );
-	// In older browsers we'll bind a click handler as fallback.
-	// We must not have onhashchange *and* the click handlers, other wise
-	// the click handler calls switchPrefTab() which sets the hash value,
-	// which triggers onhashcange and calls switchPrefTab() again.
-	} else {
-		$preftoc.on( 'click', 'li a', function ( e ) {
-			switchPrefTab( $( this ).attr( 'href' ).replace( '#mw-prefsection-', '' ) );
-			e.preventDefault();
-		} );
-	}
 
-	// Timezone functions.
-	// Guesses Timezone from browser and updates fields onchange.
+		// If we've reloaded the page or followed an open-in-new-window,
+		// make the selected tab visible.
+		hash = location.hash;
+		if ( hash.match( /^#mw-prefsection-[\w\-]+/ ) ) {
+			switchPrefTab( hash.replace( '#mw-prefsection-', '' ) );
+		}
 
-	$tzSelect = $( '#mw-input-wptimecorrection' );
-	$tzTextbox = $( '#mw-input-wptimecorrection-other' );
-	$localtimeHolder = $( '#wpLocalTime' );
-	servertime = parseInt( $( 'input[name="wpServerTime"]' ).val(), 10 );
+		// In browsers that support the onhashchange event we will not bind click
+		// handlers and instead let the browser do the default behavior (clicking the
+		// <a href="#.."> will naturally set the hash, handled by onhashchange.
+		// But other things that change the hash will also be catched (e.g. using
+		// the Back and Forward browser navigation).
+		// Note the special check for IE "compatibility" mode.
+		if ( 'onhashchange' in window &&
+			( document.documentMode === undefined || document.documentMode >= 8 )
+		) {
+			$( window ).on( 'hashchange', function () {
+				var hash = location.hash;
+				if ( hash.match( /^#mw-prefsection-[\w\-]+/ ) ) {
+					switchPrefTab( hash.replace( '#mw-prefsection-', '' ) );
+				} else if ( hash === '' ) {
+					switchPrefTab( 'personal', 'noHash' );
+				}
+			} );
+		// In older browsers we'll bind a click handler as fallback.
+		// We must not have onhashchange *and* the click handlers, other wise
+		// the click handler calls switchPrefTab() which sets the hash value,
+		// which triggers onhashcange and calls switchPrefTab() again.
+		} else {
+			$preftoc.on( 'click', 'li a', function ( e ) {
+				switchPrefTab( $( this ).attr( 'href' ).replace( '#mw-prefsection-', '' ) );
+				e.preventDefault();
+			} );
+		}
 
-	function minutesToHours( min ) {
-		var tzHour = Math.floor( Math.abs( min ) / 60 ),
-			tzMin = Math.abs( min ) % 60,
-			tzString = ( ( min >= 0 ) ? '' : '-' ) + ( ( tzHour < 10 ) ? '0' : '' ) + tzHour +
-				':' + ( ( tzMin < 10 ) ? '0' : '' ) + tzMin;
-		return tzString;
-	}
+		// Timezone functions.
+		// Guesses Timezone from browser and updates fields onchange.
 
-	function hoursToMinutes( hour ) {
-		var minutes,
-			arr = hour.split( ':' );
+		$tzSelect = $( '#mw-input-wptimecorrection' );
+		$tzTextbox = $( '#mw-input-wptimecorrection-other' );
+		$localtimeHolder = $( '#wpLocalTime' );
+		servertime = parseInt( $( 'input[name="wpServerTime"]' ).val(), 10 );
 
-		arr[ 0 ] = parseInt( arr[ 0 ], 10 );
+		function minutesToHours( min ) {
+			var tzHour = Math.floor( Math.abs( min ) / 60 ),
+				tzMin = Math.abs( min ) % 60,
+				tzString = ( ( min >= 0 ) ? '' : '-' ) + ( ( tzHour < 10 ) ? '0' : '' ) + tzHour +
+					':' + ( ( tzMin < 10 ) ? '0' : '' ) + tzMin;
+			return tzString;
+		}
 
-		if ( arr.length === 1 ) {
-			// Specification is of the form [-]XX
-			minutes = arr[ 0 ] * 60;
-		} else {
-			// Specification is of the form [-]XX:XX
-			minutes = Math.abs( arr[ 0 ] ) * 60 + parseInt( arr[ 1 ], 10 );
-			if ( arr[ 0 ] < 0 ) {
-				minutes *= -1;
+		function hoursToMinutes( hour ) {
+			var minutes,
+				arr = hour.split( ':' );
+
+			arr[ 0 ] = parseInt( arr[ 0 ], 10 );
+
+			if ( arr.length === 1 ) {
+				// Specification is of the form [-]XX
+				minutes = arr[ 0 ] * 60;
+			} else {
+				// Specification is of the form [-]XX:XX
+				minutes = Math.abs( arr[ 0 ] ) * 60 + parseInt( arr[ 1 ], 10 );
+				if ( arr[ 0 ] < 0 ) {
+					minutes *= -1;
+				}
+			}
+			// Gracefully handle non-numbers.
+			if ( isNaN( minutes ) ) {
+				return 0;
+			} else {
+				return minutes;
 			}
-		}
-		// Gracefully handle non-numbers.
-		if ( isNaN( minutes ) ) {
-			return 0;
-		} else {
-			return minutes;
-		}
-	}
-
-	function updateTimezoneSelection() {
-		var minuteDiff, localTime,
-			type = $tzSelect.val();
-
-		if ( type === 'guess' ) {
-			// Get browser timezone & fill it in
-			minuteDiff = -( new Date().getTimezoneOffset() );
-			$tzTextbox.val( minutesToHours( minuteDiff ) );
-			$tzSelect.val( 'other' );
-			$tzTextbox.prop( 'disabled', false );
-		} else if ( type === 'other' ) {
-			// Grab data from the textbox, parse it.
-			minuteDiff = hoursToMinutes( $tzTextbox.val() );
-		} else {
-			// Grab data from the $tzSelect value
-			minuteDiff = parseInt( type.split( '|' )[ 1 ], 10 ) || 0;
-			$tzTextbox.val( minutesToHours( minuteDiff ) );
 		}
 
-		// Determine local time from server time and minutes difference, for display.
-		localTime = servertime + minuteDiff;
+		function updateTimezoneSelection() {
+			var minuteDiff, localTime,
+				type = $tzSelect.val();
+
+			if ( type === 'guess' ) {
+				// Get browser timezone & fill it in
+				minuteDiff = -( new Date().getTimezoneOffset() );
+				$tzTextbox.val( minutesToHours( minuteDiff ) );
+				$tzSelect.val( 'other' );
+				$tzTextbox.prop( 'disabled', false );
+			} else if ( type === 'other' ) {
+				// Grab data from the textbox, parse it.
+				minuteDiff = hoursToMinutes( $tzTextbox.val() );
+			} else {
+				// Grab data from the $tzSelect value
+				minuteDiff = parseInt( type.split( '|' )[ 1 ], 10 ) || 0;
+				$tzTextbox.val( minutesToHours( minuteDiff ) );
+			}
 
-		// Bring time within the [0,1440) range.
-		localTime = ( ( localTime % 1440 ) + 1440 ) % 1440;
+			// Determine local time from server time and minutes difference, for display.
+			localTime = servertime + minuteDiff;
 
-		$localtimeHolder.text( mediaWiki.language.convertNumber( minutesToHours( localTime ) ) );
-	}
+			// Bring time within the [0,1440) range.
+			localTime = ( ( localTime % 1440 ) + 1440 ) % 1440;
 
-	if ( $tzSelect.length && $tzTextbox.length ) {
-		$tzSelect.change( updateTimezoneSelection );
-		$tzTextbox.blur( updateTimezoneSelection );
-		updateTimezoneSelection();
-	}
+			$localtimeHolder.text( mw.language.convertNumber( minutesToHours( localTime ) ) );
+		}
 
-	// Preserve the tab after saving the preferences
-	// Not using cookies, because their deletion results are inconsistent.
-	// Not using jStorage due to its enormous size (for this feature)
-	if ( window.sessionStorage ) {
-		if ( sessionStorage.getItem( 'mediawikiPreferencesTab' ) !== null ) {
-			switchPrefTab( sessionStorage.getItem( 'mediawikiPreferencesTab' ), 'noHash' );
+		if ( $tzSelect.length && $tzTextbox.length ) {
+			$tzSelect.change( updateTimezoneSelection );
+			$tzTextbox.blur( updateTimezoneSelection );
+			updateTimezoneSelection();
 		}
-		// Deleting the key, the tab states should be reset until we press Save
-		sessionStorage.removeItem( 'mediawikiPreferencesTab' );
 
-		$( '#mw-prefs-form' ).submit( function () {
-			var storageData = $( $preftoc ).find( 'li.selected a' ).attr( 'id' ).replace( 'preftab-', '' );
-			sessionStorage.setItem( 'mediawikiPreferencesTab', storageData );
+		// Preserve the tab after saving the preferences
+		// Not using cookies, because their deletion results are inconsistent.
+		// Not using jStorage due to its enormous size (for this feature)
+		if ( window.sessionStorage ) {
+			if ( sessionStorage.getItem( 'mediawikiPreferencesTab' ) !== null ) {
+				switchPrefTab( sessionStorage.getItem( 'mediawikiPreferencesTab' ), 'noHash' );
+			}
+			// Deleting the key, the tab states should be reset until we press Save
+			sessionStorage.removeItem( 'mediawikiPreferencesTab' );
+
+			$( '#mw-prefs-form' ).submit( function () {
+				var storageData = $( $preftoc ).find( 'li.selected a' ).attr( 'id' ).replace( 'preftab-', '' );
+				sessionStorage.setItem( 'mediawikiPreferencesTab', storageData );
+			} );
+		}
+
+		// To disable all 'namespace' checkboxes in Search preferences
+		// when 'Search in all namespaces' checkbox is ticked.
+		$checkBoxes = $( '#mw-htmlform-advancedsearchoptions input[id^=mw-input-wpsearchnamespaces]' );
+		if ( $( '#mw-input-wpsearcheverything' ).prop( 'checked' ) ) {
+			$checkBoxes.prop( 'disabled', true );
+		}
+		$( '#mw-input-wpsearcheverything' ).change( function () {
+			$checkBoxes.prop( 'disabled', $( this ).prop( 'checked' ) );
 		} );
-	}
-
-	// To disable all 'namespace' checkboxes in Search preferences
-	// when 'Search in all namespaces' checkbox is ticked.
-	$checkBoxes = $( '#mw-htmlform-advancedsearchoptions input[id^=mw-input-wpsearchnamespaces]' );
-	if ( $( '#mw-input-wpsearcheverything' ).prop( 'checked' ) ) {
-		$checkBoxes.prop( 'disabled', true );
-	}
-	$( '#mw-input-wpsearcheverything' ).change( function () {
-		$checkBoxes.prop( 'disabled', $( this ).prop( 'checked' ) );
-	} );
 
-	// Set up a message to notify users if they try to leave the page without
-	// saving.
-	$( '#mw-prefs-form' ).data( 'origdata', $( '#mw-prefs-form' ).serialize() );
-	allowCloseWindow = mediaWiki.confirmCloseWindow( {
-		test: function () {
-			return $( '#mw-prefs-form' ).serialize() !== $( '#mw-prefs-form' ).data( 'origdata' );
-		},
+		// Set up a message to notify users if they try to leave the page without
+		// saving.
+		$( '#mw-prefs-form' ).data( 'origdata', $( '#mw-prefs-form' ).serialize() );
+		allowCloseWindow = mw.confirmCloseWindow( {
+			test: function () {
+				return $( '#mw-prefs-form' ).serialize() !== $( '#mw-prefs-form' ).data( 'origdata' );
+			},
 
-		message: mediaWiki.msg( 'prefswarning-warning', mediaWiki.msg( 'saveprefs' ) ),
-		namespace: 'prefswarning'
+			message: mw.msg( 'prefswarning-warning', mw.msg( 'saveprefs' ) ),
+			namespace: 'prefswarning'
+		} );
+		$( '#mw-prefs-form' ).submit( $.proxy( allowCloseWindow, 'release' ) );
+		$( '#mw-prefs-restoreprefs' ).click( $.proxy( allowCloseWindow, 'release' ) );
 	} );
-	$( '#mw-prefs-form' ).submit( $.proxy( allowCloseWindow, 'release' ) );
-	$( '#mw-prefs-restoreprefs' ).click( $.proxy( allowCloseWindow, 'release' ) );
-} );
+}( mediaWiki, jQuery ) );
-- 
2.20.1