From 1122ca5f8750a7e23e3f00ad7c03a19ef25f4c17 Mon Sep 17 00:00:00 2001
From: awjrichards <arichards@wikimedia.org>
Date: Fri, 20 Apr 2012 15:17:55 -0700
Subject: [PATCH] Ensure MWHttpRequest::method gets set with strtoupper() since
 code examining MWHttpRequest::method always expects its value to be fully
 uppercased.

Yes, this should not be a problem if MWHttpRequest is accessed
via HTTP class, but that will not always be guaranteed.

Resolves bug 36137.

Change-Id: Ic20e1b99dcb56b8a11cea50293ba44022e564de9
---
 includes/HttpFunctions.php | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/includes/HttpFunctions.php b/includes/HttpFunctions.php
index a1d2e59e59..6adef844a2 100644
--- a/includes/HttpFunctions.php
+++ b/includes/HttpFunctions.php
@@ -216,6 +216,11 @@ class MWHttpRequest {
 
 		foreach ( $members as $o ) {
 			if ( isset( $options[$o] ) ) {
+				// ensure that MWHttpRequest::method is always
+				// uppercased. Bug 36137
+				if ( $o == 'method' ) {
+					$options[$o] = strtoupper( $options[$o] );
+				}
 				$this->$o = $options[$o];
 			}
 		}
-- 
2.20.1