From: Florian <florian.schmidt.stargatewissen@gmail.com>
Date: Sun, 7 Aug 2016 18:09:42 +0000 (+0200)
Subject: AuthManager: Always whitelist some special pages
X-Git-Tag: 1.31.0-rc.0~6083^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/?a=commitdiff_plain;h=f2598a0b21596c6ad515f385570f6571b07b2333;p=lhc%2Fweb%2Fwiklou.git

AuthManager: Always whitelist some special pages

Special:UserLogout should be whitelisted, if Special:UserLogin is whitelisted,
as otherwise the user is able to login, but not able to logout anymore (given,
that the sys-admin hasn't change the $wgWhitelistRead config variable).

Special:ChangePassword redirects to Special:ChangeCredentials. Instead of
adding this special page, it should be done explicitly in the
wiki configuration (LocalSettings.php). For this reason, the whitelist is
removed, too.

Change-Id: I271efb517bf0ec0022e6fe29673570ca08e8fe1a
---

diff --git a/includes/Title.php b/includes/Title.php
index ea42768c0e..ed445cc280 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -2319,8 +2319,8 @@ class Title implements LinkTarget {
 			# If the user is allowed to read pages, he is allowed to read all pages
 			$whitelisted = true;
 		} elseif ( $this->isSpecial( 'Userlogin' )
-			|| $this->isSpecial( 'ChangePassword' )
 			|| $this->isSpecial( 'PasswordReset' )
+			|| $this->isSpecial( 'Userlogout' )
 		) {
 			# Always grant access to the login page.
 			# Even anons need to be able to log in.