From: Alexandre Emsenhuber <mediawiki@emsenhuber.ch>
Date: Mon, 8 Sep 2014 18:54:53 +0000 (+0200)
Subject: Avoid a fatal error in maintenance/cleanupTitles.php
X-Git-Tag: 1.31.0-rc.0~14091
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/?a=commitdiff_plain;h=739f9fd485006b79ec11f674bc4e124f732330f9;p=lhc%2Fweb%2Fwiklou.git

Avoid a fatal error in maintenance/cleanupTitles.php

Title::makeTitleSafe() can return null; so only call
exists() if an object was returned, and otherwise behave
the same way as if the page existed: use another name.

Change-Id: I75ea5c5b25fa5fdf6646a177a5fbccc0dbff9b47
---

diff --git a/maintenance/cleanupTitles.php b/maintenance/cleanupTitles.php
index eee1204668..0df9e7fe0c 100644
--- a/maintenance/cleanupTitles.php
+++ b/maintenance/cleanupTitles.php
@@ -156,7 +156,7 @@ class TitleCleanup extends TableCleanup {
 
 			$clean = 'Broken/' . $prior;
 			$verified = Title::makeTitleSafe( $ns, $clean );
-			if ( $verified->exists() ) {
+			if ( !$verified || $verified->exists() ) {
 				$blah = "Broken/id:" . $row->page_id;
 				$this->output( "Couldn't legalize; form '$clean' exists; using '$blah'\n" );
 				$verified = Title::makeTitleSafe( $ns, $blah );