Revert r38302,38306 -- "Add an order by to the list of watched pages."
authorBrion Vibber <brion@users.mediawiki.org>
Thu, 31 Jul 2008 23:20:37 +0000 (23:20 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Thu, 31 Jul 2008 23:20:37 +0000 (23:20 +0000)
This looks wrong -- an order by title wouldn't be indexed properly, and could be rather slow.

includes/WatchlistEditor.php

index d135230..fcfdb78 100644 (file)
@@ -208,9 +208,6 @@ class WatchlistEditor {
                $sql = "SELECT wl_namespace, wl_title, page_id, page_len, page_is_redirect
                        FROM {$watchlist} LEFT JOIN {$page} ON ( wl_namespace = page_namespace
                        AND wl_title = page_title ) WHERE wl_user = {$uid}";
-               if ( !$dbr->implicitOrderby() ) {
-                       $sql .= ' ORDER BY wl_title';
-               }
                $res = $dbr->query( $sql, __METHOD__ );
                if( $res && $dbr->numRows( $res ) > 0 ) {
                        $cache = LinkCache::singleton();