Fix #6684: Improper javascript array iteration causes problems

Patch by Dan Li <dto@dev.java.net>

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 97d3ff5..390ff47 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -169,6 +169,7 @@ lighter making things easier to read.
 * Fix for paths in 1.4->1.5 special-case updater script
 * (bug 8789) AJAX search: IE users can now use the return key
 * (bug 6844) Use <ins> and <del> tags to emphase the differences
+* (bug 6684) Fix improper javascript array iteration
 
 
 == Languages updated ==

diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index cf53694..b7762b9 100644 (file)
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -374,10 +374,10 @@ function mwSetupToolbar() {
                return false;
        }
 
-       for (var i in mwEditButtons) {
+       for (var i = 0; i < mwEditButtons.length; i++) {
                mwInsertEditButton(toolbar, mwEditButtons[i]);
        }
-       for (i in mwCustomEditButtons) {
+       for (var i = 0; i < mwCustomEditButtons.length; i++) {
                mwInsertEditButton(toolbar, mwCustomEditButtons[i]);
        }
        return true;