Improved the comment about Special:Contributions.
authorAmir E. Aharoni <amir.aharoni@mail.huji.ac.il>
Tue, 27 Mar 2012 12:09:25 +0000 (14:09 +0200)
committerAmir E. Aharoni <amir.aharoni@mail.huji.ac.il>
Tue, 27 Mar 2012 12:10:31 +0000 (14:10 +0200)
It was prompted by an IRC discussion with SrikanthLogic,
who found the comment hard to understand.

Change-Id: Idd686257bc4d44f93e06b5645bdc1531bb2b4a2e

includes/SkinTemplate.php

index d08b7ef..511443f 100644 (file)
@@ -581,10 +581,12 @@ class SkinTemplate extends Skin {
                        );
 
                        # We need to do an explicit check for Special:Contributions, as we
-                       # have to match both the title, and the target (which could come
-                       # from request values or be specified in "sub page" form. The plot
+                       # have to match both the title, and the target, which could come
+                       # from request values (Special:Contributions?target=Jimbo_Wales)
+                       # or be specified in "sub page" form
+                       # (Special:Contributions/Jimbo_Wales). The plot
                        # thickens, because the Title object is altered for special pages,
-                       # so doesn't contain the original alias-with-subpage.
+                       # so it doesn't contain the original alias-with-subpage.
                        $origTitle = Title::newFromText( $request->getText( 'title' ) );
                        if( $origTitle instanceof Title && $origTitle->isSpecialPage() ) {
                                list( $spName, $spPar ) = SpecialPageFactory::resolveAlias( $origTitle->getText() );