jenkins-bot [Mon, 4 Mar 2019 13:45:03 +0000 (13:45 +0000)]
Merge "mediawiki.cldr: Move file to its own directory"
Aaron Schulz [Wed, 27 Feb 2019 01:04:24 +0000 (17:04 -0800)]
objectcache: optimize WAN cache key updates during HOLDOFF_TTL
Avoid the ADD operation spam from all threads trying to access
a tombstoned key by checking the interim value cache timestamp.
This also avoids the GET/CAS spam from threads that manage to
get the mutex. If a single thread repeatedly accesses the same
tombstoned value in rapid succession, there will significantly
less cache operation spam.
Do the same for cache updates to keys in the holdoff state
due to "check keys" or the "touchedCallback" function.
Relatedly, fix getWithSetCallback() to disregard interim values
set prior to or at the same time as the latest delete() call.
This can slightly reduce the chance of the cache being behind
replica DBs for a second. It also avoids unit test failures
were a series of deletes and cache access happen at the same
timestamp (via time injection or regular system time calls).
In addition:
* Add PASS_BY_REF flag with backwards compatibility to avoid
bloating the signature of get()/getMulti() with the new
tombstone information needed for the above changes.
* Avoid confusing pass-by-reference in getInterimValue() and
fix use of incorrect $asOf parameter.
* Move some more logic into setInterimValue().
* Update some comments regarding broadcasted operations that
were not true for the currently assumed mcrouter setup.
* Rename $cValue => $curValue and $versioned => $needsVersion
for better readability.
Bug: T203786
Change-Id: I0eb3f9b697193d39a70dd3c0967311ad7e194f20
Gilles Dubuc [Mon, 4 Mar 2019 08:46:56 +0000 (09:46 +0100)]
Fix typo in Priority Hints static variable name
Bug: T216499
Change-Id: I444292afd1b8fcc81e7cf204f82ed512f53bcc85
jenkins-bot [Mon, 4 Mar 2019 05:29:10 +0000 (05:29 +0000)]
Merge "Remove unused method Title::validateFileMoveOperation()"
jenkins-bot [Mon, 4 Mar 2019 05:24:05 +0000 (05:24 +0000)]
Merge "API: Handle Messages in errorArrayToStatus()"
Holger Knust [Thu, 28 Feb 2019 20:37:40 +0000 (15:37 -0500)]
Remove unused method Title::validateFileMoveOperation()
This method has never been used and isn't covered by the deprecation
policy since it was protected.
Bug: T214316
Change-Id: I96404792e895f12abec048c62c4b70d86a3d8310
jenkins-bot [Mon, 4 Mar 2019 03:54:42 +0000 (03:54 +0000)]
Merge "Avoid cached lag logging spam from changes list pages"
jenkins-bot [Mon, 4 Mar 2019 03:36:32 +0000 (03:36 +0000)]
Merge "Various fixes to make phan-taint-check happier"
jenkins-bot [Mon, 4 Mar 2019 03:24:47 +0000 (03:24 +0000)]
Merge "Various fixes for phan-taint-check"
Brian Wolff [Sun, 17 Feb 2019 11:32:50 +0000 (11:32 +0000)]
Various fixes to make phan-taint-check happier
Bug: T216348
Change-Id: If4071e689f476d2138d8964598c5a02b09448677
jenkins-bot [Mon, 4 Mar 2019 03:21:26 +0000 (03:21 +0000)]
Merge "Use htmlspecialchars() not htmlentities in xml export for validity"
Aaron Schulz [Mon, 4 Mar 2019 02:32:47 +0000 (18:32 -0800)]
Avoid cached lag logging spam from changes list pages
We do not really care about snapshot lag for these cases, so make
them use the same method that getCacheSetOptions() uses.
Bug: T160833
Change-Id: I238aa48e0cdafb2a7f06cae93642797439f94091
Brian Wolff [Sun, 17 Feb 2019 11:45:06 +0000 (11:45 +0000)]
Various fixes for phan-taint-check
Bug: T216348
Change-Id: Id9e7a4704d62457cac9bd1ca6044dec76472e371
jenkins-bot [Mon, 4 Mar 2019 00:57:40 +0000 (00:57 +0000)]
Merge "Status: Make various improvements to the Status class"
Derick Alangi [Sun, 3 Mar 2019 20:10:12 +0000 (21:10 +0100)]
Status: Make various improvements to the Status class
These improvements touches areas such as;
- strict comparison as count() returns in int.
- use of single quotes for string literals.
- use of RequestContext to get the user's Language object.
- fix minor typo.
The todo for using RequestContext was added in
7c543bb6c25.
It used `$wgLang` at the time for consistency with Message.php,
which was changed in 2016 with
0beb5ca992c. Hence, it's now
fine here as well.
Change-Id: I943dfd761a8fca7e8b6658e3c9510ddc6694f042
Translation updater bot [Sun, 3 Mar 2019 21:00:41 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I88973d2b1ab48171ec8d909a69540d03ed229a4e
jenkins-bot [Sun, 3 Mar 2019 18:18:15 +0000 (18:18 +0000)]
Merge "resources: Remove 'jquery.mockjax' module"
Timo Tijhof [Sun, 3 Mar 2019 18:11:08 +0000 (18:11 +0000)]
resourceloader: Remove warning for handled localStorage error
Leads to more confusion that actual utility in practice.
The storage being disabled is an entirely supported and expected
scenario, which we handle gracefully.
When wanting to ad-hoc check whether localStorage is enabled,
browsers tend to show that in their interface already (e.g. to
the side of the address bar in Chrome). And it can also be
trivially checked from the console by looking at localStorage
or mw.loader.store.
Bug: T195647
Change-Id: I1edf89e52ec56b4919816878924f096d5b7f7751
Umherirrender [Fri, 8 Feb 2019 18:05:27 +0000 (19:05 +0100)]
Move specialpage redirects related classes to own files
Change-Id: Ibddbb0c4e40fff310b1720ec9c72f2683cc93f54
Timo Tijhof [Sun, 3 Mar 2019 17:46:22 +0000 (17:46 +0000)]
mediawiki.cldr: Move file to its own directory
Bug: T193826
Change-Id: I763ce0e8b500a9f499a4fc3f76da036b745a0054
Thiemo Kreuz [Thu, 28 Feb 2019 11:04:31 +0000 (12:04 +0100)]
maintenance: Remove unused code from several maintenance scripts
The most notable removal is done in the orphans script. This code was
really never used. Brion introduced it in 2005, already disabled.
I have all the respect for what Brion did. I just think it does not make
much sense to keep code around for so long if it does not work anyway,
and must be rewritten from scratch anyway now that we have multi-content
revisions and such.
Change-Id: I4e8050929f90e44a6e6051bf938993a8b0cdf649
jenkins-bot [Sun, 3 Mar 2019 14:36:53 +0000 (14:36 +0000)]
Merge "Fix usage of MediaWikiServices in comments and documentation"
Fomafix [Sun, 3 Mar 2019 13:40:58 +0000 (14:40 +0100)]
Fix usage of MediaWikiServices in comments and documentation
MediaWikiServices::getFoo()
is wrong. Right is:
MediaWikiServices::getInstance()->getFoo()
Change-Id: Ib6d844ddfe5bd6ccd72b887a63d9ad476c8d196f
Derick Alangi [Sun, 3 Mar 2019 12:23:47 +0000 (13:23 +0100)]
installer: Replace the use of global $wgParser with services
global $wgParser was deprecated in 1.32 and services are used
instead to get the parser object via MediaWikiServices. Making
this replacement as we're avoiding globals.
Change-Id: I967a52c481bfcc83552053a03e88acb038810828
Timo Tijhof [Sun, 3 Mar 2019 01:42:58 +0000 (01:42 +0000)]
resources: Remove 'jquery.mockjax' module
Added in r93908 (2011,
aa1bc6f742c0) for use by UploadWizard,
but this never happened. Instead, the UploadWizard extension
had its own copy for a awhile, but that isn't used anymore
either.
It's never been updated or seen other maintenance, and is
redundant nowadays with Sinon.
Bug: T202154
Change-Id: Ief4c87ac62efa32dbbfadea3e52bfce5db8bf184
Timo Tijhof [Sun, 3 Mar 2019 01:22:45 +0000 (01:22 +0000)]
resources: Remove 'jquery.xmldom' module
Added in r93908 (2011,
aa1bc6f742c0), for use by UploadWizard,
but as far as I can tell this never happened, and it's not
in use currently anywhere in Wikimedia Git or elsewhere indexed
by Codesearch.
It's never been updated or otherwise seen maintenance, and seems
obsolete with native browser features nowadays.
Bug: T202154
Change-Id: I6eccf4f488b6e8d7afa5eb81505895d0729cbfea
Timo Tijhof [Sun, 3 Mar 2019 01:58:08 +0000 (01:58 +0000)]
build: Add names to Fresnel scenarios
Per T216854, it's now supported to give the scenarios a name.
This way, the Jenkins build will have headings like "scenario View a page"
instead of "scenario 0", which is difficult to look up or
understand without the config file side-by-side.
Change-Id: If9884c38eef8b05637a8045c4beb3f2bbf8f5de5
Brian Wolff [Sun, 17 Feb 2019 11:36:13 +0000 (11:36 +0000)]
Various fixes to make phan-taint-check happier
Bug: T216348
Change-Id: Ice672eed3b7e4a199e1307a6477ffe31502b97b5
jenkins-bot [Sat, 2 Mar 2019 23:48:48 +0000 (23:48 +0000)]
Merge "Add separate log action for file reverts"
Kunal Mehta [Sat, 23 Feb 2019 04:44:10 +0000 (20:44 -0800)]
validateRegistrationFile: Accept glob patterns
I've had this locally for a while now - it makes it easier to validate all
extension.json files that you might have checked out. The only catch is that
you have to escape the glob pattern from your shell.
Change-Id: Ic220034574129fab9e850f91c05dbd5e241f556c
MGChecker [Mon, 1 Oct 2018 18:05:44 +0000 (20:05 +0200)]
Add separate log action for file reverts
This change s adds 'revert' as a separate log action for file reverts, as it
allows special formatting of log entries and revisions in UI and filtering
for file reverts specifically.
Even though there are no log entries with this log action right now, it does
seem that this was intended as some point, as there are corresponding
test cases in UploadLogFormatterTest, and is listed in
$wgLogActionsHandlers and https://www.mediawiki.org/wiki/API:Logevents
as well. Furthermore, the i18n message 'logentry-upload-revert' already
existed before this change.
Because this functionality can not be provided by tags, the 'mw-undo' tag
is not suited for this use case. However, it could be added additionally to
all log entries with this log action..
Bug: T60209
Change-Id: Ie1ccd8053dc5de58b2297a8460219f0233aab968
Translation updater bot [Sat, 2 Mar 2019 20:56:43 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I333fd839423300bc3d1b9c62791a2d672a24d070
Umherirrender [Fri, 15 Feb 2019 19:11:49 +0000 (20:11 +0100)]
Move FauxResponse class to own file
Similar to FauxRequest
Change-Id: Ia9e4e7287ade605899d935db7c9f1f017e0bcb85
Timo Tijhof [Sat, 2 Mar 2019 17:01:18 +0000 (17:01 +0000)]
logging: Remove 'null' return from ManualLogEntry::getTags()
The documentation already claimed it returned array,
this is now actually true. Follows-up
037c06e886c63.
There are two ways it could be null:
* The setTags() method was never called, and the class member
was implicitly null by default.
* The setTags() method was called with $tags = null.
This happens WikiPage::doUpdateRestrictions() among other places.
That could probably be fixed, but is out of scope for this change.
The getTags() method of this clss appears to have no outside
callers in MediaWiki core, nor in any other project indexed
by Codesearch.
Change-Id: Ib89c79ef90870506187c3c3b61464c2aa788c594
jenkins-bot [Sat, 2 Mar 2019 03:51:05 +0000 (03:51 +0000)]
Merge "Show password policy flags on Special:PasswordPolicies"
Gergő Tisza [Sun, 20 Jan 2019 02:16:51 +0000 (18:16 -0800)]
Show password policy flags on Special:PasswordPolicies
Follow-up to I28c31fc4ea.
Also improves what policy values are considered disabled, documents
how to extend core checks/flags and adds a structure test for it.
Bug: T118774
Change-Id: I66bf396e8e8a8c310a47ba337abe9070e7e83ff6
Fomafix [Thu, 14 Feb 2019 17:43:55 +0000 (18:43 +0100)]
Recentchanges: Hide instead of disable namespace selector checkboxes
* Set the initial state of the visibility of the checkboxes already in
HTML. This avoids a flash of not-hidden checkboxes while loading.
* Also add class="mw-input-with-label" to prevent line breaks in the
label.
Change-Id: I15781b95590faa9cf65c19fe6fc84fa94ec786dc
jenkins-bot [Fri, 1 Mar 2019 22:03:26 +0000 (22:03 +0000)]
Merge "Simplify strings in PHP code"
jenkins-bot [Fri, 1 Mar 2019 21:51:24 +0000 (21:51 +0000)]
Merge "maintenance: Replace custom .ext extraction with pathinfo()"
jenkins-bot [Fri, 1 Mar 2019 21:17:55 +0000 (21:17 +0000)]
Merge "Add mediawiki.interface.helpers.styles where it is needed"
Fomafix [Fri, 1 Mar 2019 21:15:22 +0000 (22:15 +0100)]
Simplify strings in PHP code
Change-Id: I481810ade68b0c5a5be21d22e2a107646d5813e6
jenkins-bot [Fri, 1 Mar 2019 20:25:21 +0000 (20:25 +0000)]
Merge "Add UserSendConfirmationMail hook"
jenkins-bot [Fri, 1 Mar 2019 19:31:55 +0000 (19:31 +0000)]
Merge "Hygiene: use null-coalescing operator when operating on tags"
jdlrobson [Thu, 28 Feb 2019 21:12:26 +0000 (13:12 -0800)]
Add mediawiki.interface.helpers.styles where it is needed
Bug: T212613
Change-Id: I7d5920c3464838f68dc1169779e2f2662a3e336e
Piotr Miazga [Fri, 1 Mar 2019 18:13:28 +0000 (19:13 +0100)]
Hygiene: use null-coalescing operator when operating on tags
Change-Id: I7d5b4e05ee6c010b4f9438bc4871a3369b1871a6
Thiemo Kreuz [Tue, 26 Feb 2019 12:57:24 +0000 (13:57 +0100)]
Replace lowercase {@inheritdoc} with @inheritDoc
According to the coding standards we even enforce with a custom PHPCS sniff.
It currently does not pick these mistakes up because of the curly brackets.
I'm not sure if this is worth an update of the PHPCS sniff. I wanted to
suggest this fix anyway.
Change-Id: I9041ea7a00baf7f55e0ff0e56879a89fb74bb479
Thiemo Kreuz [Thu, 28 Feb 2019 08:55:50 +0000 (09:55 +0100)]
maintenance: Add missing limit parameters to some explode()
This is, in theory, a loophole that can not only cause such code to
consume suprising amounts of memory and runtime. It can also create
suprising results. For example, an input like
-param="might contain a = char"
might result in a cut-off value.
Not so much of a problem in a maintenance script. But still good
practice, I find.
Change-Id: I14fb278e6fdb61d0c486ca7e23229851ea479408
Thalia [Fri, 1 Mar 2019 14:21:01 +0000 (14:21 +0000)]
Remove references to obsolete special page and messages
Remove references to Special:BlockMe, and messages 'proxyblocker-disabled'
and 'proxyblocksuccess' from the documentation for proxy block messages.
Restore the updated documentation introduced in the patch that removed
these (Id4c7521443f049), which was reversed in I922e660fafc7a95.
Change-Id: I98fa1b48506b5592b5f59e23520c3f0872ff4b4a
Brad Jorsch [Fri, 1 Mar 2019 14:49:05 +0000 (09:49 -0500)]
API: Handle Messages in errorArrayToStatus()
Two bugs here:
* If the error array contains an entry using a Message object instead of
a string as the key, it'll blow up trying to do
`self::$blockMsgMap[$error[0]]`.
* If the error array contains a Message object not wrapped in an array,
it'll blow up trying to do `...(array)$error`.
Bug: T217382
Change-Id: I2a08e02bca0fb194416b3f2e6a1d6192d5c13cb2
jenkins-bot [Fri, 1 Mar 2019 03:00:21 +0000 (03:00 +0000)]
Merge "rdbms: document Database::doQuery() return value"
jenkins-bot [Fri, 1 Mar 2019 02:58:34 +0000 (02:58 +0000)]
Merge "Avoid use of deprecated ObjectCache::getMainWANInstance method"
jenkins-bot [Fri, 1 Mar 2019 02:50:11 +0000 (02:50 +0000)]
Merge "obectcache: split out some WAN cache refresh logic into scheduleAsyncRefresh()"
Aaron Schulz [Thu, 28 Feb 2019 20:42:20 +0000 (12:42 -0800)]
Avoid use of deprecated ObjectCache::getMainWANInstance method
Change-Id: I429e68c8642a00afa812f5ae900c1fb4f8308528
jenkins-bot [Fri, 1 Mar 2019 02:37:27 +0000 (02:37 +0000)]
Merge "Remove comments literally repeating the next line of code"
Aaron Schulz [Fri, 1 Mar 2019 02:21:49 +0000 (18:21 -0800)]
rdbms: document Database::doQuery() return value
Removed random @throws tag from a subclass while at it
Change-Id: I1cad1f66b62bb4a306feb5c773ed5556891f82a7
jenkins-bot [Fri, 1 Mar 2019 01:25:03 +0000 (01:25 +0000)]
Merge "Fix is_array check in ResourceLoaderImageModule"
Volker E [Fri, 1 Mar 2019 00:17:02 +0000 (16:17 -0800)]
RCFilters: Make SaveFiltersPopup header's label and icon wrap
Wrapping SaveFiltersPopup header's label and icon in languages like
Catalan and German.
Also re-positioning close button from absolute top and remove duplicated,
inherited properties.
Change-Id: I3fd35b237f82ab95b66e6e710cba36cf1887618f
Translation updater bot [Thu, 28 Feb 2019 21:04:55 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibd3587a45d063cdd7f7276bd15319f1067819eab
Umherirrender [Thu, 28 Feb 2019 20:06:53 +0000 (21:06 +0100)]
Fix is_array check in ResourceLoaderImageModule
Checking the variable used as expression in the foreach seems wrong.
Also the var is already checked before, so this is the wrong var name
Change-Id: Ia2a7352422ace1e78949a2009b0ad1f16681fc74
Aaron Schulz [Sat, 3 Mar 2018 00:21:36 +0000 (16:21 -0800)]
Stash WatchedItem changes so that the jobs run from the queue
Previously, the jobs ran at post-send instead of via runners.
The stash is still written to immediately and will quickly
replicate to all datacenters. Since the stash and DB data is
merged on access, users should still almost always see their
changes on the next request. There is still the small chance
of unusually high latency at the in-memory stash layer, which
should be rare.
Also inject the JobQueueGroup into the store instance instead
of adding more singleton references.
Bug: T188801
Change-Id: Ic1c2b5a3592469b5b8386012a9c3365fdcf5b8e1
jenkins-bot [Thu, 28 Feb 2019 14:25:08 +0000 (14:25 +0000)]
Merge "DateTimeFormatter: Use mw.RegExp.escape from 'mediawiki.RegExp'"
jenkins-bot [Thu, 28 Feb 2019 14:25:03 +0000 (14:25 +0000)]
Merge "Preferences: Remove href="#" from stub threshold sample link"
Fomafix [Mon, 18 Feb 2019 09:03:56 +0000 (10:03 +0100)]
Preferences: Remove href="#" from stub threshold sample link
* Prevents the sample link from being focusable and selectable via
keyboard navigation.
* Prevents the sample link from being clicked, which would switch
to the first preferences tab and scroll to the top, unhelpfully.
* Since
4f8967672d an <a> without an href also has cursor:pointer on
hover.
Change-Id: I679e277d17dc679177c29d557806c9a9e91c6703
Fomafix [Thu, 28 Feb 2019 13:16:17 +0000 (14:16 +0100)]
Add missing dependency on module 'mediawiki.RegExp'
moment-locale-overrides.js uses mw.RegExp.escape() from module
'mediawiki.RegExp'.
Change-Id: Iac669355ca1c763a34b28badc2bac3fd08e57db9
jenkins-bot [Thu, 28 Feb 2019 12:31:31 +0000 (12:31 +0000)]
Merge "mw-ui-radio, mw-ui-checkbox: Don't reset every font style"
Thalia [Thu, 28 Feb 2019 11:43:01 +0000 (11:43 +0000)]
Document the 'sitewide' option for the Block class
Change-Id: Ie2bebc6e9b42e21159cba35315b86c2d1971bf33
Thiemo Kreuz [Thu, 28 Feb 2019 10:47:07 +0000 (11:47 +0100)]
maintenance: Replace custom .ext extraction with pathinfo()
Note the custom code was not working correctly for filenames that do
not contain a dot. I assume this is not relevant for the filenames this
code needs to process.
Change-Id: Id4578bc86203dcbd9f76928bbec71a2c46176e11
Fomafix [Thu, 28 Feb 2019 08:49:33 +0000 (09:49 +0100)]
DateTimeFormatter: Use mw.RegExp.escape from 'mediawiki.RegExp'
Change-Id: I7aa0264f58d7f79fd80da2a3bb37caa767d78474
jenkins-bot [Thu, 28 Feb 2019 08:42:04 +0000 (08:42 +0000)]
Merge "maintenance: Remove arguments that match their default values"
Santhosh Thottingal [Tue, 26 Feb 2019 12:02:00 +0000 (17:32 +0530)]
mw-ui-radio, mw-ui-checkbox: Don't reset every font style
The following existing style:
.client-js .mw-ui-radio:not( #noop ) {
* {
font: inherit;
}
}
is a strong reset, preventing any font style customization such
as a bold label for .mw-ui-radio.
Change it only to font-size as required for the original reason
for override. Same for .mw-ui-checkbox
I am not sure whether this override is required now, but not going
in to that now.
Change-Id: I5d1815bcfa897bdb03c81be11f63e1acb9412c10
Aaron Schulz [Thu, 28 Feb 2019 01:13:40 +0000 (17:13 -0800)]
obectcache: split out some WAN cache refresh logic into scheduleAsyncRefresh()
Change-Id: If5f895a0d38cd0d6861125000df4fcfc66f1eeb3
Bartosz Dziewoński [Mon, 25 Feb 2019 20:08:10 +0000 (21:08 +0100)]
Check normalization rules of usernames during signup
The username may need to be adjusted due to technical restrictions
for page titles: the first letter is capitalized, underscores are
changed to spaces, and so on. Some of these tweaks can be unwanted
by some users: for example "Matma Rex" and "matmarex" are both
acceptable usernames for me, but "Matmarex" is not.
Display a warning if that happens (if the user has JavaScript
enabled). No action is needed from the user, other than reading
the message.
Bug: T63416
Change-Id: I120f17ca3801879ad650e5a81e7a4c270540cd4f
Roan Kattouw [Wed, 27 Feb 2019 02:16:49 +0000 (18:16 -0800)]
Add UserSendConfirmationMail hook
Allow extensions to modify the confirmation email.
Bug: T215665
Change-Id: I4bcf76699a5114292fc19085fe441de8b898a8d3
jenkins-bot [Wed, 27 Feb 2019 22:43:54 +0000 (22:43 +0000)]
Merge "API: Use log context for api-feature-usage log"
Brad Jorsch [Wed, 27 Feb 2019 20:51:38 +0000 (15:51 -0500)]
API: Use log context for api-feature-usage log
The text message is deprecated.
Bug: T217162
Change-Id: Ie891257140ea19369e10b2e91463a1fb4aa5d233
jenkins-bot [Wed, 27 Feb 2019 21:22:45 +0000 (21:22 +0000)]
Merge "objectcache: simplify WAN cache unwrap() method by removing FLG_STALE"
Derick Alangi [Mon, 25 Feb 2019 17:11:57 +0000 (18:11 +0100)]
maintenance: Remove arguments that match their default values
Calls to methods with arguments as default values can safely be
removed as there is an exact match. With or without them, code
will still work as intended.
Change-Id: Id8141626a51d9cc8bf8bc0baeb5e38d120664da5
jenkins-bot [Wed, 27 Feb 2019 19:10:08 +0000 (19:10 +0000)]
Merge "Use splat operator in HamcrestPHPUnitIntegration"
Aaron Schulz [Tue, 26 Feb 2019 22:09:52 +0000 (14:09 -0800)]
objectcache: simplify WAN cache unwrap() method by removing FLG_STALE
Instead, make the "high read lag with lockTSE" case just lower FLD_TTL.
This also avoids constant regenerations by threads getting the mutex.
Added logging for TTL adjustments in set() for the lockTSE case.
Also remove some delete() calls from tests that were not needed.
Change-Id: Id7695f0377235e4a2f6e0efc88e870c8a990c3b0
jenkins-bot [Wed, 27 Feb 2019 17:46:53 +0000 (17:46 +0000)]
Merge "redis: Fix incomplete @var documentation in RedisConnRef"
Thiemo Kreuz [Wed, 27 Feb 2019 15:29:35 +0000 (16:29 +0100)]
Remove comments literally repeating the next line of code
I would argue that these comments do not add any information that
would not be there already. Having them adds mental overhead, because
one needs to read both the comment and the next line of code first to
understand they say the exact same. I don't find this helpful, but
more distracting.
Change-Id: I39c98f25225947ebffdcc2fd8f0243e7a6c070d7
jenkins-bot [Wed, 27 Feb 2019 17:25:09 +0000 (17:25 +0000)]
Merge "Add tests to ensure that retrieved actions match passed in restrictions"
David Barratt [Wed, 20 Feb 2019 03:18:14 +0000 (22:18 -0500)]
Add tests to ensure that retrieved actions match passed in restrictions
This is a theoretical issue where a passed in restriction does not match the
retrieved actions. There are no actions like this in MediaWiki core or known
extensions, but since the possibility exists, tests should exist to prevent
the issue before it happens.
Bug: T213220
Change-Id: I58da016768a3ee958baa2a25b8177a9e667fa955
Elliott Eggleston [Wed, 27 Feb 2019 15:48:58 +0000 (10:48 -0500)]
Fix warning on QUnit modules without dependencies
Check if $module['dependencies'] is set before checking whether
it's a string.
Change-Id: I9ece83d4ec92d0d3a41a1c6863492e646f011eab
Thiemo Kreuz [Wed, 27 Feb 2019 15:33:55 +0000 (16:33 +0100)]
redis: Fix incomplete @var documentation in RedisConnRef
Change-Id: Id6cf3731986a004ffa80611fcf02c43fd6609ff1
jenkins-bot [Wed, 27 Feb 2019 14:28:01 +0000 (14:28 +0000)]
Merge "Document type for class properties in ResourceLoaderImageModule"
Max Semenik [Wed, 27 Feb 2019 03:24:27 +0000 (19:24 -0800)]
Hard deprecate MWNamespace::canTalk()
Deprecated in 1.30, it had 1 usage outside of tests, removing it in
this patch.
Change-Id: Ia88b004ac3a5d6f47ece1132f80f713d54a04654
jenkins-bot [Wed, 27 Feb 2019 04:53:16 +0000 (04:53 +0000)]
Merge "Fix read-only mode for LoadBalancerSingle"
Kunal Mehta [Wed, 27 Feb 2019 02:52:03 +0000 (18:52 -0800)]
Use splat operator in HamcrestPHPUnitIntegration
Change-Id: I1421748fd338137dd6990775e0d79a6cfb82aa9d
jenkins-bot [Wed, 27 Feb 2019 01:50:37 +0000 (01:50 +0000)]
Merge "mw.ui forms: Style individual form field warnings, as well as errors"
Roan Kattouw [Wed, 27 Feb 2019 01:24:10 +0000 (17:24 -0800)]
mw.ui forms: Style individual form field warnings, as well as errors
If you put a <span class="error"> inside a vform-field, it would display
correctly, but a <span class="warning"> wouldn't. Make it work for both.
Change-Id: I9e582ade2fca87782aa7be38774fa4943dc196da
jenkins-bot [Tue, 26 Feb 2019 23:22:59 +0000 (23:22 +0000)]
Merge "Remove unnecessary variable from UserTest"
jenkins-bot [Tue, 26 Feb 2019 22:44:51 +0000 (22:44 +0000)]
Merge "resourceloader: Add getScript() method for loading scripts with callback"
Thalia [Tue, 26 Feb 2019 22:15:31 +0000 (22:15 +0000)]
Remove unnecessary variable from UserTest
Change-Id: I2aaae36cc3102b309aa8f5ab05f512c4fbf9810c
Aaron Schulz [Wed, 23 Jan 2019 19:32:18 +0000 (11:32 -0800)]
rdbms: make safeWaitForMasterPos() handle master connection failure
Previously, in such cases where a master connection was needed
and could not be acquired, a fatal error would occur. Instead,
throw a DBReplicationWaitError exception.
Also removed a redundant documentation block for the method.
Change-Id: Ide3015d57673df0876daf265a0182fe41004052d
Petr Pchelko [Thu, 21 Feb 2019 02:09:41 +0000 (18:09 -0800)]
Emit new style API action logs into Monolog.
Bug: T214080
Depends-On: I454d3d12dcc1d7e525dc468df90424e68df59d78
Change-Id: Id0be845884cd834d89df897cc8a862904caeb09a
Amir Sarabadani [Tue, 26 Feb 2019 12:17:09 +0000 (13:17 +0100)]
Fix lowercase in namespace of LogCapturingSpi.php
Basically turning Mediawiki to MediaWiki as all other classes exist
in that namespace
Bug: T217128
Change-Id: I95039a1a54c9900a2f2414b5a6ccce5fb6e5e612
jenkins-bot [Tue, 26 Feb 2019 11:03:17 +0000 (11:03 +0000)]
Merge "selenium: improve ffmpeg reporting"
jenkins-bot [Tue, 26 Feb 2019 05:30:36 +0000 (05:30 +0000)]
Merge "DatabasePostgres: Ignore "IGNORE" option to update()"
Evad37 [Sat, 2 Feb 2019 05:42:00 +0000 (13:42 +0800)]
resourceloader: Add getScript() method for loading scripts with callback
Provides a friendly wrapper for loading scripts using $.ajax().
Returns a promise when the script dependency -- a single
script url -- has been loaded. This matches how mw.loader.load
is able to load a script url, and how mw.loader.using will
return a promised that is resolved when dependecies are loaded,
or rejected if there is an error.
Added as a separate function mw.loader.getScript(), rather
than adding this functionality to using(), as it is a separate
use case, less confusing for users, and there is no shared or
duplicated code between loading a script and loading one
or more named modules.
Bug: T27962
Change-Id: I13be426d03261a2d0c6a1631af94a9f9af58394b