From f411693af3453c281d958feb4326959f88fc5774 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gerg=C5=91=20Tisza?= Date: Sat, 28 Mar 2015 08:37:39 +0000 Subject: [PATCH] Mock error event firing in mw.loader test Change-Id: I5528f5f91a7452ff05b7493466467cf026f59c40 --- .../qunit/suites/resources/mediawiki/mediawiki.test.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js index 18db7f1f52..cf36ea8244 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js @@ -692,10 +692,9 @@ } ); } ); - QUnit.test( 'mw.loader erroneous indirect dependency', 5, function ( assert ) { - // Keep "Error: expected" out of build log - var log = this.sandbox.stub( window.console || {}, 'log' ), - error = this.sandbox.stub( window.console || {}, 'error' ); + QUnit.test( 'mw.loader erroneous indirect dependency', 4, function ( assert ) { + // don't emit an error event + this.sandbox.stub( mw, 'track' ); mw.loader.register( [ ['test.module1', '0'], @@ -709,8 +708,7 @@ assert.strictEqual( mw.loader.getState( 'test.module2' ), 'error', 'Expected "error" state for test.module2' ); assert.strictEqual( mw.loader.getState( 'test.module3' ), 'error', 'Expected "error" state for test.module3' ); - assert.strictEqual( log.callCount, 1 ); - assert.strictEqual( error.callCount, 1 ); + assert.strictEqual( mw.track.callCount, 1 ); } ); QUnit.test( 'mw.loader out-of-order implementation', 9, function ( assert ) { -- 2.20.1