From d617dd1bf43012b0505850ad334800a219b5dade Mon Sep 17 00:00:00 2001 From: Trevor Parscal Date: Sat, 4 Dec 2010 00:35:10 +0000 Subject: [PATCH] Made use of Xml::encodeJsCall - improves on r77693. --- includes/OutputPage.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/includes/OutputPage.php b/includes/OutputPage.php index 508aacea93..ddea5c263c 100644 --- a/includes/OutputPage.php +++ b/includes/OutputPage.php @@ -2436,10 +2436,11 @@ class OutputPage { // Modules requests - let the client calculate dependencies and batch requests as it likes if ( $this->getModules() ) { - $modules = FormatJson::encode( $this->getModules() ); + $modules = FormatJson::encode( ); $scripts .= Html::inlineScript( ResourceLoader::makeLoaderConditionalScript( - "mediaWiki.loader.load( {$modules} ); mediaWiki.loader.go();" + Xml::encodeJsCall( 'mediaWiki.loader.load', $this->getModules() ) . + Xml::encodeJsCall( 'mediaWiki.loader.go' ) ) ) . "\n"; } -- 2.20.1