From 452c73060c5cad90429ba2a89420f4f70ed22989 Mon Sep 17 00:00:00 2001 From: Reedy Date: Sun, 9 Dec 2012 02:33:51 +0000 Subject: [PATCH] Move insertUpdateRow call before return applyPatch to make it reachable This might not be quite right... We might want to cache the result of apply patch, insert the row and then return the result... Change-Id: Ie6a1bb16d2912ad43aa8fd45b2bf10a8bf8652ae --- includes/installer/DatabaseUpdater.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/installer/DatabaseUpdater.php b/includes/installer/DatabaseUpdater.php index b200dcf161..913eef5d55 100644 --- a/includes/installer/DatabaseUpdater.php +++ b/includes/installer/DatabaseUpdater.php @@ -721,8 +721,8 @@ abstract class DatabaseUpdater { } elseif( $this->updateRowExists( $updateKey ) ) { $this->output( "...$field in table $table already modified by patch $patch.\n" ); } else { - return $this->applyPatch( $patch, $fullpath, "Modifying $field field of table $table" ); $this->insertUpdateRow( $updateKey ); + return $this->applyPatch( $patch, $fullpath, "Modifying $field field of table $table" ); } return true; } -- 2.20.1