From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 30 Sep 2009 00:47:54 +0000 (+0000)
Subject: Revert r56902 "(bug 18436) remove redundant (and disruptive to CSS) hardcoded "displa... 
X-Git-Tag: 1.31.0-rc.0~39471
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/categories/modifier.php?a=commitdiff_plain;h=dda0d206f27f1d4886cba01655153029f8fc5079;p=lhc%2Fweb%2Fwiklou.git

Revert r56902 "(bug 18436) remove redundant (and disruptive to CSS) hardcoded "display:inline" style from messages injected with jsMsg()."
Totally broken; breaks at least Vector skin and any other which includes an initially-hidden div for the JS messages -- the div was no longer being unhidden.
Just use a !important in your custom style...
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 70365c190b..56057d5ea8 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -530,8 +530,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 20702) Parser functions can now be used correctly in
   MediaWiki:Missing-article
 * (bug 14117) "redirected from" is now also shown on foreign file redirects
-* (bug 18436) JavaScript-added AJAX messages (from the JS watch/unwatch, for
-  instance) no longer include a redundant "display:block" hardcoded style.
 * (bug 20802) Fixed thumb.php redirect handling
 * (bug 17747) Only display thumbnail column in file history if the image can
   be rendered.
diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index b62cbde4df..06bbff3aec 100644
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -940,6 +940,7 @@ function jsMsg( message, className ) {
 	}
 
 	messageDiv.setAttribute( 'id', 'mw-js-message' );
+	messageDiv.style.display = 'block';
 	if( className ) {
 		messageDiv.setAttribute( 'class', 'mw-js-message-'+className );
 	}