From: Platonides <platonides@gmail.com>
Date: Tue, 17 Apr 2012 20:57:06 +0000 (+0200)
Subject: wfMkdirParents() should display mode in octal.
X-Git-Tag: 1.31.0-rc.0~23882^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/categories/modifier.php?a=commitdiff_plain;h=1e70d71fe08d1a76a1bc20314c2538d9230fb621;p=lhc%2Fweb%2Fwiklou.git

wfMkdirParents() should display mode in octal.

Patchset 2: Address issue pointed out by CR

Change-Id: Ia156903131612f3faa93a7010de2e034d528ec7d
---

diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index 87647830f7..0eb8dc166e 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -2657,7 +2657,8 @@ function wfMkdirParents( $dir, $mode = null, $caller = null ) {
 
 	if( !$ok ) {
 		// PHP doesn't report the path in its warning message, so add our own to aid in diagnosis.
-		trigger_error( __FUNCTION__ . ": failed to mkdir \"$dir\" mode $mode", E_USER_WARNING );
+		trigger_error( sprintf( "%s: failed to mkdir \"%s\" mode 0%o", __FUNCTION__, $dir, $mode ),
+			E_USER_WARNING );
 	}
 	return $ok;
 }